Replace old realtime exceptions with new exceptions #4304

qdpham13 · 2022-11-10T19:31:40Z

Update Realtime exceptions to the ones specified in this doc: go/realtime-rc-sdk-exceptions

google-oss-bot · 2022-11-10T19:32:09Z

	1 Warning
⚠️	Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

google-oss-bot · 2022-11-10T19:36:57Z

Coverage Report ¹

Affected Products

`firebase-config`

Overall coverage changed from ? (290a487) to 80.22% (bb55c49) by ?.

28 individual files with coverage change

Filename	Base (`290a487`)	Merge (`bb55c49`)	Diff
Code.java	?	0.00%	?
ConfigAutoFetch.java	?	88.24%	?
ConfigCacheClient.java	?	93.33%	?
ConfigContainer.java	?	93.06%	?
ConfigFetchHandler.java	?	96.69%	?
ConfigFetchHttpClient.java	?	86.21%	?
ConfigGetParameterHandler.java	?	96.45%	?
ConfigMetadataClient.java	?	90.63%	?
ConfigRealtimeHandler.java	?	21.57%	?
ConfigRealtimeHttpClient.java	?	33.82%	?
ConfigStorageClient.java	?	100.00%	?
ConfigUpdateListener.java	?	0.00%	?
ConfigUpdateListenerRegistration.java	?	0.00%	?
DefaultsXmlParser.java	?	0.00%	?
FirebaseRemoteConfig.java	?	87.83%	?
FirebaseRemoteConfigClientException.java	?	75.00%	?
FirebaseRemoteConfigException.java	?	95.65%	?
FirebaseRemoteConfigFetchThrottledException.java	?	100.00%	?
FirebaseRemoteConfigInfo.java	?	0.00%	?
FirebaseRemoteConfigInfoImpl.java	?	100.00%	?
FirebaseRemoteConfigServerException.java	?	84.21%	?
FirebaseRemoteConfigSettings.java	?	61.54%	?
FirebaseRemoteConfigValue.java	?	0.00%	?
FirebaseRemoteConfigValueImpl.java	?	84.62%	?
Personalization.java	?	91.43%	?
RemoteConfigComponent.java	?	84.71%	?
RemoteConfigConstants.java	?	0.00%	?
RemoteConfigRegistrar.java	?	100.00%	?

Test Logs

Merge (bb55c49): https://github.com/firebase/firebase-android-sdk/actions/runs/3484688625

https://storage.googleapis.com/firebase-sdk-metric-reports/Hn37tAfDf8.html

google-oss-bot · 2022-11-10T19:41:09Z

The public api surface has changed for the subproject firebase-config:
error: Removed method com.google.firebase.remoteconfig.ConfigUpdateListener.onError(Exception) [RemovedMethod]
error: Added method com.google.firebase.remoteconfig.ConfigUpdateListener.onError(com.google.firebase.remoteconfig.FirebaseRemoteConfigException) [AddedAbstractMethod]
error: Removed class com.google.firebase.remoteconfig.FirebaseRemoteConfigRealtimeUpdateFetchException [RemovedClass]
error: Removed class com.google.firebase.remoteconfig.FirebaseRemoteConfigRealtimeUpdateStreamException [RemovedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

github-actions · 2022-11-10T19:43:20Z

Unit Test Results

1 225 tests ±0 1 225 ✔️ ±0 2m 21s ⏱️ +28s
    62 suites ±0       0 💤 ±0
    62 files ±0       0 ❌ ±0

Results for commit e2894dc. ± Comparison against base commit 290a487.

♻️ This comment has been updated with latest results.

google-oss-bot · 2022-11-10T19:45:27Z

Size Report ¹

Affected Products

firebase-config
Type Base (290a487) Merge (bb55c49) Diff
aar 83.1 kB 84.0 kB +912 B (+1.1%)
apk (aggressive) 119 kB 119 kB +492 B (+0.4%)
apk (release) 743 kB 743 kB +320 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/TBknFnLL9X.html

google-oss-bot · 2022-11-10T20:17:38Z

The public api surface has changed for the subproject firebase-config:
error: Removed method com.google.firebase.remoteconfig.ConfigUpdateListener.onError(FirebaseRemoteConfigException) [RemovedMethod]
error: Added method com.google.firebase.remoteconfig.ConfigUpdateListener.onError(com.google.firebase.remoteconfig.FirebaseRemoteConfigException) [AddedAbstractMethod]
error: Removed constructor com.google.firebase.remoteconfig.FirebaseRemoteConfigServerException(String,com.google.firebase.remoteconfig.FirebaseRemoteConfigException.Code.Code) [RemovedMethod]
error: Removed constructor com.google.firebase.remoteconfig.FirebaseRemoteConfigServerException(String,Throwable,com.google.firebase.remoteconfig.FirebaseRemoteConfigException.Code.Code) [RemovedMethod]
error: Removed constructor com.google.firebase.remoteconfig.FirebaseRemoteConfigServerException(int,String,com.google.firebase.remoteconfig.FirebaseRemoteConfigException.Code.Code) [RemovedMethod]
error: Removed constructor com.google.firebase.remoteconfig.FirebaseRemoteConfigServerException(int,String,Throwable,com.google.firebase.remoteconfig.FirebaseRemoteConfigException.Code.Code) [RemovedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot · 2022-11-10T20:55:10Z

The public api surface has changed for the subproject firebase-config:
error: Removed constructor com.google.firebase.remoteconfig.FirebaseRemoteConfigServerException(String,com.google.firebase.remoteconfig.FirebaseRemoteConfigException.Code.Code) [RemovedMethod]
error: Removed constructor com.google.firebase.remoteconfig.FirebaseRemoteConfigServerException(String,Throwable,com.google.firebase.remoteconfig.FirebaseRemoteConfigException.Code.Code) [RemovedMethod]
error: Removed constructor com.google.firebase.remoteconfig.FirebaseRemoteConfigServerException(int,String,com.google.firebase.remoteconfig.FirebaseRemoteConfigException.Code.Code) [RemovedMethod]
error: Removed constructor com.google.firebase.remoteconfig.FirebaseRemoteConfigServerException(int,String,Throwable,com.google.firebase.remoteconfig.FirebaseRemoteConfigException.Code.Code) [RemovedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

...ase-config/src/main/java/com/google/firebase/remoteconfig/FirebaseRemoteConfigException.java

firebase-config/src/main/java/com/google/firebase/remoteconfig/internal/ConfigAutoFetch.java

...ase-config/src/main/java/com/google/firebase/remoteconfig/FirebaseRemoteConfigException.java

danasilver · 2022-11-16T18:04:42Z

...config/src/main/java/com/google/firebase/remoteconfig/internal/ConfigRealtimeHttpClient.java

@@ -346,6 +348,11 @@ public synchronized void beginRealtimeHttpStream() {
      }
    } catch (IOException e) {
      Log.d(TAG, "Exception connecting to realtime stream. Retrying the connection...");
+      propagateErrors(
+          new FirebaseRemoteConfigServerException(


Looks like getResponseCode always return something reasonable, so we can include that here, too https://docs.oracle.com/javase/7/docs/api/java/net/HttpURLConnection.html#getResponseCode()

This is for the case where getResponseCode throws an exceptions and isn't able to return a status code. If it has a non-retryable response code anyways it would be caught in the exceptions below.

Got it. Maybe we can consolidate these later to make the error handling more clear.

google-oss-bot · 2022-11-16T19:16:32Z

The public api surface has changed for the subproject firebase-config:
error: Removed method com.google.firebase.remoteconfig.FirebaseRemoteConfigException.Code.fromValue(int) [RemovedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

...ase-config/src/main/java/com/google/firebase/remoteconfig/FirebaseRemoteConfigException.java

danasilver · 2022-11-16T23:31:03Z

...config/src/main/java/com/google/firebase/remoteconfig/internal/ConfigRealtimeHttpClient.java

@@ -346,6 +348,11 @@ public synchronized void beginRealtimeHttpStream() {
      }
    } catch (IOException e) {
      Log.d(TAG, "Exception connecting to realtime stream. Retrying the connection...");
+      propagateErrors(
+          new FirebaseRemoteConfigServerException(


Got it. Maybe we can consolidate these later to make the error handling more clear.

firebase-config/src/test/java/com/google/firebase/remoteconfig/FirebaseRemoteConfigTest.java

...ase-config/src/main/java/com/google/firebase/remoteconfig/FirebaseRemoteConfigException.java

firebase-config/src/main/java/com/google/firebase/remoteconfig/internal/ConfigAutoFetch.java

Replace old realtime exceptions with new exceptions

42c24a0

google-oss-bot added the size/L label Nov 10, 2022

Fix api.txt and add comments

ee8575b

Fix api.txt

c880ba3

Update api.txt

6080dc2

qdpham13 requested a review from danasilver November 10, 2022 22:23

danasilver reviewed Nov 16, 2022

View reviewed changes

Update based on review comments

c524cfd

qdpham13 requested a review from danasilver November 16, 2022 19:13

Update api.txt

c3a069f

danasilver reviewed Nov 17, 2022

View reviewed changes

Updated tests and comments based on review

e2894dc

qdpham13 requested a review from danasilver November 17, 2022 16:19

danasilver approved these changes Nov 17, 2022

View reviewed changes

qdpham13 merged commit 8251c4a into realtime-rc-merge Nov 17, 2022

qdpham13 deleted the realtime-rc-exceptions branch November 17, 2022 20:23

firebase locked and limited conversation to collaborators Dec 18, 2022

Replace old realtime exceptions with new exceptions #4304

Replace old realtime exceptions with new exceptions #4304

Uh oh!

Conversation

qdpham13 commented Nov 10, 2022

Uh oh!

google-oss-bot commented Nov 10, 2022

Uh oh!

google-oss-bot commented Nov 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report 1

Affected Products

firebase-config

Test Logs

Uh oh!

google-oss-bot commented Nov 10, 2022

Uh oh!

github-actions bot commented Nov 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Results

Uh oh!

google-oss-bot commented Nov 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

firebase-config

Test Logs

Uh oh!

google-oss-bot commented Nov 10, 2022

Uh oh!

google-oss-bot commented Nov 10, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

danasilver Nov 16, 2022

Choose a reason for hiding this comment

Uh oh!

qdpham13 Nov 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

danasilver Nov 16, 2022

Choose a reason for hiding this comment

Uh oh!

google-oss-bot commented Nov 16, 2022

Uh oh!

Uh oh!

danasilver Nov 16, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

google-oss-bot commented Nov 10, 2022 •

edited

Loading

Coverage Report ¹

`firebase-config`

github-actions bot commented Nov 10, 2022 •

edited

Loading

google-oss-bot commented Nov 10, 2022 •

edited

Loading

Size Report ¹

`firebase-config`

qdpham13 Nov 16, 2022 •

edited

Loading