Skip to content

Add icon for in-app feedback notifications #4320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

lfkellogg
Copy link
Contributor

Notification:
image

Status bar:
image

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from ? (a47d68c) to 77.47% (3899016) by ?.

    40 individual files with coverage change

    FilenameBase (a47d68c)Merge (3899016)Diff
    AabUpdater.java?98.68%?
    ApkInstaller.java?96.88%?
    ApkUpdater.java?93.75%?
    AppDistributionReleaseImpl.java?100.00%?
    AppDistributionReleaseInternal.java?100.00%?
    AppIconSource.java?85.71%?
    AutoValue_AppDistributionReleaseImpl.java?65.45%?
    AutoValue_AppDistributionReleaseInternal.java?66.67%?
    AutoValue_ImageUtils_ImageSize.java?35.00%?
    AutoValue_TesterApiDisabledErrorDetails.java?29.41%?
    AutoValue_TesterApiDisabledErrorDetails_HelpLink.java?54.17%?
    AutoValue_UpdateProgressImpl.java?65.96%?
    ErrorMessages.java?0.00%?
    FeedbackActivity.java?1.56%?
    FeedbackSender.java?90.91%?
    FirebaseAppDistributionExceptions.java?80.00%?
    FirebaseAppDistributionFileProvider.java?0.00%?
    FirebaseAppDistributionImpl.java?91.92%?
    FirebaseAppDistributionLifecycleNotifier.java?96.67%?
    FirebaseAppDistributionNotificationsManager.java?80.95%?
    FirebaseAppDistributionRegistrar.java?82.05%?
    FirebaseAppDistributionTesterApiClient.java?87.63%?
    HttpsUrlConnectionFactory.java?50.00%?
    ImageUtils.java?100.00%?
    InstallActivity.java?2.53%?
    LogWrapper.java?68.75%?
    NewReleaseFetcher.java?77.55%?
    PackageInfoUtils.java?42.86%?
    ReleaseIdentifier.java?88.00%?
    ReleaseUtils.java?83.33%?
    ScreenshotTaker.java?62.16%?
    SignInResultActivity.java?0.00%?
    SignInStorage.java?42.86%?
    TakeScreenshotAndStartFeedbackActivity.java?0.00%?
    TaskUtils.java?96.30%?
    TesterApiDisabledErrorDetails.java?93.75%?
    TesterApiHttpClient.java?89.47%?
    TesterSignInManager.java?93.62%?
    UpdateProgressImpl.java?100.00%?
    UpdateTaskImpl.java?75.71%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/MbqY5nLF6H.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-appdistribution

    TypeBase (a47d68c)Merge (3899016)Diff
    aar142 kB143 kB+509 B (+0.4%)
    apk (aggressive)820 kB820 kB+365 B (+0.0%)
    apk (release)2.00 MB2.00 MB+825 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/lhSl0FuIbv.html

@lfkellogg lfkellogg merged commit 6732593 into fad/in-app-feedback Nov 15, 2022
@lfkellogg lfkellogg deleted the lk/add-iaf-notification-icon branch November 15, 2022 13:28
@firebase firebase locked and limited conversation to collaborators Dec 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants