Handle the case where we can't identify the release. #4331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Coverage Report 1Affected Products
Test Logs |
Size Report 1Affected Products
Test Logs |
lfkellogg
reviewed
Nov 15, 2022
There was a problem hiding this comment.
A null release name isn't the most intuitive signal that we are in dev mode, but I see how it makes the Task flow easier in doStartFeedback, as opposed to checking for dev mode when handling the task failure.
Do you think it's worth at least making the argument to FeedbackActivity more explicit? Maybe with a boolean dev mode flag?
...tion/src/main/java/com/google/firebase/appdistribution/impl/FirebaseAppDistributionImpl.java
Outdated
Show resolved
Hide resolved
...ppdistribution/src/main/java/com/google/firebase/appdistribution/impl/ReleaseIdentifier.java
Show resolved
Hide resolved
Ack.
I experimented with it and it was more clunky. I opted for a generous sprinkling of comments (and |
lfkellogg
reviewed
Nov 15, 2022
lfkellogg
pushed a commit
that referenced
this pull request
Nov 21, 2022
Use `adb shell setprop debug.firebase.appdistro.devmode true` for development mode. This mode doesn't verify that a release is present and doesn't actually submit feedback - it just demonstrates the UI,
lfkellogg
pushed a commit
that referenced
this pull request
Dec 7, 2022
Use `adb shell setprop debug.firebase.appdistro.devmode true` for development mode. This mode doesn't verify that a release is present and doesn't actually submit feedback - it just demonstrates the UI,
lfkellogg
pushed a commit
that referenced
this pull request
Dec 9, 2022
Use `adb shell setprop debug.firebase.appdistro.devmode true` for development mode. This mode doesn't verify that a release is present and doesn't actually submit feedback - it just demonstrates the UI,
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developers can use
adb shell setprop debug.firebase.appdistro.devmode trueto skip checking the release version (and skip actually submitting feedback - while keeping the UI).