Skip to content

Use shared executors in App Distribution SDK #4338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

lfkellogg
Copy link
Contributor

Following the guide.

In all three cases we either block for network I/O or synchronization.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 18, 2022

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from ? (26f743d) to 79.11% (f65514b) by ?.

    34 individual files with coverage change

    FilenameBase (26f743d)Merge (f65514b)Diff
    AabUpdater.java?98.67%?
    ApkInstaller.java?96.88%?
    ApkUpdater.java?93.70%?
    AppDistributionReleaseImpl.java?100.00%?
    AppDistributionReleaseInternal.java?100.00%?
    AppIconSource.java?85.71%?
    AutoValue_AppDistributionReleaseImpl.java?65.45%?
    AutoValue_AppDistributionReleaseInternal.java?66.67%?
    AutoValue_TesterApiDisabledErrorDetails.java?29.41%?
    AutoValue_TesterApiDisabledErrorDetails_HelpLink.java?54.17%?
    AutoValue_UpdateProgressImpl.java?65.96%?
    ErrorMessages.java?0.00%?
    FirebaseAppDistributionExceptions.java?80.00%?
    FirebaseAppDistributionFileProvider.java?0.00%?
    FirebaseAppDistributionImpl.java?94.90%?
    FirebaseAppDistributionLifecycleNotifier.java?75.00%?
    FirebaseAppDistributionNotificationsManager.java?80.00%?
    FirebaseAppDistributionRegistrar.java?90.32%?
    FirebaseAppDistributionTesterApiClient.java?87.63%?
    HttpsUrlConnectionFactory.java?50.00%?
    InstallActivity.java?2.53%?
    LogWrapper.java?50.00%?
    NewReleaseFetcher.java?77.55%?
    PackageInfoUtils.java?42.86%?
    ReleaseIdentifier.java?88.00%?
    ReleaseUtils.java?83.33%?
    SignInResultActivity.java?0.00%?
    SignInStorage.java?42.86%?
    TaskUtils.java?96.30%?
    TesterApiDisabledErrorDetails.java?93.75%?
    TesterApiHttpClient.java?89.19%?
    TesterSignInManager.java?93.62%?
    UpdateProgressImpl.java?100.00%?
    UpdateTaskImpl.java?75.71%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/n1t2Hl8Tfm.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 18, 2022

Size Report 1

Affected Products

  • base

    TypeBase (26f743d)Merge (f65514b)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)
  • firebase-annotations

    TypeBase (26f743d)Merge (f65514b)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?9.46 kB? (?)
  • firebase-appdistribution

    TypeBase (26f743d)Merge (f65514b)Diff
    aar?141 kB? (?)
    apk (aggressive)?785 kB? (?)
    apk (release)?2.01 MB? (?)
  • firebase-appdistribution-api

    TypeBase (26f743d)Merge (f65514b)Diff
    aar?14.2 kB? (?)
    apk (aggressive)?95.2 kB? (?)
    apk (release)?707 kB? (?)
  • firebase-common

    TypeBase (26f743d)Merge (f65514b)Diff
    aar?65.3 kB? (?)
    apk (aggressive)?94.5 kB? (?)
    apk (release)?699 kB? (?)
  • firebase-components

    TypeBase (26f743d)Merge (f65514b)Diff
    aar?44.9 kB? (?)
    apk (aggressive)?8.68 kB? (?)
    apk (release)?33.6 kB? (?)
  • firebase-installations

    TypeBase (26f743d)Merge (f65514b)Diff
    aar?55.0 kB? (?)
    apk (aggressive)?96.0 kB? (?)
    apk (release)?723 kB? (?)
  • firebase-installations-interop

    TypeBase (26f743d)Merge (f65514b)Diff
    aar?8.05 kB? (?)
    apk (aggressive)?65.0 kB? (?)
    apk (release)?651 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/hgIEipKvJC.html

@lfkellogg lfkellogg changed the base branch from lk/rebased-fad-next to fad/next November 18, 2022 17:53
@lfkellogg lfkellogg force-pushed the lk/use-shared-executors branch from f359be1 to fb807e0 Compare November 18, 2022 17:54
@lfkellogg lfkellogg merged commit abdd518 into fad/next Nov 18, 2022
@lfkellogg lfkellogg deleted the lk/use-shared-executors branch November 18, 2022 19:08
@firebase firebase locked and limited conversation to collaborators Dec 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants