Skip to content

Fix screenshot taking on platforms with hardware bitmaps #4361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 28, 2022
Merged

Fix screenshot taking on platforms with hardware bitmaps #4361

merged 3 commits into from
Nov 28, 2022

Conversation

lfkellogg
Copy link
Contributor

@lfkellogg lfkellogg commented Nov 23, 2022 •
edited
Loading

@lfkellogg lfkellogg requested a review from kaibolay November 23, 2022 19:05
@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 23, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from ? (6c698c0) to 75.49% (f686c2f) by ?.

    40 individual files with coverage change

    FilenameBase (6c698c0)Merge (f686c2f)Diff
    AabUpdater.java?98.67%?
    ApkInstaller.java?96.88%?
    ApkUpdater.java?93.70%?
    AppDistributionReleaseImpl.java?100.00%?
    AppDistributionReleaseInternal.java?100.00%?
    AppIconSource.java?85.71%?
    AutoValue_AppDistributionReleaseImpl.java?65.45%?
    AutoValue_AppDistributionReleaseInternal.java?66.67%?
    AutoValue_ImageUtils_ImageSize.java?35.00%?
    AutoValue_TesterApiDisabledErrorDetails.java?29.41%?
    AutoValue_TesterApiDisabledErrorDetails_HelpLink.java?54.17%?
    AutoValue_UpdateProgressImpl.java?65.96%?
    ErrorMessages.java?0.00%?
    FeedbackActivity.java?1.12%?
    FeedbackSender.java?84.62%?
    FirebaseAppDistributionExceptions.java?80.00%?
    FirebaseAppDistributionFileProvider.java?0.00%?
    FirebaseAppDistributionImpl.java?89.86%?
    FirebaseAppDistributionLifecycleNotifier.java?92.80%?
    FirebaseAppDistributionNotificationsManager.java?85.00%?
    FirebaseAppDistributionRegistrar.java?81.40%?
    FirebaseAppDistributionTesterApiClient.java?87.63%?
    HttpsUrlConnectionFactory.java?50.00%?
    ImageUtils.java?100.00%?
    InstallActivity.java?2.53%?
    LogWrapper.java?68.75%?
    NewReleaseFetcher.java?77.55%?
    PackageInfoUtils.java?42.86%?
    ReleaseIdentifier.java?85.06%?
    ReleaseUtils.java?83.33%?
    ScreenshotTaker.java?43.40%?
    SignInResultActivity.java?0.00%?
    SignInStorage.java?42.86%?
    TakeScreenshotAndStartFeedbackActivity.java?0.00%?
    TaskUtils.java?96.30%?
    TesterApiDisabledErrorDetails.java?93.75%?
    TesterApiHttpClient.java?89.47%?
    TesterSignInManager.java?93.62%?
    UpdateProgressImpl.java?100.00%?
    UpdateTaskImpl.java?75.71%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/a7BjMrv7nl.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 23, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-appdistribution

    TypeBase (6c698c0)Merge (f686c2f)Diff
    aar144 kB145 kB+1.03 kB (+0.7%)
    apk (aggressive)830 kB831 kB+304 B (+0.0%)
    apk (release)2.01 MB2.01 MB+724 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ys3by9ySHb.html

kaibolay
kaibolay approved these changes Nov 23, 2022
View reviewed changes
@lfkellogg lfkellogg merged commit a98b78e into fad/in-app-feedback Nov 28, 2022
@lfkellogg lfkellogg deleted the lk/fix-screenshots branch November 28, 2022 16:30
lfkellogg added a commit that referenced this pull request Dec 7, 2022
@lfkellogg
Fix screenshot taking on platforms with hardware bitmaps (#4361)
da42c2f 
* Fix screenshot taking on platforms with hardware bitmaps

* Address Kai's feedback

* Suppress lint warning about executors
lfkellogg added a commit that referenced this pull request Dec 9, 2022
@lfkellogg
Fix screenshot taking on platforms with hardware bitmaps (#4361)
24c4b2a 
* Fix screenshot taking on platforms with hardware bitmaps

* Address Kai's feedback

* Suppress lint warning about executors
lfkellogg added a commit that referenced this pull request Dec 20, 2022
@lfkellogg
Fix screenshot taking on platforms with hardware bitmaps (#4361)
680c915 
* Fix screenshot taking on platforms with hardware bitmaps

* Address Kai's feedback

* Suppress lint warning about executors
@firebase firebase locked and limited conversation to collaborators Dec 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaibolay kaibolay kaibolay approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lfkellogg @google-oss-bot @kaibolay