Skip to content

Inject executor service for Realtime components. #4375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2022
Merged

Inject executor service for Realtime components. #4375

merged 1 commit into from
Dec 1, 2022

Conversation

danasilver
Copy link
Contributor

@danasilver
Inject executors for Realtime so async code can be tested.
c95290b 
Inject executor services for Realtime components.
@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-config

    Overall coverage changed from ? (8251c4a) to 80.26% (2e57e03) by ?.

    28 individual files with coverage change

    FilenameBase (8251c4a)Merge (2e57e03)Diff
    Code.java?0.00%?
    ConfigAutoFetch.java?88.24%?
    ConfigCacheClient.java?93.33%?
    ConfigContainer.java?93.06%?
    ConfigFetchHandler.java?96.69%?
    ConfigFetchHttpClient.java?86.21%?
    ConfigGetParameterHandler.java?96.45%?
    ConfigMetadataClient.java?90.63%?
    ConfigRealtimeHandler.java?23.08%?
    ConfigRealtimeHttpClient.java?33.82%?
    ConfigStorageClient.java?100.00%?
    ConfigUpdateListener.java?0.00%?
    ConfigUpdateListenerRegistration.java?0.00%?
    DefaultsXmlParser.java?0.00%?
    FirebaseRemoteConfig.java?87.83%?
    FirebaseRemoteConfigClientException.java?75.00%?
    FirebaseRemoteConfigException.java?95.65%?
    FirebaseRemoteConfigFetchThrottledException.java?100.00%?
    FirebaseRemoteConfigInfo.java?0.00%?
    FirebaseRemoteConfigInfoImpl.java?100.00%?
    FirebaseRemoteConfigServerException.java?84.21%?
    FirebaseRemoteConfigSettings.java?61.54%?
    FirebaseRemoteConfigValue.java?0.00%?
    FirebaseRemoteConfigValueImpl.java?84.62%?
    Personalization.java?91.43%?
    RemoteConfigComponent.java?85.06%?
    RemoteConfigConstants.java?0.00%?
    RemoteConfigRegistrar.java?100.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/VkGI45aHyz.html

@github-actions
Copy link
Contributor

Unit Test Results

1 225 tests   1 225 ✔️  2m 2s ⏱️
     62 suites         0 💤
     62 files           0 ❌

Results for commit c95290b.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-config

    TypeBase (8251c4a)Merge (2e57e03)Diff
    aar84.0 kB84.1 kB+66 B (+0.1%)
    apk (aggressive)119 kB119 kB+72 B (+0.1%)
    apk (release)743 kB743 kB+188 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/zg9oU3lZSA.html

@danasilver danasilver requested a review from qdpham13 November 29, 2022 16:57
@danasilver danasilver merged commit 993673e into realtime-rc-merge Dec 1, 2022
@danasilver danasilver deleted the ds-realtime-executors branch December 1, 2022 19:17
danasilver added a commit that referenced this pull request Dec 20, 2022
@danasilver
Inject executors for Realtime so async code can be tested. (#4375)
5474f9a 
Allows the executor to be injected for testing. This came up testing Add updated params to the Realtime listener callback. #4339.
Prepares Realtime to integrate with Firebase Executors.
@firebase firebase locked and limited conversation to collaborators Jan 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@qdpham13 qdpham13 qdpham13 approved these changes

Assignees
No one assigned
Labels
no-changelog size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danasilver @google-oss-bot @qdpham13