Skip to content

Add spinner when sending feedback #4384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2022
Merged

Add spinner when sending feedback #4384

merged 1 commit into from
Dec 1, 2022

Conversation

lfkellogg
Copy link
Contributor

@lfkellogg lfkellogg requested a review from kaibolay November 30, 2022 23:13
@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 30, 2022 •
edited
Loading

Coverage Report 1

Affected Products

No changes between base commit (18a488f) and merge commit (b4ddec6).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/fdOMDpSV3U.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 30, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-appdistribution

    TypeBase (18a488f)Merge (e979b7b)Diff
    aar145 kB146 kB+108 B (+0.1%)
    apk (aggressive)831 kB831 kB+72 B (+0.0%)
    apk (release)2.01 MB2.01 MB+76 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/7Q6WVVd3f2.html

kaibolay
kaibolay approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@kaibolay kaibolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. And so simple (in retrospect)

@lfkellogg lfkellogg merged commit 81b1897 into fad/in-app-feedback Dec 1, 2022
@lfkellogg lfkellogg deleted the lk/send-spinner branch December 1, 2022 13:51
lfkellogg added a commit that referenced this pull request Dec 7, 2022
@lfkellogg
Add spinner when sending feedback (#4384)
4441c12
lfkellogg added a commit that referenced this pull request Dec 9, 2022
@lfkellogg
Add spinner when sending feedback (#4384)
dcf5545
lfkellogg added a commit that referenced this pull request Dec 20, 2022
@lfkellogg
Add spinner when sending feedback (#4384)
b309dc6
@firebase firebase locked and limited conversation to collaborators Jan 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaibolay kaibolay kaibolay approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lfkellogg @google-oss-bot @kaibolay