Skip to content

./gradlew :firebase-appdistribution:test-app:ktfmtFormat #4387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2022
Merged

./gradlew :firebase-appdistribution:test-app:ktfmtFormat #4387

merged 1 commit into from
Dec 1, 2022

Conversation

kaibolay
Copy link
Contributor

@kaibolay kaibolay commented Dec 1, 2022

didn't build without formatting first

@kaibolay kaibolay requested a review from lfkellogg December 1, 2022 17:11
@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from ? (81b1897) to 75.45% (7b37404) by ?.

    40 individual files with coverage change

    FilenameBase (81b1897)Merge (7b37404)Diff
    AabUpdater.java?98.67%?
    ApkInstaller.java?96.88%?
    ApkUpdater.java?93.70%?
    AppDistributionReleaseImpl.java?100.00%?
    AppDistributionReleaseInternal.java?100.00%?
    AppIconSource.java?85.71%?
    AutoValue_AppDistributionReleaseImpl.java?65.45%?
    AutoValue_AppDistributionReleaseInternal.java?66.67%?
    AutoValue_ImageUtils_ImageSize.java?35.00%?
    AutoValue_TesterApiDisabledErrorDetails.java?29.41%?
    AutoValue_TesterApiDisabledErrorDetails_HelpLink.java?54.17%?
    AutoValue_UpdateProgressImpl.java?65.96%?
    ErrorMessages.java?0.00%?
    FeedbackActivity.java?1.11%?
    FeedbackSender.java?84.62%?
    FirebaseAppDistributionExceptions.java?80.00%?
    FirebaseAppDistributionFileProvider.java?0.00%?
    FirebaseAppDistributionImpl.java?89.86%?
    FirebaseAppDistributionLifecycleNotifier.java?92.80%?
    FirebaseAppDistributionNotificationsManager.java?85.00%?
    FirebaseAppDistributionRegistrar.java?81.40%?
    FirebaseAppDistributionTesterApiClient.java?87.63%?
    HttpsUrlConnectionFactory.java?50.00%?
    ImageUtils.java?100.00%?
    InstallActivity.java?2.53%?
    LogWrapper.java?68.75%?
    NewReleaseFetcher.java?77.55%?
    PackageInfoUtils.java?42.86%?
    ReleaseIdentifier.java?85.06%?
    ReleaseUtils.java?83.33%?
    ScreenshotTaker.java?43.40%?
    SignInResultActivity.java?0.00%?
    SignInStorage.java?42.86%?
    TakeScreenshotAndStartFeedbackActivity.java?0.00%?
    TaskUtils.java?96.30%?
    TesterApiDisabledErrorDetails.java?93.75%?
    TesterApiHttpClient.java?89.47%?
    TesterSignInManager.java?93.62%?
    UpdateProgressImpl.java?100.00%?
    UpdateTaskImpl.java?75.71%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/B0NwTlqw8z.html

lfkellogg
lfkellogg approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@lfkellogg lfkellogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kaibolay kaibolay merged commit e77f3c8 into fad/in-app-feedback Dec 1, 2022
@kaibolay kaibolay deleted the kb/ktfmtFormat branch December 1, 2022 17:24
@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (81b1897) and merge commit (7b37404).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/bmQGKTclEB.html

lfkellogg pushed a commit that referenced this pull request Dec 7, 2022
@kaibolay @lfkellogg
./gradlew :firebase-appdistribution:test-app:ktfmtFormat (#4387)
233dead
lfkellogg pushed a commit that referenced this pull request Dec 9, 2022
@kaibolay @lfkellogg
./gradlew :firebase-appdistribution:test-app:ktfmtFormat (#4387)
6323c25
lfkellogg pushed a commit that referenced this pull request Dec 20, 2022
@kaibolay @lfkellogg
./gradlew :firebase-appdistribution:test-app:ktfmtFormat (#4387)
cdc2a1e
@firebase firebase locked and limited conversation to collaborators Jan 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lfkellogg lfkellogg lfkellogg approved these changes

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaibolay @google-oss-bot @lfkellogg