Skip to content

Remove unused jetbrains annotations dependencies #4456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

lfkellogg
Copy link
Contributor

This has never actually been used. Built and tested locally.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from ? (7192ac7) to 79.52% (815b358) by ?.

    36 individual files with coverage change

    FilenameBase (7192ac7)Merge (815b358)Diff
    AabUpdater.java?98.67%?
    ApkInstaller.java?96.88%?
    ApkUpdater.java?93.70%?
    AppDistributionReleaseImpl.java?100.00%?
    AppDistributionReleaseInternal.java?100.00%?
    AppIconSource.java?85.71%?
    AutoValue_AppDistributionReleaseImpl.java?65.45%?
    AutoValue_AppDistributionReleaseInternal.java?71.58%?
    AutoValue_TesterApiDisabledErrorDetails.java?29.41%?
    AutoValue_TesterApiDisabledErrorDetails_HelpLink.java?54.17%?
    AutoValue_UpdateProgressImpl.java?65.96%?
    ErrorMessages.java?0.00%?
    FirebaseAppDistributionExceptions.java?80.00%?
    FirebaseAppDistributionFileProvider.java?0.00%?
    FirebaseAppDistributionImpl.java?95.60%?
    FirebaseAppDistributionLifecycleNotifier.java?75.00%?
    FirebaseAppDistributionNotificationsManager.java?80.00%?
    FirebaseAppDistributionRegistrar.java?91.67%?
    FirebaseAppDistributionTesterApiClient.java?87.63%?
    HttpsUrlConnectionFactory.java?50.00%?
    InstallActivity.java?2.53%?
    LogWrapper.java?50.00%?
    NewReleaseFetcher.java?77.55%?
    PackageInfoUtils.java?42.86%?
    ReleaseIdentifier.java?88.00%?
    ReleaseUtils.java?83.33%?
    SequentialReference.java?100.00%?
    SignInResultActivity.java?0.00%?
    SignInStorage.java?42.86%?
    TaskCache.java?100.00%?
    TaskUtils.java?91.43%?
    TesterApiDisabledErrorDetails.java?93.75%?
    TesterApiHttpClient.java?89.19%?
    TesterSignInManager.java?93.62%?
    UpdateProgressImpl.java?100.00%?
    UpdateTaskImpl.java?76.00%?

  • firebase-appdistribution-api

    Overall coverage changed from ? (7192ac7) to 63.81% (815b358) by ?.

    11 individual files with coverage change

    FilenameBase (7192ac7)Merge (815b358)Diff
    AppDistributionRelease.java?0.00%?
    BinaryType.java?0.00%?
    FirebaseAppDistribution.java?0.00%?
    FirebaseAppDistributionApiRegistrar.java?0.00%?
    FirebaseAppDistributionException.java?76.92%?
    FirebaseAppDistributionProxy.java?100.00%?
    FirebaseAppDistributionStub.java?83.33%?
    OnProgressListener.java?0.00%?
    UpdateProgress.java?0.00%?
    UpdateStatus.java?0.00%?
    UpdateTask.java?100.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/HQdlioGjsU.html

@github-actions
Copy link
Contributor

Unit Test Results

135 tests   135 ✔️  47s ⏱️
  14 suites      0 💤
  14 files        0

Results for commit b3b43ac.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • base

    TypeBase (7192ac7)Merge (815b358)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)
  • firebase-annotations

    TypeBase (7192ac7)Merge (815b358)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?9.46 kB? (?)
  • firebase-appdistribution

    TypeBase (7192ac7)Merge (815b358)Diff
    aar?145 kB? (?)
    apk (aggressive)?787 kB? (?)
    apk (release)?2.01 MB? (?)
  • firebase-appdistribution-api

    TypeBase (7192ac7)Merge (815b358)Diff
    aar?14.2 kB? (?)
    apk (aggressive)?95.8 kB? (?)
    apk (release)?705 kB? (?)
  • firebase-common

    TypeBase (7192ac7)Merge (815b358)Diff
    aar?67.4 kB? (?)
    apk (aggressive)?95.1 kB? (?)
    apk (release)?700 kB? (?)
  • firebase-components

    TypeBase (7192ac7)Merge (815b358)Diff
    aar?44.9 kB? (?)
    apk (aggressive)?8.68 kB? (?)
    apk (release)?33.6 kB? (?)
  • firebase-installations

    TypeBase (7192ac7)Merge (815b358)Diff
    aar?55.0 kB? (?)
    apk (aggressive)?96.6 kB? (?)
    apk (release)?724 kB? (?)
  • firebase-installations-interop

    TypeBase (7192ac7)Merge (815b358)Diff
    aar?8.05 kB? (?)
    apk (aggressive)?65.0 kB? (?)
    apk (release)?651 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/4mwjsc3lXm.html

@lfkellogg lfkellogg merged commit 05eb4ac into fad/next Dec 14, 2022
@lfkellogg lfkellogg deleted the lk/remove-dependencies branch December 14, 2022 15:32
@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (815b358) and the base commit (7192ac7) are not available.

No macrobenchmark data found for the base commit (7192ac7). Analysis for the CI merge commit (815b358) can be found at:

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/GxAUfn62cF/index.html

@firebase firebase locked and limited conversation to collaborators Jan 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants