Skip to content

clean up logging #4465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 19, 2022
Merged

clean up logging #4465

merged 2 commits into from
Dec 19, 2022

Conversation

kaibolay
Copy link
Contributor

  • make LogWrapper static
  • ensure TAG is passed uniformly

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 19, 2022

Coverage Report 1

Affected Products

No changes between base commit (6323c25) and merge commit (693649c).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/5NZMlQPeg6.html

@github-actions
Copy link
Contributor

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit e53480b.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 19, 2022

Size Report 1

Affected Products

  • base

    TypeBase (6323c25)Merge (693649c)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)
  • firebase-annotations

    TypeBase (6323c25)Merge (693649c)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?9.46 kB? (?)
  • firebase-appdistribution

    TypeBase (6323c25)Merge (693649c)Diff
    aar?146 kB? (?)
    apk (aggressive)?831 kB? (?)
    apk (release)?2.01 MB? (?)
  • firebase-appdistribution-api

    TypeBase (6323c25)Merge (693649c)Diff
    aar?16.0 kB? (?)
    apk (aggressive)?95.8 kB? (?)
    apk (release)?708 kB? (?)
  • firebase-common

    TypeBase (6323c25)Merge (693649c)Diff
    aar?67.4 kB? (?)
    apk (aggressive)?95.1 kB? (?)
    apk (release)?700 kB? (?)
  • firebase-components

    TypeBase (6323c25)Merge (693649c)Diff
    aar?44.9 kB? (?)
    apk (aggressive)?8.68 kB? (?)
    apk (release)?33.6 kB? (?)
  • firebase-installations

    TypeBase (6323c25)Merge (693649c)Diff
    aar?55.0 kB? (?)
    apk (aggressive)?96.6 kB? (?)
    apk (release)?724 kB? (?)
  • firebase-installations-interop

    TypeBase (6323c25)Merge (693649c)Diff
    aar?8.05 kB? (?)
    apk (aggressive)?65.0 kB? (?)
    apk (release)?651 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ogHqGWe0wp.html

Copy link
Contributor

@lfkellogg lfkellogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!! I've been wanting to clean this up for ages.

@kaibolay kaibolay merged commit 12be9d7 into fad/in-app-feedback Dec 19, 2022
@kaibolay kaibolay deleted the kb/log-cleanup branch December 19, 2022 19:02
@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (693649c) and the base commit (6323c25) are not available.

No macrobenchmark data found for the base commit (6323c25). Analysis for the CI merge commit (693649c) can be found at:

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/z8J9CskmNI/index.html

lfkellogg pushed a commit that referenced this pull request Dec 20, 2022
- make `LogWrapper` static
- ensure `TAG` is passed uniformly
lfkellogg pushed a commit that referenced this pull request Jan 5, 2023
- make `LogWrapper` static
- ensure `TAG` is passed uniformly
@firebase firebase locked and limited conversation to collaborators Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants