Do not wait to store state when signing out #4490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Coverage Report 1Affected Products
Test Logs |
Size Report 1Affected Products
Test Logs |
lfkellogg
force-pushed
the
lk/clean-up-impl
branch
from
9716d09 to
9afb4ba
Compare
kaibolay
reviewed
Dec 22, 2022
| Task<AppDistributionReleaseInternal> setCachedNewReleaseTask = | ||
| firebaseAppDistribution.getCachedNewRelease().set(TEST_RELEASE_NEWER_AAB_INTERNAL); | ||
|
|
||
| // Confirm that the cached new release is initially set |
There was a problem hiding this comment.
I'm not a big fan of this pattern - I think, in general, we should trust (but not verify) test setup.
In this case I think you should be able to drop this comment, the blank line above it, and the assert on line 528
There was a problem hiding this comment.
Sounds good. Removed.
|
|
||
| // Sign out the tester | ||
| firebaseAppDistribution.signOutTester(); | ||
| awaitAsyncOperations(lightweightExecutor); |
There was a problem hiding this comment.
If I understand this change correctly, this should no be needed
There was a problem hiding this comment.
Ah you're right, great catch!
lfkellogg
force-pushed
the
lk/clean-up-impl
branch
from
0b75061 to
ef1897a
Compare
kaibolay
approved these changes
Dec 22, 2022
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Startup time comparison between the CI merge commit (0b182c7) and the base commit (1a0858d) are not available. No macrobenchmark data found for the base commit (1a0858d). Analysis for the CI merge commit (0b182c7) can be found at: |
lfkellogg
added a commit
that referenced
this pull request
Jan 5, 2023
* Do not wait to store state when signing out * Remove unnecessary assertions during test setup
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neither task, either to set the cached release to null or to set the signed it status to false, can ever fail. And the order does not matter. So just kick them off so they can occur as quickly as possible. It's especially important for these changes to occur ASAP since
signOutTester()returns immediately, and ideally we want the state to reflect that call immediately so the developer sees consistent behavior from the API.Also adds a new test.