Clean up sign in state management #4491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Coverage Report 1Affected Products
Test Logs |
lfkellogg
force-pushed
the
lk/cleanup-signinmanager
branch
from
dc74f3b to
f1e46fe
Compare
lfkellogg
changed the title
lfkellogg
force-pushed
the
lk/cleanup-signinmanager
branch
from
f1e46fe to
43ec7a0
Compare
kaibolay
approved these changes
Dec 22, 2022
|
|
||
| private <T> Task<T> applyToSharedPreferences(SharedPreferencesFunction<T> func) { | ||
| // Check nullness of sharedPreferences directly even though multiple threads could be calling | ||
| // this function at once. This isn't a problem because: 1) once it is set it will never be set, |
There was a problem hiding this comment.
nit: is this overlong line something :googleJavaFormat would fix?
extra-nit: "set back to null" -> "reset back to null"?
There was a problem hiding this comment.
Huh, it doesn't appear overlong to me (100 characters). :googleJavaFormat thinks its fine too.
I like "reset back to null", changed.
| // Simulate re-entering app after successful sign in, via SignInResultActivity | ||
| testerSignInManager.onActivityCreated(mockSignInResultActivity); | ||
|
|
||
| awaitTaskFailure(signInTask, UNKNOWN, "Error storing tester sign in state", expectedException); |
There was a problem hiding this comment.
:googleJavaFormat says this is fine too. Looks like 100 chars is the max.
Size Report 1Affected Products
Test Logs |
lfkellogg
force-pushed
the
lk/cleanup-signinmanager
branch
from
ff3ee8c to
da17514
Compare
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Startup time comparison between the CI merge commit (b6afdae) and the base commit (973f40e) are not available. No macrobenchmark data found for the base commit (973f40e). Analysis for the CI merge commit (b6afdae) can be found at: |
lfkellogg
added a commit
that referenced
this pull request
Jan 5, 2023
* Simplify sign in state management * Reword comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.