Make isTesterSignedIn more reliable #4493
Merged
+74
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Coverage Report 1Affected Products
Test Logs |
Size Report 1Affected Products
Test Logs |
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Startup time comparison between the CI merge commit (649e8f3) and the base commit (c785db4) are not available. No macrobenchmark data found for the base commit (c785db4). Analysis for the CI merge commit (649e8f3) can be found at: |
kaibolay
approved these changes
Dec 22, 2022
| @@ -54,12 +57,14 @@ Task<Boolean> getSignInStatus() { | |||
| } | |||
|
|
|||
| boolean getSignInStatusBlocking() { | |||
There was a problem hiding this comment.
Should this method be renamed?
There was a problem hiding this comment.
No I don't think so. It still returns the sign in status, and it is still potentially blocking.
I changed getSharedPreferencesBlocking() to getAndCacheSharedPreferences() because if I included Blocking it would be super long and I didn't think it was necessary for the private method name to communicate that it blocks.
lfkellogg
added a commit
that referenced
this pull request
Jan 5, 2023
kaibolay
pushed a commit
that referenced
this pull request
Jan 23, 2023
lfkellogg
added a commit
that referenced
this pull request
Jan 25, 2023
lfkellogg
added a commit
that referenced
this pull request
Jan 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an edge case where, if the first thing you did when opening the app was to call
signOutTester, callingisTesterSignedInimmediately afterwords would returntrue. This makes a few tweaks which should prevent this from happening in any reasonable scenario:signOutTester()is calledgetSignInStatusBlocking()is calledAlso adds some more tests to cover the failure mode, and some general test cleanup.