Skip to content

Remove synchronized blocks from NewReleaseFetcher #4510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 4, 2023
Merged

Remove synchronized blocks from NewReleaseFetcher #4510

merged 3 commits into from
Jan 4, 2023

Conversation

lfkellogg
Copy link
Contributor

No description provided.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 3, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from ? (de9ef17) to 77.39% (f2126be) by ?.

    44 individual files with coverage change

    FilenameBase (de9ef17)Merge (f2126be)Diff
    AabUpdater.java?98.67%?
    ApkInstaller.java?100.00%?
    ApkUpdater.java?93.07%?
    AppDistributionReleaseImpl.java?100.00%?
    AppDistributionReleaseInternal.java?100.00%?
    AppIconSource.java?84.62%?
    AutoValue_AppDistributionReleaseImpl.java?65.45%?
    AutoValue_AppDistributionReleaseInternal.java?71.58%?
    AutoValue_ImageUtils_ImageSize.java?35.00%?
    AutoValue_TesterApiDisabledErrorDetails.java?29.41%?
    AutoValue_TesterApiDisabledErrorDetails_HelpLink.java?54.17%?
    AutoValue_UpdateProgressImpl.java?65.96%?
    ErrorMessages.java?0.00%?
    FeedbackActivity.java?1.12%?
    FeedbackSender.java?84.62%?
    FirebaseAppDistributionExceptions.java?80.00%?
    FirebaseAppDistributionFileProvider.java?0.00%?
    FirebaseAppDistributionImpl.java?89.89%?
    FirebaseAppDistributionLifecycleNotifier.java?92.91%?
    FirebaseAppDistributionNotificationsManager.java?87.18%?
    FirebaseAppDistributionRegistrar.java?86.27%?
    FirebaseAppDistributionTesterApiClient.java?88.54%?
    HttpsUrlConnectionFactory.java?50.00%?
    ImageUtils.java?100.00%?
    InstallActivity.java?2.67%?
    LogWrapper.java?100.00%?
    NewReleaseFetcher.java?85.11%?
    PackageInfoUtils.java?42.86%?
    ReleaseIdentifier.java?85.54%?
    ReleaseUtils.java?83.33%?
    ScreenshotTaker.java?41.18%?
    SequentialReference.java?100.00%?
    SignInResultActivity.java?0.00%?
    SignInStorage.java?100.00%?
    TakeScreenshotAndStartFeedbackActivity.java?0.00%?
    TaskCache.java?100.00%?
    TaskCompletionSourceCache.java?73.91%?
    TaskUtils.java?92.50%?
    TesterApiDisabledErrorDetails.java?93.75%?
    TesterApiHttpClient.java?90.18%?
    TesterSignInManager.java?96.12%?
    UpdateProgressImpl.java?100.00%?
    UpdateTaskCache.java?100.00%?
    UpdateTaskImpl.java?76.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/aFh4Nq9HGG.html

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023 •
edited
Loading

Unit Test Results

166 tests  ±0   166 ✔️ ±0   54s ⏱️ +7s
  16 suites ±0       0 💤 ±0 
  16 files   ±0       0 ❌ ±0 

Results for commit 5ac42cf. ± Comparison against base commit de9ef17.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 3, 2023 •
edited
Loading

Size Report 1

Affected Products

  • base

    TypeBase (de9ef17)Merge (f2126be)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)

  • firebase-annotations

    TypeBase (de9ef17)Merge (f2126be)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?9.46 kB? (?)

  • firebase-appdistribution

    TypeBase (de9ef17)Merge (f2126be)Diff
    aar?156 kB? (?)
    apk (aggressive)?833 kB? (?)
    apk (release)?2.01 MB? (?)

  • firebase-appdistribution-api

    TypeBase (de9ef17)Merge (f2126be)Diff
    aar?16.0 kB? (?)
    apk (aggressive)?95.8 kB? (?)
    apk (release)?706 kB? (?)

  • firebase-common

    TypeBase (de9ef17)Merge (f2126be)Diff
    aar?67.4 kB? (?)
    apk (aggressive)?95.1 kB? (?)
    apk (release)?700 kB? (?)

  • firebase-components

    TypeBase (de9ef17)Merge (f2126be)Diff
    aar?44.9 kB? (?)
    apk (aggressive)?8.68 kB? (?)
    apk (release)?33.6 kB? (?)

  • firebase-installations

    TypeBase (de9ef17)Merge (f2126be)Diff
    aar?55.0 kB? (?)
    apk (aggressive)?96.6 kB? (?)
    apk (release)?724 kB? (?)

  • firebase-installations-interop

    TypeBase (de9ef17)Merge (f2126be)Diff
    aar?8.05 kB? (?)
    apk (aggressive)?65.0 kB? (?)
    apk (release)?651 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/kqaLETrr3v.html

@lfkellogg lfkellogg force-pushed the lk/remove-more-syncs branch 2 times, most recently from 733e36f to 54ea9cf Compare January 3, 2023 23:53
@lfkellogg lfkellogg changed the title Remove more synchronized blocks Remove synchronized blocks from NewReleaseFetcher Jan 3, 2023
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 4, 2023 •
edited
Loading

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (f2126be) and the base commit (de9ef17) are not available.

No macrobenchmark data found for the base commit (de9ef17). Analysis for the CI merge commit (f2126be) can be found at:

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/DMZIATSqin/index.html

@lfkellogg lfkellogg force-pushed the lk/remove-more-syncs branch from 54ea9cf to 72e1fc0 Compare January 4, 2023 14:21
@lfkellogg lfkellogg force-pushed the lk/remove-more-syncs branch 3 times, most recently from 259819a to db72cbe Compare January 4, 2023 15:00
@lfkellogg lfkellogg force-pushed the lk/remove-more-syncs branch from db72cbe to de1d066 Compare January 4, 2023 15:25
@lfkellogg lfkellogg force-pushed the lk/remove-more-syncs branch from de1d066 to b3ae775 Compare January 4, 2023 15:37
@lfkellogg lfkellogg requested a review from kaibolay January 4, 2023 16:13
@lfkellogg lfkellogg force-pushed the lk/remove-more-syncs branch from b3ae775 to 5ac42cf Compare January 4, 2023 16:42
Base automatically changed from lk/cleanup-caches to fad/in-app-feedback January 4, 2023 17:25
@lfkellogg lfkellogg merged commit 8c83cfc into fad/in-app-feedback Jan 4, 2023
@lfkellogg lfkellogg deleted the lk/remove-more-syncs branch January 4, 2023 17:26
lfkellogg added a commit that referenced this pull request Jan 5, 2023
@lfkellogg
Remove synchronized blocks from NewReleaseFetcher (#4510)
9972743 
* Remove synchronized usage in TaskCache

* Re-arrange member declarations and make more consistent

* Remove synchronized blocks from NewReleaseFetcher
kaibolay pushed a commit that referenced this pull request Jan 23, 2023
@lfkellogg @kaibolay
Remove synchronized blocks from NewReleaseFetcher (#4510)
debbc7f 
* Remove synchronized usage in TaskCache

* Re-arrange member declarations and make more consistent

* Remove synchronized blocks from NewReleaseFetcher
lfkellogg added a commit that referenced this pull request Jan 25, 2023
@lfkellogg
Remove synchronized blocks from NewReleaseFetcher (#4510)
89db0d5 
* Remove synchronized usage in TaskCache

* Re-arrange member declarations and make more consistent

* Remove synchronized blocks from NewReleaseFetcher
lfkellogg added a commit that referenced this pull request Jan 25, 2023
@lfkellogg
Remove synchronized blocks from NewReleaseFetcher (#4510)
ac33d4a 
* Remove synchronized usage in TaskCache

* Re-arrange member declarations and make more consistent

* Remove synchronized blocks from NewReleaseFetcher
@firebase firebase locked and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kaibolay kaibolay kaibolay approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lfkellogg @google-oss-bot @kaibolay