Some improvements to the task caches

[lfkellogg]

• The Task<Void> returned by the setValue(), setException(), etc. methods were not actually being resolved. They weren't being used yet but will be in a followup change.
• Adds TaskCompletionSourceCache.isOngoing() which will support a followup change
• Fleshes out the javadocs

[google-oss-bot]

	1 Warning
⚠️	Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

[google-oss-bot]

Coverage Report ¹

Affected Products

• firebase-appdistribution

  Overall coverage changed from ? (0df8309) to 77.14% (3bf4b58) by ?.

  44 individual files with coverage change

  Filename	Base (0df8309)	Merge (3bf4b58)	Diff
  AabUpdater.java	?	98.67%	?
  ApkInstaller.java	?	100.00%	?
  ApkUpdater.java	?	93.07%	?
  AppDistributionReleaseImpl.java	?	100.00%	?
  AppDistributionReleaseInternal.java	?	100.00%	?
  AppIconSource.java	?	84.62%	?
  AutoValue_AppDistributionReleaseImpl.java	?	65.45%	?
  AutoValue_AppDistributionReleaseInternal.java	?	71.58%	?
  AutoValue_ImageUtils_ImageSize.java	?	35.00%	?
  AutoValue_TesterApiDisabledErrorDetails.java	?	29.41%	?
  AutoValue_TesterApiDisabledErrorDetails_HelpLink.java	?	54.17%	?
  AutoValue_UpdateProgressImpl.java	?	65.96%	?
  ErrorMessages.java	?	0.00%	?
  FeedbackActivity.java	?	1.12%	?
  FeedbackSender.java	?	84.62%	?
  FirebaseAppDistributionExceptions.java	?	80.00%	?
  FirebaseAppDistributionFileProvider.java	?	0.00%	?
  FirebaseAppDistributionImpl.java	?	89.89%	?
  FirebaseAppDistributionLifecycleNotifier.java	?	92.91%	?
  FirebaseAppDistributionNotificationsManager.java	?	87.18%	?
  FirebaseAppDistributionRegistrar.java	?	86.27%	?
  FirebaseAppDistributionTesterApiClient.java	?	88.54%	?
  HttpsUrlConnectionFactory.java	?	50.00%	?
  ImageUtils.java	?	100.00%	?
  InstallActivity.java	?	2.67%	?
  LogWrapper.java	?	100.00%	?
  NewReleaseFetcher.java	?	85.11%	?
  PackageInfoUtils.java	?	42.86%	?
  ReleaseIdentifier.java	?	85.54%	?
  ReleaseUtils.java	?	83.33%	?
  ScreenshotTaker.java	?	41.18%	?
  SequentialReference.java	?	100.00%	?
  SignInResultActivity.java	?	0.00%	?
  SignInStorage.java	?	100.00%	?
  TakeScreenshotAndStartFeedbackActivity.java	?	0.00%	?
  TaskCache.java	?	100.00%	?
  TaskCompletionSourceCache.java	?	68.97%	?
  TaskUtils.java	?	92.50%	?
  TesterApiDisabledErrorDetails.java	?	93.75%	?
  TesterApiHttpClient.java	?	90.18%	?
  TesterSignInManager.java	?	96.12%	?
  UpdateProgressImpl.java	?	100.00%	?
  UpdateTaskCache.java	?	91.30%	?
  UpdateTaskImpl.java	?	76.00%	?

Test Logs

• Merge (3bf4b58): https://github.com/firebase/firebase-android-sdk/actions/runs/3841751800

1. https://storage.googleapis.com/firebase-sdk-metric-reports/GUtRGgxf90.html

[github-actions]

Unit Test Results

166 tests   166 ✔️  42s ⏱️
  16 suites      0 💤
  16 files        0 ❌

Results for commit a6f79fd.

[google-oss-bot]

Size Report ¹

Affected Products

• base

  Type	Base (0df8309)	Merge (3bf4b58)	Diff
  apk (aggressive)	?	8.39 kB	? (?)
  apk (release)	?	8.65 kB	? (?)

• firebase-annotations

  Type	Base (0df8309)	Merge (3bf4b58)	Diff
  apk (aggressive)	?	8.39 kB	? (?)
  apk (release)	?	9.46 kB	? (?)

• firebase-appdistribution

  Type	Base (0df8309)	Merge (3bf4b58)	Diff
  aar	?	157 kB	? (?)
  apk (aggressive)	?	833 kB	? (?)
  apk (release)	?	2.01 MB	? (?)

• firebase-appdistribution-api

  Type	Base (0df8309)	Merge (3bf4b58)	Diff
  aar	?	16.0 kB	? (?)
  apk (aggressive)	?	95.8 kB	? (?)
  apk (release)	?	706 kB	? (?)

• firebase-common

  Type	Base (0df8309)	Merge (3bf4b58)	Diff
  aar	?	67.4 kB	? (?)
  apk (aggressive)	?	95.1 kB	? (?)
  apk (release)	?	700 kB	? (?)

• firebase-components

  Type	Base (0df8309)	Merge (3bf4b58)	Diff
  aar	?	44.9 kB	? (?)
  apk (aggressive)	?	8.68 kB	? (?)
  apk (release)	?	33.6 kB	? (?)

• firebase-installations

  Type	Base (0df8309)	Merge (3bf4b58)	Diff
  aar	?	55.0 kB	? (?)
  apk (aggressive)	?	96.6 kB	? (?)
  apk (release)	?	724 kB	? (?)

• firebase-installations-interop

  Type	Base (0df8309)	Merge (3bf4b58)	Diff
  aar	?	8.05 kB	? (?)
  apk (aggressive)	?	65.0 kB	? (?)
  apk (release)	?	651 kB	? (?)

Test Logs

• Merge (3bf4b58): https://github.com/firebase/firebase-android-sdk/actions/runs/3841751800

1. https://storage.googleapis.com/firebase-sdk-metric-reports/QpRutSpeRH.html

[google-oss-bot]

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (3bf4b58) and the base commit (0df8309) are not available.

No macrobenchmark data found for the base commit (0df8309). Analysis for the CI merge commit (3bf4b58) can be found at:

• https://storage.googleapis.com/firebase-sdk-metric-reports/cLBPtDRXgc/index.html

1. https://storage.googleapis.com/firebase-sdk-metric-reports/NLU4wJFV8a/index.html