Remove synchronized blocks from TesterSignInManager #4520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Coverage Report 1Affected Products
Test Logs |
kaibolay
approved these changes
Jan 4, 2023
| } | ||
| ErrorMessages.AUTHENTICATION_CANCELED, AUTHENTICATION_CANCELED)) | ||
| .addOnSuccessListener( | ||
| unused -> LogWrapper.e(TAG, "App Resumed without sign in flow completing.")); |
There was a problem hiding this comment.
nit: "resumed" should be lower case.
Size Report 1Affected Products
Test Logs |
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Startup time comparison between the CI merge commit (aa01253) and the base commit (e61f367) are not available. No macrobenchmark data found for the base commit (e61f367). Analysis for the CI merge commit (aa01253) can be found at: |
lfkellogg
force-pushed
the
lk/no-sync-signin
branch
from
9aacf59 to
c527645
Compare
lfkellogg
added a commit
that referenced
this pull request
Jan 5, 2023
* Some improvements to the task caches * Remove synchronized blocks from TesterSignInManager
kaibolay
pushed a commit
that referenced
this pull request
Jan 23, 2023
* Some improvements to the task caches * Remove synchronized blocks from TesterSignInManager
lfkellogg
added a commit
that referenced
this pull request
Jan 25, 2023
* Some improvements to the task caches * Remove synchronized blocks from TesterSignInManager
lfkellogg
added a commit
that referenced
this pull request
Jan 25, 2023
* Some improvements to the task caches * Remove synchronized blocks from TesterSignInManager
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also moves to
@LightweightExecutornow that there are no more blocking operations.