Skip to content

Resolve javadoc diff failures #4530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2023
Merged

Conversation

emilypgoogle
Copy link
Collaborator

This PR resolves two issues relating to the javadoc diff action failing. Both scenarios involved no diff existing as far as I can tell, but it's much cleaner to succeed and no-op. Part one is just making empty build folders to move over if the changed SDKs don't output anything to build when generating javadoc (I didn't realize this was possible originally). The second change however involves letting the final step of posting the comment fail without issue. As of yet I've only seen this fail when provided with an empty file, however this might also mean we miss a breakage (though, the comment consistently disappearing is probably also a reasonable tip off). My original approach involved checking the length of the comment and skipping the step if it was too small, but it seemed hacky and prone to breakage, so I went with this solution instead.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

Javadoc Changes:
--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/firestore/CollectionReference.html	2023-01-05 23:09:11.733060654 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/firestore/CollectionReference.html	2023-01-05 23:03:56.797220842 +0000
@@ -205,7 +205,7 @@
                     <tr>
                       <td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a>&lt;<a href="/docs/reference/android/com/google/firebase/firestore/QuerySnapshot.html">QuerySnapshot</a>&gt;</code></td>
                       <td>
-                        <div><code><a href="/docs/reference/android/com/google/firebase/firestore/Query.html#get(com.google.firebase.firestore.Source)">get</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/firestore/Source.html">Source</a>&nbsp;source)</code></div>
+                        <div><code><a href="/docs/reference/android/com/google/firebase/firestore/Query.html#get(com.google.firebase.firestore.Source)">get</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a>&nbsp;source)</code></div>
                         <p>Executes the query and returns the results as a <code>QuerySnapshot</code>.</p>
                       </td>
                     </tr>
--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/firestore/DocumentReference.html	2023-01-05 23:09:11.737060652 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/firestore/DocumentReference.html	2023-01-05 23:03:56.797220842 +0000
@@ -109,7 +109,7 @@
           <tr>
             <td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a>&lt;<a href="/docs/reference/android/com/google/firebase/firestore/DocumentSnapshot.html">DocumentSnapshot</a>&gt;</code></td>
             <td>
-              <div><code><a href="/docs/reference/android/com/google/firebase/firestore/DocumentReference.html#get(com.google.firebase.firestore.Source)">get</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/firestore/Source.html">Source</a>&nbsp;source)</code></div>
+              <div><code><a href="/docs/reference/android/com/google/firebase/firestore/DocumentReference.html#get(com.google.firebase.firestore.Source)">get</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a>&nbsp;source)</code></div>
               <p>Reads the document referenced by this <code>DocumentReference</code>.</p>
             </td>
           </tr>
@@ -561,7 +561,7 @@
     </div>
     <div><a name="get-com.google.firebase.firestore.Source-"></a><a name="get"></a>
       <h3 class="api-name" id="get(com.google.firebase.firestore.Source)">get</h3>
-      <pre class="api-signature no-pretty-print">public&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a>&lt;<a href="/docs/reference/android/com/google/firebase/firestore/DocumentSnapshot.html">DocumentSnapshot</a>&gt;&nbsp;<a href="/docs/reference/android/com/google/firebase/firestore/DocumentReference.html#get(com.google.firebase.firestore.Source)">get</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/firestore/Source.html">Source</a>&nbsp;source)</pre>
+      <pre class="api-signature no-pretty-print">public&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a>&lt;<a href="/docs/reference/android/com/google/firebase/firestore/DocumentSnapshot.html">DocumentSnapshot</a>&gt;&nbsp;<a href="/docs/reference/android/com/google/firebase/firestore/DocumentReference.html#get(com.google.firebase.firestore.Source)">get</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a>&nbsp;source)</pre>
       <p>Reads the document referenced by this <code>DocumentReference</code>. </p>
       <p>By default, <code>get()</code> attempts to provide up-to-date data when possible by waiting for data from the server, but it may return cached data or fail if you are offline and the server cannot be reached. This behavior can be altered via the <code>Source</code> parameter.</p>
       <div class="devsite-table-wrapper">
@@ -573,7 +573,7 @@
           </thead>
           <tbody class="list">
             <tr>
-              <td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/firestore/Source.html">Source</a>&nbsp;source</code></td>
+              <td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a>&nbsp;source</code></td>
               <td>
                 <p>A value to configure the get behavior.</p>
               </td>
--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/firestore/LoadBundleTaskProgress.html	2023-01-05 23:09:11.733060654 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/firestore/LoadBundleTaskProgress.html	2023-01-05 23:03:56.797220842 +0000
@@ -81,7 +81,7 @@
             </td>
           </tr>
           <tr>
-            <td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a></code></td>
+            <td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/firestore/LoadBundleTaskProgress.TaskState.html">LoadBundleTaskProgress.TaskState</a></code></td>
             <td>
               <div><code><a href="/docs/reference/android/com/google/firebase/firestore/LoadBundleTaskProgress.html#getTaskState()">getTaskState</a>()</code></div>
               <p>Returns the current state of the <code><a href="/docs/reference/android/com/google/firebase/firestore/LoadBundleTask.html">LoadBundleTask</a></code>.</p>
@@ -137,7 +137,7 @@
     </div>
     <div><a name="getTaskState--"></a><a name="gettaskstate"></a>
       <h3 class="api-name" id="getTaskState()">getTaskState</h3>
-      <pre class="api-signature no-pretty-print">public&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/firestore/LoadBundleTaskProgress.html#getTaskState()">getTaskState</a>()</pre>
+      <pre class="api-signature no-pretty-print">public&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/firestore/LoadBundleTaskProgress.TaskState.html">LoadBundleTaskProgress.TaskState</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/firestore/LoadBundleTaskProgress.html#getTaskState()">getTaskState</a>()</pre>
       <p>Returns the current state of the <code><a href="/docs/reference/android/com/google/firebase/firestore/LoadBundleTask.html">LoadBundleTask</a></code>.</p>
     </div>
     <div><a name="getTotalBytes--"></a><a name="gettotalbytes"></a>
--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/firestore/Query.html	2023-01-05 23:09:11.733060654 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/firestore/Query.html	2023-01-05 23:03:56.797220842 +0000
@@ -165,7 +165,7 @@
           <tr>
             <td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a>&lt;<a href="/docs/reference/android/com/google/firebase/firestore/QuerySnapshot.html">QuerySnapshot</a>&gt;</code></td>
             <td>
-              <div><code><a href="/docs/reference/android/com/google/firebase/firestore/Query.html#get(com.google.firebase.firestore.Source)">get</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/firestore/Source.html">Source</a>&nbsp;source)</code></div>
+              <div><code><a href="/docs/reference/android/com/google/firebase/firestore/Query.html#get(com.google.firebase.firestore.Source)">get</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a>&nbsp;source)</code></div>
               <p>Executes the query and returns the results as a <code>QuerySnapshot</code>.</p>
             </td>
           </tr>
@@ -890,7 +890,7 @@
     </div>
     <div><a name="get-com.google.firebase.firestore.Source-"></a><a name="get"></a>
       <h3 class="api-name" id="get(com.google.firebase.firestore.Source)">get</h3>
-      <pre class="api-signature no-pretty-print">public&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a>&lt;<a href="/docs/reference/android/com/google/firebase/firestore/QuerySnapshot.html">QuerySnapshot</a>&gt;&nbsp;<a href="/docs/reference/android/com/google/firebase/firestore/Query.html#get(com.google.firebase.firestore.Source)">get</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/firestore/Source.html">Source</a>&nbsp;source)</pre>
+      <pre class="api-signature no-pretty-print">public&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a>&lt;<a href="/docs/reference/android/com/google/firebase/firestore/QuerySnapshot.html">QuerySnapshot</a>&gt;&nbsp;<a href="/docs/reference/android/com/google/firebase/firestore/Query.html#get(com.google.firebase.firestore.Source)">get</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a>&nbsp;source)</pre>
       <p>Executes the query and returns the results as a <code>QuerySnapshot</code>. </p>
       <p>By default, <code>get()</code> attempts to provide up-to-date data when possible by waiting for data from the server, but it may return cached data or fail if you are offline and the server cannot be reached. This behavior can be altered via the <code>Source</code> parameter.</p>
       <div class="devsite-table-wrapper">
@@ -902,7 +902,7 @@
           </thead>
           <tbody class="list">
             <tr>
-              <td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/firestore/Source.html">Source</a>&nbsp;source</code></td>
+              <td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a>&nbsp;source</code></td>
               <td>
                 <p>A value to configure the get behavior.</p>
               </td>
--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/functions/FirebaseFunctionsException.html	2023-01-05 23:09:04.045064464 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/functions/FirebaseFunctionsException.html	2023-01-05 23:04:02.205218150 +0000
@@ -85,7 +85,7 @@
         </thead>
         <tbody class="list">
           <tr>
-            <td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/functions/FirebaseFunctionsException.Code.html">FirebaseFunctionsException.Code</a></code></td>
+            <td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a></code></td>
             <td>
               <div><code><a href="/docs/reference/android/com/google/firebase/functions/FirebaseFunctionsException.html#getCode()">getCode</a>()</code></div>
               <p>Gets the error code for the operation that failed.</p>
@@ -196,7 +196,7 @@
     <h2>Public methods</h2>
     <div><a name="getCode--"></a><a name="getcode"></a>
       <h3 class="api-name" id="getCode()">getCode</h3>
-      <pre class="api-signature no-pretty-print">public&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/functions/FirebaseFunctionsException.Code.html">FirebaseFunctionsException.Code</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/functions/FirebaseFunctionsException.html#getCode()">getCode</a>()</pre>
+      <pre class="api-signature no-pretty-print">public&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/functions/FirebaseFunctionsException.html#getCode()">getCode</a>()</pre>
       <p>Gets the error code for the operation that failed.</p>
       <div class="devsite-table-wrapper">
         <table class="responsive">
@@ -207,7 +207,7 @@
           </thead>
           <tbody class="list">
             <tr>
-              <td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/functions/FirebaseFunctionsException.Code.html">FirebaseFunctionsException.Code</a></code></td>
+              <td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a></code></td>
               <td>
                 <p>the code for the FirebaseFunctionsException</p>
               </td>
--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/firestore/CollectionReference.html	2023-01-05 23:09:11.769060636 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/firestore/CollectionReference.html	2023-01-05 23:03:56.841220820 +0000
@@ -205,7 +205,7 @@
                     <tr>
                       <td width="40%"><code><a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a>&lt;<a href="/docs/reference/kotlin/com/google/firebase/firestore/QuerySnapshot.html">QuerySnapshot</a>!&gt;</code></td>
                       <td>
-                        <div><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/Query.html#get(com.google.firebase.firestore.Source)">get</a>(source:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/Source.html">Source</a>)</code></div>
+                        <div><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/Query.html#get(com.google.firebase.firestore.Source)">get</a>(source:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>)</code></div>
                         <p>Executes the query and returns the results as a <code>QuerySnapshot</code>.</p>
                       </td>
                     </tr>
--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/firestore/DocumentReference.html	2023-01-05 23:09:11.773060634 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/firestore/DocumentReference.html	2023-01-05 23:03:56.841220820 +0000
@@ -109,7 +109,7 @@
           <tr>
             <td width="40%"><code><a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a>&lt;<a href="/docs/reference/kotlin/com/google/firebase/firestore/DocumentSnapshot.html">DocumentSnapshot</a>!&gt;</code></td>
             <td>
-              <div><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/DocumentReference.html#get(com.google.firebase.firestore.Source)">get</a>(source:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/Source.html">Source</a>)</code></div>
+              <div><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/DocumentReference.html#get(com.google.firebase.firestore.Source)">get</a>(source:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>)</code></div>
               <p>Reads the document referenced by this <code>DocumentReference</code>.</p>
             </td>
           </tr>
@@ -561,7 +561,7 @@
     </div>
     <div><a name="get-com.google.firebase.firestore.Source-"></a><a name="get"></a>
       <h3 class="api-name" id="get(com.google.firebase.firestore.Source)">get</h3>
-      <pre class="api-signature no-pretty-print">fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/DocumentReference.html#get(com.google.firebase.firestore.Source)">get</a>(source:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/Source.html">Source</a>):&nbsp;<a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a>&lt;<a href="/docs/reference/kotlin/com/google/firebase/firestore/DocumentSnapshot.html">DocumentSnapshot</a>!&gt;</pre>
+      <pre class="api-signature no-pretty-print">fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/DocumentReference.html#get(com.google.firebase.firestore.Source)">get</a>(source:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>):&nbsp;<a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a>&lt;<a href="/docs/reference/kotlin/com/google/firebase/firestore/DocumentSnapshot.html">DocumentSnapshot</a>!&gt;</pre>
       <p>Reads the document referenced by this <code>DocumentReference</code>. </p>
       <p>By default, <code>get()</code> attempts to provide up-to-date data when possible by waiting for data from the server, but it may return cached data or fail if you are offline and the server cannot be reached. This behavior can be altered via the <code>Source</code> parameter.</p>
       <div class="devsite-table-wrapper">
@@ -573,7 +573,7 @@
           </thead>
           <tbody class="list">
             <tr>
-              <td width="40%"><code>source:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/Source.html">Source</a></code></td>
+              <td width="40%"><code>source:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a></code></td>
               <td>
                 <p>A value to configure the get behavior.</p>
               </td>
--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/firestore/LoadBundleTaskProgress.html	2023-01-05 23:09:11.765060638 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/firestore/LoadBundleTaskProgress.html	2023-01-05 23:03:56.837220822 +0000
@@ -81,7 +81,7 @@
             </td>
           </tr>
           <tr>
-            <td width="40%"><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a></code></td>
+            <td width="40%"><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/LoadBundleTaskProgress.TaskState.html">LoadBundleTaskProgress.TaskState</a></code></td>
             <td>
               <div><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/LoadBundleTaskProgress.html#getTaskState()">getTaskState</a>()</code></div>
               <p>Returns the current state of the <code><a href="/docs/reference/kotlin/com/google/firebase/firestore/LoadBundleTask.html">LoadBundleTask</a></code>.</p>
@@ -137,7 +137,7 @@
     </div>
     <div><a name="getTaskState--"></a><a name="gettaskstate"></a>
       <h3 class="api-name" id="getTaskState()">getTaskState</h3>
-      <pre class="api-signature no-pretty-print">fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/LoadBundleTaskProgress.html#getTaskState()">getTaskState</a>():&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a></pre>
+      <pre class="api-signature no-pretty-print">fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/LoadBundleTaskProgress.html#getTaskState()">getTaskState</a>():&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/LoadBundleTaskProgress.TaskState.html">LoadBundleTaskProgress.TaskState</a></pre>
       <p>Returns the current state of the <code><a href="/docs/reference/kotlin/com/google/firebase/firestore/LoadBundleTask.html">LoadBundleTask</a></code>.</p>
     </div>
     <div><a name="getTotalBytes--"></a><a name="gettotalbytes"></a>
--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/firestore/Query.html	2023-01-05 23:09:11.765060638 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/firestore/Query.html	2023-01-05 23:03:56.837220822 +0000
@@ -165,7 +165,7 @@
           <tr>
             <td width="40%"><code><a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a>&lt;<a href="/docs/reference/kotlin/com/google/firebase/firestore/QuerySnapshot.html">QuerySnapshot</a>!&gt;</code></td>
             <td>
-              <div><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/Query.html#get(com.google.firebase.firestore.Source)">get</a>(source:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/Source.html">Source</a>)</code></div>
+              <div><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/Query.html#get(com.google.firebase.firestore.Source)">get</a>(source:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>)</code></div>
               <p>Executes the query and returns the results as a <code>QuerySnapshot</code>.</p>
             </td>
           </tr>
@@ -890,7 +890,7 @@
     </div>
     <div><a name="get-com.google.firebase.firestore.Source-"></a><a name="get"></a>
       <h3 class="api-name" id="get(com.google.firebase.firestore.Source)">get</h3>
-      <pre class="api-signature no-pretty-print">fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/Query.html#get(com.google.firebase.firestore.Source)">get</a>(source:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/Source.html">Source</a>):&nbsp;<a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a>&lt;<a href="/docs/reference/kotlin/com/google/firebase/firestore/QuerySnapshot.html">QuerySnapshot</a>!&gt;</pre>
+      <pre class="api-signature no-pretty-print">fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/Query.html#get(com.google.firebase.firestore.Source)">get</a>(source:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>):&nbsp;<a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a>&lt;<a href="/docs/reference/kotlin/com/google/firebase/firestore/QuerySnapshot.html">QuerySnapshot</a>!&gt;</pre>
       <p>Executes the query and returns the results as a <code>QuerySnapshot</code>. </p>
       <p>By default, <code>get()</code> attempts to provide up-to-date data when possible by waiting for data from the server, but it may return cached data or fail if you are offline and the server cannot be reached. This behavior can be altered via the <code>Source</code> parameter.</p>
       <div class="devsite-table-wrapper">
@@ -902,7 +902,7 @@
           </thead>
           <tbody class="list">
             <tr>
-              <td width="40%"><code>source:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/Source.html">Source</a></code></td>
+              <td width="40%"><code>source:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a></code></td>
               <td>
                 <p>A value to configure the get behavior.</p>
               </td>
--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/functions/FirebaseFunctionsException.html	2023-01-05 23:09:04.061064458 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/functions/FirebaseFunctionsException.html	2023-01-05 23:04:02.221218142 +0000
@@ -85,7 +85,7 @@
         </thead>
         <tbody class="list">
           <tr>
-            <td width="40%"><code><a href="/docs/reference/kotlin/com/google/firebase/functions/FirebaseFunctionsException.Code.html">FirebaseFunctionsException.Code</a></code></td>
+            <td width="40%"><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a></code></td>
             <td>
               <div><code><a href="/docs/reference/kotlin/com/google/firebase/functions/FirebaseFunctionsException.html#getCode()">getCode</a>()</code></div>
               <p>Gets the error code for the operation that failed.</p>
@@ -196,7 +196,7 @@
     <h2>Public functions</h2>
     <div><a name="getCode--"></a><a name="getcode"></a>
       <h3 class="api-name" id="getCode()">getCode</h3>
-      <pre class="api-signature no-pretty-print">fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/functions/FirebaseFunctionsException.html#getCode()">getCode</a>():&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/functions/FirebaseFunctionsException.Code.html">FirebaseFunctionsException.Code</a></pre>
+      <pre class="api-signature no-pretty-print">fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/functions/FirebaseFunctionsException.html#getCode()">getCode</a>():&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a></pre>
       <p>Gets the error code for the operation that failed.</p>
       <div class="devsite-table-wrapper">
         <table class="responsive">
@@ -207,7 +207,7 @@
           </thead>
           <tbody class="list">
             <tr>
-              <td width="40%"><code><a href="/docs/reference/kotlin/com/google/firebase/functions/FirebaseFunctionsException.Code.html">FirebaseFunctionsException.Code</a></code></td>
+              <td width="40%"><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a></code></td>
               <td>
                 <p>the code for the FirebaseFunctionsException</p>
               </td>

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

Unit Test Results

   402 files  ±0     402 suites  ±0   19m 45s ⏱️ - 54m 36s
4 760 tests ±0  4 738 ✔️ +11  22 💤 ±0  0  - 11 
4 776 runs  ±0  4 754 ✔️ +11  22 💤 ±0  0  - 11 

Results for commit ad1ca50. ± Comparison against base commit ef311dc.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 5, 2023

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 5, 2023

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.15% (160c09a) to 50.07% (cb9c182) by -0.09%.

    FilenameBase (160c09a)Merge (cb9c182)Diff
    ChildChangeAccumulator.java96.67%83.33%-13.33%
    WebsocketConnection.java35.03%32.77%-2.26%
  • firebase-firestore

    Overall coverage changed from 44.53% (160c09a) to 44.60% (cb9c182) by +0.06%.

    FilenameBase (160c09a)Merge (cb9c182)Diff
    AsyncQueue.java70.65%78.61%+7.96%
    DeleteMutation.java90.48%95.24%+4.76%
    SetMutation.java97.22%94.44%-2.78%
  • firebase-perf

    Overall coverage changed from ? (160c09a) to 71.15% (cb9c182) by ?.

    103 individual files with coverage change

    FilenameBase (160c09a)Merge (cb9c182)Diff
    AddTrace.java?0.00%?
    AndroidApplicationInfo.java?34.71%?
    AndroidApplicationInfoOrBuilder.java?0.00%?
    AndroidLogger.java?100.00%?
    AndroidMemoryReading.java?38.36%?
    AndroidMemoryReadingOrBuilder.java?0.00%?
    ApplicationInfo.java?45.00%?
    ApplicationInfoOrBuilder.java?0.00%?
    ApplicationProcessState.java?73.91%?
    AppStartTrace.java?77.27%?
    AppStateMonitor.java?86.71%?
    AppStateUpdateHandler.java?92.86%?
    Clock.java?100.00%?
    ConfigResolver.java?93.19%?
    ConfigurationConstants.java?97.86%?
    ConfigurationFlag.java?100.00%?
    ConsoleUrlGenerator.java?37.50%?
    Constants.java?95.65%?
    Counter.java?90.91%?
    CpuGaugeCollector.java?92.77%?
    CpuMetricReading.java?39.33%?
    CpuMetricReadingOrBuilder.java?0.00%?
    DaggerFirebasePerformanceComponent.java?100.00%?
    DeviceCacheManager.java?76.03%?
    FirebasePerfApplicationInfoValidator.java?92.86%?
    FirebasePerfEarly.java?76.92%?
    FirebasePerfGaugeMetricValidator.java?100.00%?
    FirebasePerfHttpClient.java?93.85%?
    FirebasePerfMetricProto.java?0.00%?
    FirebasePerfNetworkValidator.java?86.67%?
    FirebasePerfOkHttpClient.java?44.90%?
    FirebasePerformance.java?79.12%?
    FirebasePerformanceAttributable.java?0.00%?
    FirebasePerformanceComponent.java?0.00%?
    FirebasePerformanceInitializer.java?33.33%?
    FirebasePerformanceModule.java?100.00%?
    FirebasePerformanceModule_ProvidesConfigResolverFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesFirebaseAppFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesFirebaseInstallationsFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesRemoteConfigComponentFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesRemoteConfigManagerFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesSessionManagerFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesTransportFactoryProviderFactory.java?100.00%?
    FirebasePerformance_Factory.java?100.00%?
    FirebasePerfRegistrar.java?100.00%?
    FirebasePerfTraceValidator.java?85.87%?
    FirebasePerfUrlConnection.java?44.26%?
    FirstDrawDoneListener.java?85.71%?
    FlgTransport.java?83.33%?
    FragmentStateMonitor.java?94.87%?
    FrameMetricsCalculator.java?96.77%?
    FrameMetricsRecorder.java?76.32%?
    GaugeManager.java?98.40%?
    GaugeMetadata.java?26.17%?
    GaugeMetadataManager.java?77.78%?
    GaugeMetadataOrBuilder.java?0.00%?
    GaugeMetric.java?39.47%?
    GaugeMetricOrBuilder.java?0.00%?
    HttpMetric.java?92.65%?
    ImmutableBundle.java?100.00%?
    InstrHttpInputStream.java?92.86%?
    InstrHttpOutputStream.java?98.00%?
    InstrHttpsURLConnection.java?94.32%?
    InstrHttpURLConnection.java?93.42%?
    InstrumentApacheHttpResponseHandler.java?100.00%?
    InstrumentOkHttpEnqueueCallback.java?100.00%?
    InstrURLConnectionBase.java?94.86%?
    LogWrapper.java?23.08%?
    MemoryGaugeCollector.java?89.66%?
    NetworkConnectionInfo.java?0.00%?
    NetworkConnectionInfoOrBuilder.java?0.00%?
    NetworkRequestMetric.java?49.16%?
    NetworkRequestMetricBuilder.java?95.97%?
    NetworkRequestMetricBuilderUtil.java?75.00%?
    NetworkRequestMetricOrBuilder.java?0.00%?
    Optional.java?86.67%?
    PendingPerfEvent.java?100.00%?
    PerfMetric.java?33.67%?
    PerfMetricOrBuilder.java?0.00%?
    PerfMetricValidator.java?93.55%?
    PerfSession.java?93.22%?
    PerfSessionOrBuilder.java?0.00%?
    PreDrawListener.java?94.12%?
    Rate.java?100.00%?
    RateLimiter.java?90.77%?
    RemoteConfigManager.java?91.30%?
    ResourceType.java?0.00%?
    ScreenTraceUtil.java?94.12%?
    SessionAwareObject.java?0.00%?
    SessionManager.java?100.00%?
    SessionVerbosity.java?68.42%?
    StorageUnit.java?57.89%?
    Timer.java?90.63%?
    Trace.java?96.67%?
    TraceMetric.java?43.14%?
    TraceMetricBuilder.java?100.00%?
    TraceMetricOrBuilder.java?0.00%?
    TransportInfo.java?0.00%?
    TransportInfoOrBuilder.java?0.00%?
    TransportManager.java?94.88%?
    URLAllowlist.java?94.44%?
    URLWrapper.java?0.00%?
    Utils.java?78.57%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/chpZgrZZCK.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 6, 2023

Startup Time Report 1

The report is too large (117,069 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/1b7T5QUk4N/index.html

@emilypgoogle emilypgoogle requested a review from rlazo January 6, 2023 16:23
@emilypgoogle emilypgoogle merged commit fa8d364 into master Jan 9, 2023
@emilypgoogle emilypgoogle deleted the ep/diff-javadoc-failure-fix branch January 9, 2023 21:02
mrober pushed a commit that referenced this pull request Jan 30, 2023
* Resolve javadoc diff failures

* Add comments
@firebase firebase locked and limited conversation to collaborators Feb 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants