-
Notifications
You must be signed in to change notification settings - Fork 625
Resolve javadoc diff failures #4530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Javadoc Changes:--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/firestore/CollectionReference.html 2023-01-05 23:09:11.733060654 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/firestore/CollectionReference.html 2023-01-05 23:03:56.797220842 +0000
@@ -205,7 +205,7 @@
<tr>
<td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a><<a href="/docs/reference/android/com/google/firebase/firestore/QuerySnapshot.html">QuerySnapshot</a>></code></td>
<td>
- <div><code><a href="/docs/reference/android/com/google/firebase/firestore/Query.html#get(com.google.firebase.firestore.Source)">get</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/firestore/Source.html">Source</a> source)</code></div>
+ <div><code><a href="/docs/reference/android/com/google/firebase/firestore/Query.html#get(com.google.firebase.firestore.Source)">get</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a> source)</code></div>
<p>Executes the query and returns the results as a <code>QuerySnapshot</code>.</p>
</td>
</tr> --- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/firestore/DocumentReference.html 2023-01-05 23:09:11.737060652 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/firestore/DocumentReference.html 2023-01-05 23:03:56.797220842 +0000
@@ -109,7 +109,7 @@
<tr>
<td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a><<a href="/docs/reference/android/com/google/firebase/firestore/DocumentSnapshot.html">DocumentSnapshot</a>></code></td>
<td>
- <div><code><a href="/docs/reference/android/com/google/firebase/firestore/DocumentReference.html#get(com.google.firebase.firestore.Source)">get</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/firestore/Source.html">Source</a> source)</code></div>
+ <div><code><a href="/docs/reference/android/com/google/firebase/firestore/DocumentReference.html#get(com.google.firebase.firestore.Source)">get</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a> source)</code></div>
<p>Reads the document referenced by this <code>DocumentReference</code>.</p>
</td>
</tr>
@@ -561,7 +561,7 @@
</div>
<div><a name="get-com.google.firebase.firestore.Source-"></a><a name="get"></a>
<h3 class="api-name" id="get(com.google.firebase.firestore.Source)">get</h3>
- <pre class="api-signature no-pretty-print">public @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a><<a href="/docs/reference/android/com/google/firebase/firestore/DocumentSnapshot.html">DocumentSnapshot</a>> <a href="/docs/reference/android/com/google/firebase/firestore/DocumentReference.html#get(com.google.firebase.firestore.Source)">get</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/firestore/Source.html">Source</a> source)</pre>
+ <pre class="api-signature no-pretty-print">public @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a><<a href="/docs/reference/android/com/google/firebase/firestore/DocumentSnapshot.html">DocumentSnapshot</a>> <a href="/docs/reference/android/com/google/firebase/firestore/DocumentReference.html#get(com.google.firebase.firestore.Source)">get</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a> source)</pre>
<p>Reads the document referenced by this <code>DocumentReference</code>. </p>
<p>By default, <code>get()</code> attempts to provide up-to-date data when possible by waiting for data from the server, but it may return cached data or fail if you are offline and the server cannot be reached. This behavior can be altered via the <code>Source</code> parameter.</p>
<div class="devsite-table-wrapper">
@@ -573,7 +573,7 @@
</thead>
<tbody class="list">
<tr>
- <td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/firestore/Source.html">Source</a> source</code></td>
+ <td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a> source</code></td>
<td>
<p>A value to configure the get behavior.</p>
</td> --- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/firestore/LoadBundleTaskProgress.html 2023-01-05 23:09:11.733060654 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/firestore/LoadBundleTaskProgress.html 2023-01-05 23:03:56.797220842 +0000
@@ -81,7 +81,7 @@
</td>
</tr>
<tr>
- <td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a></code></td>
+ <td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/firestore/LoadBundleTaskProgress.TaskState.html">LoadBundleTaskProgress.TaskState</a></code></td>
<td>
<div><code><a href="/docs/reference/android/com/google/firebase/firestore/LoadBundleTaskProgress.html#getTaskState()">getTaskState</a>()</code></div>
<p>Returns the current state of the <code><a href="/docs/reference/android/com/google/firebase/firestore/LoadBundleTask.html">LoadBundleTask</a></code>.</p>
@@ -137,7 +137,7 @@
</div>
<div><a name="getTaskState--"></a><a name="gettaskstate"></a>
<h3 class="api-name" id="getTaskState()">getTaskState</h3>
- <pre class="api-signature no-pretty-print">public @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a> <a href="/docs/reference/android/com/google/firebase/firestore/LoadBundleTaskProgress.html#getTaskState()">getTaskState</a>()</pre>
+ <pre class="api-signature no-pretty-print">public @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/firestore/LoadBundleTaskProgress.TaskState.html">LoadBundleTaskProgress.TaskState</a> <a href="/docs/reference/android/com/google/firebase/firestore/LoadBundleTaskProgress.html#getTaskState()">getTaskState</a>()</pre>
<p>Returns the current state of the <code><a href="/docs/reference/android/com/google/firebase/firestore/LoadBundleTask.html">LoadBundleTask</a></code>.</p>
</div>
<div><a name="getTotalBytes--"></a><a name="gettotalbytes"></a> --- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/firestore/Query.html 2023-01-05 23:09:11.733060654 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/firestore/Query.html 2023-01-05 23:03:56.797220842 +0000
@@ -165,7 +165,7 @@
<tr>
<td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a><<a href="/docs/reference/android/com/google/firebase/firestore/QuerySnapshot.html">QuerySnapshot</a>></code></td>
<td>
- <div><code><a href="/docs/reference/android/com/google/firebase/firestore/Query.html#get(com.google.firebase.firestore.Source)">get</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/firestore/Source.html">Source</a> source)</code></div>
+ <div><code><a href="/docs/reference/android/com/google/firebase/firestore/Query.html#get(com.google.firebase.firestore.Source)">get</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a> source)</code></div>
<p>Executes the query and returns the results as a <code>QuerySnapshot</code>.</p>
</td>
</tr>
@@ -890,7 +890,7 @@
</div>
<div><a name="get-com.google.firebase.firestore.Source-"></a><a name="get"></a>
<h3 class="api-name" id="get(com.google.firebase.firestore.Source)">get</h3>
- <pre class="api-signature no-pretty-print">public @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a><<a href="/docs/reference/android/com/google/firebase/firestore/QuerySnapshot.html">QuerySnapshot</a>> <a href="/docs/reference/android/com/google/firebase/firestore/Query.html#get(com.google.firebase.firestore.Source)">get</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/firestore/Source.html">Source</a> source)</pre>
+ <pre class="api-signature no-pretty-print">public @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a><<a href="/docs/reference/android/com/google/firebase/firestore/QuerySnapshot.html">QuerySnapshot</a>> <a href="/docs/reference/android/com/google/firebase/firestore/Query.html#get(com.google.firebase.firestore.Source)">get</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a> source)</pre>
<p>Executes the query and returns the results as a <code>QuerySnapshot</code>. </p>
<p>By default, <code>get()</code> attempts to provide up-to-date data when possible by waiting for data from the server, but it may return cached data or fail if you are offline and the server cannot be reached. This behavior can be altered via the <code>Source</code> parameter.</p>
<div class="devsite-table-wrapper">
@@ -902,7 +902,7 @@
</thead>
<tbody class="list">
<tr>
- <td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/firestore/Source.html">Source</a> source</code></td>
+ <td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a> source</code></td>
<td>
<p>A value to configure the get behavior.</p>
</td> --- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/functions/FirebaseFunctionsException.html 2023-01-05 23:09:04.045064464 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/functions/FirebaseFunctionsException.html 2023-01-05 23:04:02.205218150 +0000
@@ -85,7 +85,7 @@
</thead>
<tbody class="list">
<tr>
- <td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/functions/FirebaseFunctionsException.Code.html">FirebaseFunctionsException.Code</a></code></td>
+ <td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a></code></td>
<td>
<div><code><a href="/docs/reference/android/com/google/firebase/functions/FirebaseFunctionsException.html#getCode()">getCode</a>()</code></div>
<p>Gets the error code for the operation that failed.</p>
@@ -196,7 +196,7 @@
<h2>Public methods</h2>
<div><a name="getCode--"></a><a name="getcode"></a>
<h3 class="api-name" id="getCode()">getCode</h3>
- <pre class="api-signature no-pretty-print">public @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/functions/FirebaseFunctionsException.Code.html">FirebaseFunctionsException.Code</a> <a href="/docs/reference/android/com/google/firebase/functions/FirebaseFunctionsException.html#getCode()">getCode</a>()</pre>
+ <pre class="api-signature no-pretty-print">public @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a> <a href="/docs/reference/android/com/google/firebase/functions/FirebaseFunctionsException.html#getCode()">getCode</a>()</pre>
<p>Gets the error code for the operation that failed.</p>
<div class="devsite-table-wrapper">
<table class="responsive">
@@ -207,7 +207,7 @@
</thead>
<tbody class="list">
<tr>
- <td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/functions/FirebaseFunctionsException.Code.html">FirebaseFunctionsException.Code</a></code></td>
+ <td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a></code></td>
<td>
<p>the code for the FirebaseFunctionsException</p>
</td> --- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/firestore/CollectionReference.html 2023-01-05 23:09:11.769060636 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/firestore/CollectionReference.html 2023-01-05 23:03:56.841220820 +0000
@@ -205,7 +205,7 @@
<tr>
<td width="40%"><code><a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a><<a href="/docs/reference/kotlin/com/google/firebase/firestore/QuerySnapshot.html">QuerySnapshot</a>!></code></td>
<td>
- <div><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/Query.html#get(com.google.firebase.firestore.Source)">get</a>(source: <a href="/docs/reference/kotlin/com/google/firebase/firestore/Source.html">Source</a>)</code></div>
+ <div><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/Query.html#get(com.google.firebase.firestore.Source)">get</a>(source: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>)</code></div>
<p>Executes the query and returns the results as a <code>QuerySnapshot</code>.</p>
</td>
</tr> --- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/firestore/DocumentReference.html 2023-01-05 23:09:11.773060634 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/firestore/DocumentReference.html 2023-01-05 23:03:56.841220820 +0000
@@ -109,7 +109,7 @@
<tr>
<td width="40%"><code><a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a><<a href="/docs/reference/kotlin/com/google/firebase/firestore/DocumentSnapshot.html">DocumentSnapshot</a>!></code></td>
<td>
- <div><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/DocumentReference.html#get(com.google.firebase.firestore.Source)">get</a>(source: <a href="/docs/reference/kotlin/com/google/firebase/firestore/Source.html">Source</a>)</code></div>
+ <div><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/DocumentReference.html#get(com.google.firebase.firestore.Source)">get</a>(source: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>)</code></div>
<p>Reads the document referenced by this <code>DocumentReference</code>.</p>
</td>
</tr>
@@ -561,7 +561,7 @@
</div>
<div><a name="get-com.google.firebase.firestore.Source-"></a><a name="get"></a>
<h3 class="api-name" id="get(com.google.firebase.firestore.Source)">get</h3>
- <pre class="api-signature no-pretty-print">fun <a href="/docs/reference/kotlin/com/google/firebase/firestore/DocumentReference.html#get(com.google.firebase.firestore.Source)">get</a>(source: <a href="/docs/reference/kotlin/com/google/firebase/firestore/Source.html">Source</a>): <a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a><<a href="/docs/reference/kotlin/com/google/firebase/firestore/DocumentSnapshot.html">DocumentSnapshot</a>!></pre>
+ <pre class="api-signature no-pretty-print">fun <a href="/docs/reference/kotlin/com/google/firebase/firestore/DocumentReference.html#get(com.google.firebase.firestore.Source)">get</a>(source: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>): <a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a><<a href="/docs/reference/kotlin/com/google/firebase/firestore/DocumentSnapshot.html">DocumentSnapshot</a>!></pre>
<p>Reads the document referenced by this <code>DocumentReference</code>. </p>
<p>By default, <code>get()</code> attempts to provide up-to-date data when possible by waiting for data from the server, but it may return cached data or fail if you are offline and the server cannot be reached. This behavior can be altered via the <code>Source</code> parameter.</p>
<div class="devsite-table-wrapper">
@@ -573,7 +573,7 @@
</thead>
<tbody class="list">
<tr>
- <td width="40%"><code>source: <a href="/docs/reference/kotlin/com/google/firebase/firestore/Source.html">Source</a></code></td>
+ <td width="40%"><code>source: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a></code></td>
<td>
<p>A value to configure the get behavior.</p>
</td> --- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/firestore/LoadBundleTaskProgress.html 2023-01-05 23:09:11.765060638 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/firestore/LoadBundleTaskProgress.html 2023-01-05 23:03:56.837220822 +0000
@@ -81,7 +81,7 @@
</td>
</tr>
<tr>
- <td width="40%"><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a></code></td>
+ <td width="40%"><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/LoadBundleTaskProgress.TaskState.html">LoadBundleTaskProgress.TaskState</a></code></td>
<td>
<div><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/LoadBundleTaskProgress.html#getTaskState()">getTaskState</a>()</code></div>
<p>Returns the current state of the <code><a href="/docs/reference/kotlin/com/google/firebase/firestore/LoadBundleTask.html">LoadBundleTask</a></code>.</p>
@@ -137,7 +137,7 @@
</div>
<div><a name="getTaskState--"></a><a name="gettaskstate"></a>
<h3 class="api-name" id="getTaskState()">getTaskState</h3>
- <pre class="api-signature no-pretty-print">fun <a href="/docs/reference/kotlin/com/google/firebase/firestore/LoadBundleTaskProgress.html#getTaskState()">getTaskState</a>(): <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a></pre>
+ <pre class="api-signature no-pretty-print">fun <a href="/docs/reference/kotlin/com/google/firebase/firestore/LoadBundleTaskProgress.html#getTaskState()">getTaskState</a>(): <a href="/docs/reference/kotlin/com/google/firebase/firestore/LoadBundleTaskProgress.TaskState.html">LoadBundleTaskProgress.TaskState</a></pre>
<p>Returns the current state of the <code><a href="/docs/reference/kotlin/com/google/firebase/firestore/LoadBundleTask.html">LoadBundleTask</a></code>.</p>
</div>
<div><a name="getTotalBytes--"></a><a name="gettotalbytes"></a> --- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/firestore/Query.html 2023-01-05 23:09:11.765060638 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/firestore/Query.html 2023-01-05 23:03:56.837220822 +0000
@@ -165,7 +165,7 @@
<tr>
<td width="40%"><code><a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a><<a href="/docs/reference/kotlin/com/google/firebase/firestore/QuerySnapshot.html">QuerySnapshot</a>!></code></td>
<td>
- <div><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/Query.html#get(com.google.firebase.firestore.Source)">get</a>(source: <a href="/docs/reference/kotlin/com/google/firebase/firestore/Source.html">Source</a>)</code></div>
+ <div><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/Query.html#get(com.google.firebase.firestore.Source)">get</a>(source: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>)</code></div>
<p>Executes the query and returns the results as a <code>QuerySnapshot</code>.</p>
</td>
</tr>
@@ -890,7 +890,7 @@
</div>
<div><a name="get-com.google.firebase.firestore.Source-"></a><a name="get"></a>
<h3 class="api-name" id="get(com.google.firebase.firestore.Source)">get</h3>
- <pre class="api-signature no-pretty-print">fun <a href="/docs/reference/kotlin/com/google/firebase/firestore/Query.html#get(com.google.firebase.firestore.Source)">get</a>(source: <a href="/docs/reference/kotlin/com/google/firebase/firestore/Source.html">Source</a>): <a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a><<a href="/docs/reference/kotlin/com/google/firebase/firestore/QuerySnapshot.html">QuerySnapshot</a>!></pre>
+ <pre class="api-signature no-pretty-print">fun <a href="/docs/reference/kotlin/com/google/firebase/firestore/Query.html#get(com.google.firebase.firestore.Source)">get</a>(source: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>): <a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a><<a href="/docs/reference/kotlin/com/google/firebase/firestore/QuerySnapshot.html">QuerySnapshot</a>!></pre>
<p>Executes the query and returns the results as a <code>QuerySnapshot</code>. </p>
<p>By default, <code>get()</code> attempts to provide up-to-date data when possible by waiting for data from the server, but it may return cached data or fail if you are offline and the server cannot be reached. This behavior can be altered via the <code>Source</code> parameter.</p>
<div class="devsite-table-wrapper">
@@ -902,7 +902,7 @@
</thead>
<tbody class="list">
<tr>
- <td width="40%"><code>source: <a href="/docs/reference/kotlin/com/google/firebase/firestore/Source.html">Source</a></code></td>
+ <td width="40%"><code>source: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a></code></td>
<td>
<p>A value to configure the get behavior.</p>
</td> --- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/functions/FirebaseFunctionsException.html 2023-01-05 23:09:04.061064458 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/functions/FirebaseFunctionsException.html 2023-01-05 23:04:02.221218142 +0000
@@ -85,7 +85,7 @@
</thead>
<tbody class="list">
<tr>
- <td width="40%"><code><a href="/docs/reference/kotlin/com/google/firebase/functions/FirebaseFunctionsException.Code.html">FirebaseFunctionsException.Code</a></code></td>
+ <td width="40%"><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a></code></td>
<td>
<div><code><a href="/docs/reference/kotlin/com/google/firebase/functions/FirebaseFunctionsException.html#getCode()">getCode</a>()</code></div>
<p>Gets the error code for the operation that failed.</p>
@@ -196,7 +196,7 @@
<h2>Public functions</h2>
<div><a name="getCode--"></a><a name="getcode"></a>
<h3 class="api-name" id="getCode()">getCode</h3>
- <pre class="api-signature no-pretty-print">fun <a href="/docs/reference/kotlin/com/google/firebase/functions/FirebaseFunctionsException.html#getCode()">getCode</a>(): <a href="/docs/reference/kotlin/com/google/firebase/functions/FirebaseFunctionsException.Code.html">FirebaseFunctionsException.Code</a></pre>
+ <pre class="api-signature no-pretty-print">fun <a href="/docs/reference/kotlin/com/google/firebase/functions/FirebaseFunctionsException.html#getCode()">getCode</a>(): <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a></pre>
<p>Gets the error code for the operation that failed.</p>
<div class="devsite-table-wrapper">
<table class="responsive">
@@ -207,7 +207,7 @@
</thead>
<tbody class="list">
<tr>
- <td width="40%"><code><a href="/docs/reference/kotlin/com/google/firebase/functions/FirebaseFunctionsException.Code.html">FirebaseFunctionsException.Code</a></code></td>
+ <td width="40%"><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a></code></td>
<td>
<p>the code for the FirebaseFunctionsException</p>
</td> |
Size Report 1Affected Products
Test Logs |
Coverage Report 1Affected Products
Test Logs |
rlazo
reviewed
Jan 6, 2023
rlazo
approved these changes
Jan 9, 2023
mrober
pushed a commit
that referenced
this pull request
Jan 30, 2023
* Resolve javadoc diff failures * Add comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves two issues relating to the javadoc diff action failing. Both scenarios involved no diff existing as far as I can tell, but it's much cleaner to succeed and no-op. Part one is just making empty build folders to move over if the changed SDKs don't output anything to build when generating javadoc (I didn't realize this was possible originally). The second change however involves letting the final step of posting the comment fail without issue. As of yet I've only seen this fail when provided with an empty file, however this might also mean we miss a breakage (though, the comment consistently disappearing is probably also a reasonable tip off). My original approach involved checking the length of the comment and skipping the step if it was too small, but it seemed hacky and prone to breakage, so I went with this solution instead.