Always call foreground activity callbacks on the UI thread #4531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it easier to reason about what runs on what thread.
Generated by 🚫 Danger |
lfkellogg
commented
Jan 5, 2023
| // construct FirebaseAppDistribution instance on startup so we can register for | ||
| // activity lifecycle callbacks before the API is called | ||
| .alwaysEager() | ||
| .build(), | ||
| Component.builder(FeedbackSender.class) | ||
| .add(Dependency.required(FirebaseApp.class)) | ||
| .add(Dependency.requiredProvider(FirebaseInstallationsApi.class)) | ||
| .add(Dependency.required(backgroundExecutor)) |
There was a problem hiding this comment.
I realized this wasn't used in FeedbackSender.
kaibolay
approved these changes
Jan 5, 2023
Coverage Report 1Affected Products
Test Logs |
Size Report 1Affected Products
Test Logs |
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Startup time comparison between the CI merge commit (e4911fa) and the base commit (8549013) are not available. No macrobenchmark data found for the base commit (8549013). Analysis for the CI merge commit (e4911fa) can be found at: |
kaibolay
pushed a commit
that referenced
this pull request
Jan 23, 2023
* Always call foreground activity callbacks on the UI thread This will make it easier to reason about what runs on what thread. * Refactor getActivityWithIgnoredClass to consolidate synchronized blocks
lfkellogg
added a commit
that referenced
this pull request
Jan 25, 2023
* Always call foreground activity callbacks on the UI thread This will make it easier to reason about what runs on what thread. * Refactor getActivityWithIgnoredClass to consolidate synchronized blocks
lfkellogg
added a commit
that referenced
this pull request
Jan 25, 2023
* Always call foreground activity callbacks on the UI thread This will make it easier to reason about what runs on what thread. * Refactor getActivityWithIgnoredClass to consolidate synchronized blocks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it easier to reason about what runs on what thread.