Extract APK hash on the background thread #4534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Coverage Report 1Affected Products
Test Logs |
kaibolay
approved these changes
Jan 6, 2023
| lightweightExecutor, | ||
| isSame -> { | ||
| if (isSame) { | ||
| LogWrapper.v(TAG, "New release is older or is currently installed"); |
There was a problem hiding this comment.
Is "older" always correct? Could be "newer" as well, right?
There was a problem hiding this comment.
Ah sorry I meant to clarify this because I knew it was misleading. It can be "older" in that if we can return false here only if the release has the same app version name, and the same APK hash, and has either an equal or older build version. If the build version was newer it would have returned true in the condition above.
I've added a comment and renamed some methods to make it clearer what's going on here.
Size Report 1Affected Products
Test Logs |
lfkellogg
force-pushed
the
lk/executors-wip
branch
from
0f43082 to
a8f4056
Compare
lfkellogg
force-pushed
the
lk/executors-wip
branch
from
a8f4056 to
07afc16
Compare
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Startup time comparison between the CI merge commit (8d3a330) and the base commit (6788546) are not available. No macrobenchmark data found for the base commit (6788546). Analysis for the CI merge commit (8d3a330) can be found at: |
kaibolay
pushed a commit
that referenced
this pull request
Jan 23, 2023
lfkellogg
added a commit
that referenced
this pull request
Jan 25, 2023
lfkellogg
added a commit
that referenced
this pull request
Jan 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.