Use Dagger in firebase-appdistribution #4540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Coverage Report 1Affected Products
Test Logs |
Size Report 1Affected Products
Test Logs |
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Startup time comparison between the CI merge commit (90564b1) and the base commit (10c1a92) are not available. No macrobenchmark data found for the base commit (10c1a92). Analysis for the CI merge commit (90564b1) can be found at: |
lfkellogg
force-pushed
the
lk/fad-dagger
branch
3 times, most recently
from
72ffea6 to
252b219
Compare
kaibolay
approved these changes
Jan 9, 2023
| } | ||
|
|
||
| @VisibleForTesting | ||
| @Inject | ||
| public ApkUpdater( |
There was a problem hiding this comment.
does this need to be public?
There was a problem hiding this comment.
Definitely not! Good catch.
lfkellogg
force-pushed
the
lk/fad-dagger
branch
from
252b219 to
70c51bc
Compare
vkryachko
reviewed
Jan 19, 2023
Comment on lines
+58
to
+62
| implementation 'javax.inject:javax.inject:1' | ||
| vendor ('com.google.dagger:dagger:2.43.2') { | ||
| exclude group: "javax.inject", module: "javax.inject" | ||
| } | ||
| annotationProcessor 'com.google.dagger:dagger-compiler:2.43.2' |
There was a problem hiding this comment.
please migrate to:
implementation libs.javax.inject
vendor (libs.dagger) {
exclude group: "javax.inject", module: "javax.inject"
}
annotationProcessor libs.dagger.compilerThis will ensure all sdks are aligned on the same version
There was a problem hiding this comment.
Fixed in followup: #4593
| @Lightweight private final Executor lightweightExecutor; | ||
|
|
||
| @Inject |
There was a problem hiding this comment.
For this class, and all other @Inject classes, please ensure that @Singleton is not required and it's ok to have different instances injected in different injection sites.
There was a problem hiding this comment.
Good call, fixed in followup: #4593
kaibolay
pushed a commit
that referenced
this pull request
Jan 23, 2023
lfkellogg
added a commit
that referenced
this pull request
Jan 25, 2023
lfkellogg
added a commit
that referenced
this pull request
Jan 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @vkryachko 's prototype: #4380
This leaves out support for multiple
FirebaseApps since our SDK does not support that yet.