Add unstyled button for uploading a custom screenshot #4550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
lfkellogg
force-pushed
the
lk/custom-screenshot
branch
from
f3b492d to
fd5be04
Compare
lfkellogg
commented
Jan 11, 2023
| // do I/O on separate thread in order to not block the UI | ||
| Bitmap screenshot = screenshotUri == null ? null : readScreenshot(); | ||
| // Do I/O on separate thread in order to not block the UI | ||
| Bitmap screenshot = readScreenshot(screenshotUri); |
There was a problem hiding this comment.
Now that screenshotUri could technically be modified on another thread I don't want to rely on its value being the same for the entirety of the execution of readScreenshot()
kaibolay
approved these changes
Jan 11, 2023
Coverage Report 1Affected Products
Test Logs |
lfkellogg
force-pushed
the
lk/custom-screenshot
branch
from
fd5be04 to
13a7d82
Compare
lfkellogg
force-pushed
the
lk/custom-screenshot
branch
from
13a7d82 to
8c4527f
Compare
Size Report 1Affected Products
Test Logs |
lfkellogg
force-pushed
the
lk/custom-screenshot
branch
from
10f8b52 to
b26c892
Compare
kaibolay
approved these changes
Jan 12, 2023
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Startup time comparison between the CI merge commit (3120813) and the base commit (db416c7) are not available. No macrobenchmark data found for the base commit (db416c7). Analysis for the CI merge commit (3120813) can be found at: |
kaibolay
pushed a commit
that referenced
this pull request
Jan 23, 2023
* Add unstyled button for uploading a custom screenshot * Bump compileSdkVersion to 31 * Use plain Activity Results API to avoid having to raise compile/target SDK version
lfkellogg
added a commit
that referenced
this pull request
Jan 25, 2023
* Add unstyled button for uploading a custom screenshot * Bump compileSdkVersion to 31 * Use plain Activity Results API to avoid having to raise compile/target SDK version
lfkellogg
added a commit
that referenced
this pull request
Jan 25, 2023
* Add unstyled button for uploading a custom screenshot * Bump compileSdkVersion to 31 * Use plain Activity Results API to avoid having to raise compile/target SDK version
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots:
With screenshot
Without screenshot