Fix smoke tests #4610
Merged
Fix smoke tests #4610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Javadoc Changes:--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/database/FirebaseDatabase.html 2023-02-01 01:43:41.068384600 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/database/FirebaseDatabase.html 2023-02-01 01:35:49.381271162 +0000
@@ -122,7 +122,7 @@
<tr>
<td width="40%"><code>synchronized void</code></td>
<td>
- <div><code><a href="/docs/reference/android/com/google/firebase/database/FirebaseDatabase.html#setLogLevel(com.google.firebase.database.Logger.Level)">setLogLevel</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/database/Logger.Level.html">Logger.Level</a> logLevel)</code></div>
+ <div><code><a href="/docs/reference/android/com/google/firebase/database/FirebaseDatabase.html#setLogLevel(com.google.firebase.database.Logger.Level)">setLogLevel</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a> logLevel)</code></div>
<p>By default, this is set to <code><a href="/docs/reference/android/com/google/firebase/database/Logger.Level.html#INFO">INFO</a></code>.</p>
</td>
</tr>
@@ -462,7 +462,7 @@
</div>
<div><a name="setLogLevel-com.google.firebase.database.Logger.Level-"></a><a name="setloglevel"></a>
<h3 class="api-name" id="setLogLevel(com.google.firebase.database.Logger.Level)">setLogLevel</h3>
- <pre class="api-signature no-pretty-print">synchronized public void <a href="/docs/reference/android/com/google/firebase/database/FirebaseDatabase.html#setLogLevel(com.google.firebase.database.Logger.Level)">setLogLevel</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/database/Logger.Level.html">Logger.Level</a> logLevel)</pre>
+ <pre class="api-signature no-pretty-print">synchronized public void <a href="/docs/reference/android/com/google/firebase/database/FirebaseDatabase.html#setLogLevel(com.google.firebase.database.Logger.Level)">setLogLevel</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a> logLevel)</pre>
<p>By default, this is set to <code><a href="/docs/reference/android/com/google/firebase/database/Logger.Level.html#INFO">INFO</a></code>. This includes any internal errors (<code><a href="/docs/reference/android/com/google/firebase/database/Logger.Level.html#ERROR">ERROR</a></code>) and any security debug messages (<code><a href="/docs/reference/android/com/google/firebase/database/Logger.Level.html#INFO">INFO</a></code>) that the client receives. Set to <code><a href="/docs/reference/android/com/google/firebase/database/Logger.Level.html#DEBUG">DEBUG</a></code> to turn on the diagnostic logging, and <code><a href="/docs/reference/android/com/google/firebase/database/Logger.Level.html#NONE">NONE</a></code> to disable all logging.</p>
<div class="devsite-table-wrapper">
<table class="responsive">
@@ -473,7 +473,7 @@
</thead>
<tbody class="list">
<tr>
- <td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/database/Logger.Level.html">Logger.Level</a> logLevel</code></td>
+ <td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a> logLevel</code></td>
<td>
<p>The desired minimum log level</p>
</td>--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/database/FirebaseDatabase.html 2023-02-01 01:43:41.116384642 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/database/FirebaseDatabase.html 2023-02-01 01:35:49.401271127 +0000
@@ -122,7 +122,7 @@
<tr>
<td width="40%"><code>synchronized <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-unit/index.html">Unit</a></code></td>
<td>
- <div><code><a href="/docs/reference/kotlin/com/google/firebase/database/FirebaseDatabase.html#setLogLevel(com.google.firebase.database.Logger.Level)">setLogLevel</a>(logLevel: <a href="/docs/reference/kotlin/com/google/firebase/database/Logger.Level.html">Logger.Level</a>)</code></div>
+ <div><code><a href="/docs/reference/kotlin/com/google/firebase/database/FirebaseDatabase.html#setLogLevel(com.google.firebase.database.Logger.Level)">setLogLevel</a>(logLevel: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>)</code></div>
<p>By default, this is set to <code><a href="/docs/reference/kotlin/com/google/firebase/database/Logger.Level.html#INFO">INFO</a></code>.</p>
</td>
</tr>
@@ -462,7 +462,7 @@
</div>
<div><a name="setLogLevel-com.google.firebase.database.Logger.Level-"></a><a name="setloglevel"></a>
<h3 class="api-name" id="setLogLevel(com.google.firebase.database.Logger.Level)">setLogLevel</h3>
- <pre class="api-signature no-pretty-print">synchronized fun <a href="/docs/reference/kotlin/com/google/firebase/database/FirebaseDatabase.html#setLogLevel(com.google.firebase.database.Logger.Level)">setLogLevel</a>(logLevel: <a href="/docs/reference/kotlin/com/google/firebase/database/Logger.Level.html">Logger.Level</a>): <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-unit/index.html">Unit</a></pre>
+ <pre class="api-signature no-pretty-print">synchronized fun <a href="/docs/reference/kotlin/com/google/firebase/database/FirebaseDatabase.html#setLogLevel(com.google.firebase.database.Logger.Level)">setLogLevel</a>(logLevel: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>): <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-unit/index.html">Unit</a></pre>
<p>By default, this is set to <code><a href="/docs/reference/kotlin/com/google/firebase/database/Logger.Level.html#INFO">INFO</a></code>. This includes any internal errors (<code><a href="/docs/reference/kotlin/com/google/firebase/database/Logger.Level.html#ERROR">ERROR</a></code>) and any security debug messages (<code><a href="/docs/reference/kotlin/com/google/firebase/database/Logger.Level.html#INFO">INFO</a></code>) that the client receives. Set to <code><a href="/docs/reference/kotlin/com/google/firebase/database/Logger.Level.html#DEBUG">DEBUG</a></code> to turn on the diagnostic logging, and <code><a href="/docs/reference/kotlin/com/google/firebase/database/Logger.Level.html#NONE">NONE</a></code> to disable all logging.</p>
<div class="devsite-table-wrapper">
<table class="responsive">
@@ -473,7 +473,7 @@
</thead>
<tbody class="list">
<tr>
- <td width="40%"><code>logLevel: <a href="/docs/reference/kotlin/com/google/firebase/database/Logger.Level.html">Logger.Level</a></code></td>
+ <td width="40%"><code>logLevel: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a></code></td>
<td>
<p>The desired minimum log level</p>
</td> |
Size Report 1Affected Products
Test Logs |
Coverage Report 1Affected Products
Test Logs |
yifanyang
force-pushed
the
yifany/debug-smoke-tests
branch
2 times, most recently
from
df01ce1 to
7d6b6e8
Compare
yifanyang
force-pushed
the
yifany/debug-smoke-tests
branch
from
7d6b6e8 to
16ab432
Compare
This reverts commit 4c92483.
daymxn
approved these changes
Feb 1, 2023
There was a problem hiding this comment.
LGTM- you're the goat for looking into this, great job! The firebase-storage unit test failure is a flake, which I was investigating today- but needs further inspection. I haven't looked at the implementation tests though, so double check that they're just flakes since we're bumping the gradle version (I doubt it'll cause any issues, but just to be safe).
@daymxn Thanks! The unit test for |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should fix existing smoke tests failure. There were two problems:
fireescapewhen packaging maven artifacts, which with the current test setup, make artifacts not resolvable in smoke testsgradleto7.5.1which has a known issue StackOverflowError in FinalizerGroup.isCanCancel when handling build failure gradle/gradle#21542, hence the gradleStackOverflowErrorerror