Converty library plugins to kotlin #4627
Conversation
Javadoc Changes:--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/database/FirebaseDatabase.html 2023-02-10 19:10:55.811009926 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/database/FirebaseDatabase.html 2023-02-10 19:05:06.250275087 +0000
@@ -122,7 +122,7 @@
<tr>
<td width="40%"><code>synchronized void</code></td>
<td>
- <div><code><a href="/docs/reference/android/com/google/firebase/database/FirebaseDatabase.html#setLogLevel(com.google.firebase.database.Logger.Level)">setLogLevel</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a> logLevel)</code></div>
+ <div><code><a href="/docs/reference/android/com/google/firebase/database/FirebaseDatabase.html#setLogLevel(com.google.firebase.database.Logger.Level)">setLogLevel</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/database/Logger.Level.html">Logger.Level</a> logLevel)</code></div>
<p>By default, this is set to <code><a href="/docs/reference/android/com/google/firebase/database/Logger.Level.html#INFO">INFO</a></code>.</p>
</td>
</tr>
@@ -462,7 +462,7 @@
</div>
<div><a name="setLogLevel-com.google.firebase.database.Logger.Level-"></a><a name="setloglevel"></a>
<h3 class="api-name" id="setLogLevel(com.google.firebase.database.Logger.Level)">setLogLevel</h3>
- <pre class="api-signature no-pretty-print">synchronized public void <a href="/docs/reference/android/com/google/firebase/database/FirebaseDatabase.html#setLogLevel(com.google.firebase.database.Logger.Level)">setLogLevel</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a> logLevel)</pre>
+ <pre class="api-signature no-pretty-print">synchronized public void <a href="/docs/reference/android/com/google/firebase/database/FirebaseDatabase.html#setLogLevel(com.google.firebase.database.Logger.Level)">setLogLevel</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/database/Logger.Level.html">Logger.Level</a> logLevel)</pre>
<p>By default, this is set to <code><a href="/docs/reference/android/com/google/firebase/database/Logger.Level.html#INFO">INFO</a></code>. This includes any internal errors (<code><a href="/docs/reference/android/com/google/firebase/database/Logger.Level.html#ERROR">ERROR</a></code>) and any security debug messages (<code><a href="/docs/reference/android/com/google/firebase/database/Logger.Level.html#INFO">INFO</a></code>) that the client receives. Set to <code><a href="/docs/reference/android/com/google/firebase/database/Logger.Level.html#DEBUG">DEBUG</a></code> to turn on the diagnostic logging, and <code><a href="/docs/reference/android/com/google/firebase/database/Logger.Level.html#NONE">NONE</a></code> to disable all logging.</p>
<div class="devsite-table-wrapper">
<table class="responsive">
@@ -473,7 +473,7 @@
</thead>
<tbody class="list">
<tr>
- <td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a> logLevel</code></td>
+ <td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/database/Logger.Level.html">Logger.Level</a> logLevel</code></td>
<td>
<p>The desired minimum log level</p>
</td>--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/database/FirebaseDatabase.html 2023-02-10 19:10:55.827009959 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/database/FirebaseDatabase.html 2023-02-10 19:05:06.282275154 +0000
@@ -122,7 +122,7 @@
<tr>
<td width="40%"><code>synchronized <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-unit/index.html">Unit</a></code></td>
<td>
- <div><code><a href="/docs/reference/kotlin/com/google/firebase/database/FirebaseDatabase.html#setLogLevel(com.google.firebase.database.Logger.Level)">setLogLevel</a>(logLevel: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>)</code></div>
+ <div><code><a href="/docs/reference/kotlin/com/google/firebase/database/FirebaseDatabase.html#setLogLevel(com.google.firebase.database.Logger.Level)">setLogLevel</a>(logLevel: <a href="/docs/reference/kotlin/com/google/firebase/database/Logger.Level.html">Logger.Level</a>)</code></div>
<p>By default, this is set to <code><a href="/docs/reference/kotlin/com/google/firebase/database/Logger.Level.html#INFO">INFO</a></code>.</p>
</td>
</tr>
@@ -462,7 +462,7 @@
</div>
<div><a name="setLogLevel-com.google.firebase.database.Logger.Level-"></a><a name="setloglevel"></a>
<h3 class="api-name" id="setLogLevel(com.google.firebase.database.Logger.Level)">setLogLevel</h3>
- <pre class="api-signature no-pretty-print">synchronized fun <a href="/docs/reference/kotlin/com/google/firebase/database/FirebaseDatabase.html#setLogLevel(com.google.firebase.database.Logger.Level)">setLogLevel</a>(logLevel: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>): <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-unit/index.html">Unit</a></pre>
+ <pre class="api-signature no-pretty-print">synchronized fun <a href="/docs/reference/kotlin/com/google/firebase/database/FirebaseDatabase.html#setLogLevel(com.google.firebase.database.Logger.Level)">setLogLevel</a>(logLevel: <a href="/docs/reference/kotlin/com/google/firebase/database/Logger.Level.html">Logger.Level</a>): <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-unit/index.html">Unit</a></pre>
<p>By default, this is set to <code><a href="/docs/reference/kotlin/com/google/firebase/database/Logger.Level.html#INFO">INFO</a></code>. This includes any internal errors (<code><a href="/docs/reference/kotlin/com/google/firebase/database/Logger.Level.html#ERROR">ERROR</a></code>) and any security debug messages (<code><a href="/docs/reference/kotlin/com/google/firebase/database/Logger.Level.html#INFO">INFO</a></code>) that the client receives. Set to <code><a href="/docs/reference/kotlin/com/google/firebase/database/Logger.Level.html#DEBUG">DEBUG</a></code> to turn on the diagnostic logging, and <code><a href="/docs/reference/kotlin/com/google/firebase/database/Logger.Level.html#NONE">NONE</a></code> to disable all logging.</p>
<div class="devsite-table-wrapper">
<table class="responsive">
@@ -473,7 +473,7 @@
</thead>
<tbody class="list">
<tr>
- <td width="40%"><code>logLevel: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a></code></td>
+ <td width="40%"><code>logLevel: <a href="/docs/reference/kotlin/com/google/firebase/database/Logger.Level.html">Logger.Level</a></code></td>
<td>
<p>The desired minimum log level</p>
</td> |
Size Report 1Affected ProductsNo changes between base commit (0c1240e) and merge commit (a53c5f8).Test Logs |
Coverage Report 1Affected Products
Test Logs |
emilypgoogle
force-pushed
the
ep/firebase-library-plugin-kotlin
branch
from
0fa0142 to
1fbd1bb
Compare
|
The public api surface has changed for the subproject firebase-dynamic-links_ktx: The public api surface has changed for the subproject firebase-functions_ktx: The public api surface has changed for the subproject firebase-messaging_ktx: The public api surface has changed for the subproject firebase-inappmessaging_ktx: The public api surface has changed for the subproject firebase-storage_ktx: The public api surface has changed for the subproject firebase-perf_ktx: The public api surface has changed for the subproject firebase-inappmessaging-display_ktx: The public api surface has changed for the subproject appcheck_firebase-appcheck_ktx: The public api surface has changed for the subproject firebase-common_ktx: The public api surface has changed for the subproject firebase-appdistribution-api_ktx: The public api surface has changed for the subproject firebase-config_ktx: The public api surface has changed for the subproject firebase-installations_ktx: The public api surface has changed for the subproject firebase-ml-modeldownloader_ktx: The public api surface has changed for the subproject firebase-crashlytics_ktx: The public api surface has changed for the subproject firebase-database_ktx: The public api surface has changed for the subproject firebase-firestore_ktx: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
2 similar comments
|
The public api surface has changed for the subproject firebase-dynamic-links_ktx: The public api surface has changed for the subproject firebase-functions_ktx: The public api surface has changed for the subproject firebase-messaging_ktx: The public api surface has changed for the subproject firebase-inappmessaging_ktx: The public api surface has changed for the subproject firebase-storage_ktx: The public api surface has changed for the subproject firebase-perf_ktx: The public api surface has changed for the subproject firebase-inappmessaging-display_ktx: The public api surface has changed for the subproject appcheck_firebase-appcheck_ktx: The public api surface has changed for the subproject firebase-common_ktx: The public api surface has changed for the subproject firebase-appdistribution-api_ktx: The public api surface has changed for the subproject firebase-config_ktx: The public api surface has changed for the subproject firebase-installations_ktx: The public api surface has changed for the subproject firebase-ml-modeldownloader_ktx: The public api surface has changed for the subproject firebase-crashlytics_ktx: The public api surface has changed for the subproject firebase-database_ktx: The public api surface has changed for the subproject firebase-firestore_ktx: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
|
The public api surface has changed for the subproject firebase-dynamic-links_ktx: The public api surface has changed for the subproject firebase-functions_ktx: The public api surface has changed for the subproject firebase-messaging_ktx: The public api surface has changed for the subproject firebase-inappmessaging_ktx: The public api surface has changed for the subproject firebase-storage_ktx: The public api surface has changed for the subproject firebase-perf_ktx: The public api surface has changed for the subproject firebase-inappmessaging-display_ktx: The public api surface has changed for the subproject appcheck_firebase-appcheck_ktx: The public api surface has changed for the subproject firebase-common_ktx: The public api surface has changed for the subproject firebase-appdistribution-api_ktx: The public api surface has changed for the subproject firebase-config_ktx: The public api surface has changed for the subproject firebase-installations_ktx: The public api surface has changed for the subproject firebase-ml-modeldownloader_ktx: The public api surface has changed for the subproject firebase-crashlytics_ktx: The public api surface has changed for the subproject firebase-database_ktx: The public api surface has changed for the subproject firebase-firestore_ktx: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
buildSrc/src/main/java/com/google/firebase/gradle/plugins/FirebaseJavaLibraryPlugin.kt
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/com/google/firebase/gradle/plugins/FirebaseJavaLibraryPlugin.kt
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/com/google/firebase/gradle/plugins/FirebaseJavaLibraryPlugin.kt
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/com/google/firebase/gradle/plugins/FirebaseJavaLibraryPlugin.kt
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/com/google/firebase/gradle/plugins/FirebaseLibraryPlugin.kt
Show resolved
Hide resolved
buildSrc/src/main/java/com/google/firebase/gradle/plugins/FirebaseLibraryPlugin.kt
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/com/google/firebase/gradle/plugins/FirebaseLibraryPlugin.kt
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/com/google/firebase/gradle/plugins/FirebaseLibraryPlugin.kt
Show resolved
Hide resolved
buildSrc/src/main/java/com/google/firebase/gradle/plugins/FirebaseLibraryPlugin.kt
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/com/google/firebase/gradle/plugins/FirebaseLibraryPlugin.kt
Show resolved
Hide resolved
buildSrc/src/main/java/com/google/firebase/gradle/plugins/FirebaseLibraryPlugin.kt
Show resolved
Hide resolved
buildSrc/src/main/java/com/google/firebase/gradle/plugins/FirebaseLibraryPlugin.kt
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/com/google/firebase/gradle/plugins/FirebaseLibraryPlugin.kt
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/com/google/firebase/gradle/plugins/FirebaseLibraryPlugin.kt
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/com/google/firebase/gradle/plugins/FirebaseLibraryPlugin.kt
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/com/google/firebase/gradle/plugins/GradleUtils.kt
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/com/google/firebase/gradle/plugins/FirebaseLibraryPlugin.kt
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/com/google/firebase/gradle/plugins/BaseFirebaseLibraryPlugin.kt
Show resolved
Hide resolved
buildSrc/src/main/java/com/google/firebase/gradle/plugins/BaseFirebaseLibraryPlugin.kt
Show resolved
Hide resolved
Initial pass to convert
FirebaseLibraryPluginandFirebaseJavaLibrarPluginto Kotlin. Some duplicate methods have been migrated out toGradleUtils, I'd also like to refactorsetupApiInformationAnalysisto use a single common function rather than being mostly duplicated between both classes, and take a step back and see if structure here can be changed.