Skip to content

Fiam crash fix #4691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 21, 2023
Merged

Fiam crash fix #4691

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
398596c
Adding null check
eldhosembabu Feb 16, 2023
f19e9d1
Formatting
eldhosembabu Feb 16, 2023
c82824c
Update firebase-inappmessaging-display/src/main/java/com/google/fireb…
eldhosembabu Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...c/main/java/com/google/firebase/inappmessaging/display/FirebaseInAppMessagingDisplay.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,12 @@ public void run() {
// it is safe to ignore this warning
@SuppressLint("ClickableViewAccessibility")
private void inflateBinding(final Activity activity, final BindingWrapper bindingWrapper) {
if (inAppMessage == null) {
// inAppMessage could get null because of race conditions from prior inapp message timers. So
// adding a safety null check. See b/269599986
return;
}

// On click listener when X button or collapse button is clicked
final View.OnClickListener dismissListener =
new View.OnClickListener() {
Expand Down