Use query API for getCanonicalId test rather than Target API. #4705

ehsannas · 2023-02-21T20:20:32Z

No description provided.

github-actions · 2023-02-21T20:20:49Z

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended.

google-oss-bot · 2023-02-21T20:21:01Z

	1 Warning
⚠️	Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

google-oss-bot · 2023-02-21T20:27:19Z

Coverage Report ¹

Affected Products

firebase-firestore
Overall coverage changed from 44.15% (c60f76b) to 44.12% (2351cb8) by -0.03%.
Filename Base (c60f76b) Merge (2351cb8) Diff
DeleteMutation.java 95.24% 90.48% -4.76%
LocalStore.java 100.00% 99.37% -0.63%
LruGarbageCollector.java 97.20% 93.46% -3.74%
SetMutation.java 97.22% 94.44% -2.78%

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/5YpEi8K6fr.html

github-actions · 2023-02-21T20:31:58Z

Unit Test Results

  158 files +  146   158 suites +146 2m 28s ⏱️ + 1m 32s
1 116 tests +1 069 1 100 ✔️ +1 054 16 💤 +15 0 ❌ ±0
2 232 runs +2 138 2 200 ✔️ +2 108 32 💤 +30 0 ❌ ±0

Results for commit d8d2994. ± Comparison against base commit c60f76b.

This pull request removes 47 and adds 1116 tests. Note that renamed tests count towards both.

com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplayTest ‑ dismissClickListener_dismissesFiam
com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplayTest ‑ dismissTimer_onComplete_dismissesFiam
com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplayTest ‑ fiamClickListener_whenActionUrlProvided_andBrowserAvailable_opensBrowserIntent
com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplayTest ‑ fiamClickListener_whenActionUrlProvided_andChromeAvailable_opensCustomTab
com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplayTest ‑ fiamUIListener_whenFiamClicked_receivesOnFiamClick
com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplayTest ‑ firebaseInAppMessagingUIListener_whenFiamRendered_receivesOnFiamTrigger
com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplayTest ‑ impressionTimer_onComplete_firesImpressionLogAction
com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplayTest ‑ inflate_setsActionListenerToDismissFiamOnClick
com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplayTest ‑ onActivitPaused_clearsListeners
com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplayTest ‑ onActivityNewActivityStarted_displaysFiamInNewActivity
…

com.google.firebase.TimestampTest ‑ testCompare
com.google.firebase.TimestampTest ‑ testFromDate
com.google.firebase.TimestampTest ‑ testRejectBadDates
com.google.firebase.TimestampTest ‑ testTimestampParcelable
com.google.firebase.firestore.AggregateQueryTest ‑ testSourceMustNotBeNull
com.google.firebase.firestore.BlobTest ‑ testComparison
com.google.firebase.firestore.BlobTest ‑ testEquals
com.google.firebase.firestore.BlobTest ‑ testMutableBytes
com.google.firebase.firestore.CollectionReferenceTest ‑ testEquals
com.google.firebase.firestore.DocumentChangeTest ‑ randomTests
…

This pull request removes 1 skipped test and adds 16 skipped tests. Note that renamed tests count towards both.

com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplayTest ‑ streamListener_onNotifiedCard_showsCardMessage

com.google.firebase.firestore.FirestoreRegistrarTest ‑ storageRegistrar_getComponents_publishesLibVersionComponent
com.google.firebase.firestore.local.MemoryLocalStoreTest ‑ testDoesNotReplaceResumeTokenWithEmptyByteString
com.google.firebase.firestore.local.MemoryLocalStoreTest ‑ testHandlesSetMutationThenAckThenTransformThenAckThenTransform
com.google.firebase.firestore.local.MemoryLocalStoreTest ‑ testIgnoresTargetMappingAfterExistenceFilterMismatch
com.google.firebase.firestore.local.MemoryLocalStoreTest ‑ testPersistsResumeTokens
com.google.firebase.firestore.local.MemoryLocalStoreTest ‑ testQueriesFilterDocumentsThatNoLongerMatch
com.google.firebase.firestore.local.MemoryLocalStoreTest ‑ testQueriesIncludeDocumentsFromOtherQueries
com.google.firebase.firestore.local.MemoryLocalStoreTest ‑ testQueriesIncludeLocallyModifiedDocuments
com.google.firebase.firestore.local.MemoryLocalStoreTest ‑ testUsesTargetMappingToExecuteQueries
com.google.firebase.firestore.local.SQLiteLocalStoreTest ‑ testCollectsGarbageAfterAcknowledgedMutation
…

google-oss-bot · 2023-02-21T20:39:37Z

Size Report ¹

Affected Products

No changes between base commit (c60f76b) and merge commit (2351cb8).

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/xV2q9vE5He.html

google-oss-bot · 2023-02-21T20:50:50Z

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

This report is for comparing the base commit (c60f76b) and the CI merge commit (2351cb8)
Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
- c60f76b: https://storage.googleapis.com/firebase-sdk-metric-reports/lp7O0pfPCX/index.html
- 2351cb8: https://storage.googleapis.com/firebase-sdk-metric-reports/3T7gyFfnLd/index.html

Startup Times

`fire-fst`

Device Statistics Distributions

oriole-32

Percentile	`c60f76b`	`2351cb8`	Diff	Significant (?)
p10	390 ±129 μs	332 ±19 μs	-57.9 μs (-14.8%)	NO
p25	416 ±152 μs	346 ±22 μs	-70.4 μs (-16.9%)	NO
p50	461 ±192 μs	365 ±25 μs	-96.3 μs (-20.9%)	NO
p75	551 ±290 μs	404 ±31 μs	-146 μs (-26.6%)	NO
p90	754 ±612 μs	493 ±60 μs	-260 μs (-34.5%)	NO

20 test runs in comparison

Commit	Test Runs
`c60f76b`	2023-02-21_19:04:30.206365_Iyri 2023-02-21_19:04:30.208829_JKSV 2023-02-21_19:04:30.208841_lKur 2023-02-21_19:04:30.208847_eRSy 2023-02-21_19:04:30.208852_vFUl 2023-02-21_19:04:30.208858_GnOE 2023-02-21_19:04:30.208863_EzdV 2023-02-21_19:04:30.208868_sqoC 2023-02-21_19:04:30.208873_SIlR 2023-02-21_19:04:30.208878_NymI
`2351cb8`	2023-02-21_20:38:05.249517_gszl 2023-02-21_20:38:05.254997_VexN 2023-02-21_20:38:05.255010_wPtw 2023-02-21_20:38:05.255016_JIRF 2023-02-21_20:38:05.255161_RQcE 2023-02-21_20:38:05.255167_TPYt 2023-02-21_20:38:05.255173_Oest 2023-02-21_20:38:05.255181_bFHf 2023-02-21_20:38:05.255186_rkhK 2023-02-21_20:38:05.255334_kpwz

redfin-30

Percentile	`c60f76b`	`2351cb8`	Diff	Significant (?)
p10	626 ±27 μs	640 ±23 μs	+14.1 μs (+2.3%)	NO
p25	646 ±29 μs	655 ±25 μs	+8.70 μs (+1.3%)	NO
p50	674 ±36 μs	678 ±32 μs	+3.70 μs (+0.5%)	NO
p75	713 ±50 μs	711 ±41 μs	-2.65 μs (-0.4%)	NO
p90	763 ±77 μs	752 ±57 μs	-11.2 μs (-1.5%)	NO

20 test runs in comparison

Commit	Test Runs
`c60f76b`	2023-02-21_19:04:30.206365_Iyri 2023-02-21_19:04:30.208829_JKSV 2023-02-21_19:04:30.208841_lKur 2023-02-21_19:04:30.208847_eRSy 2023-02-21_19:04:30.208852_vFUl 2023-02-21_19:04:30.208858_GnOE 2023-02-21_19:04:30.208863_EzdV 2023-02-21_19:04:30.208868_sqoC 2023-02-21_19:04:30.208873_SIlR 2023-02-21_19:04:30.208878_NymI
`2351cb8`	2023-02-21_20:38:05.249517_gszl 2023-02-21_20:38:05.254997_VexN 2023-02-21_20:38:05.255010_wPtw 2023-02-21_20:38:05.255016_JIRF 2023-02-21_20:38:05.255161_RQcE 2023-02-21_20:38:05.255167_TPYt 2023-02-21_20:38:05.255173_Oest 2023-02-21_20:38:05.255181_bFHf 2023-02-21_20:38:05.255186_rkhK 2023-02-21_20:38:05.255334_kpwz

`timeToInitialDisplay`

Device Statistics Distributions

oriole-32

Percentile	`c60f76b`	`2351cb8`	Diff	Significant (?)
p10	207 ±38 ms	196 ±8 ms	-11.2 ms (-5.4%)	NO
p25	216 ±43 ms	202 ±8 ms	-14.1 ms (-6.5%)	NO
p50	228 ±53 ms	210 ±9 ms	-18.4 ms (-8.1%)	NO
p75	244 ±70 ms	218 ±10 ms	-26.0 ms (-10.6%)	NO
p90	259 ±81 ms	229 ±10 ms	-29.8 ms (-11.5%)	NO

20 test runs in comparison

Commit	Test Runs
`c60f76b`	2023-02-21_19:04:30.206365_Iyri 2023-02-21_19:04:30.208829_JKSV 2023-02-21_19:04:30.208841_lKur 2023-02-21_19:04:30.208847_eRSy 2023-02-21_19:04:30.208852_vFUl 2023-02-21_19:04:30.208858_GnOE 2023-02-21_19:04:30.208863_EzdV 2023-02-21_19:04:30.208868_sqoC 2023-02-21_19:04:30.208873_SIlR 2023-02-21_19:04:30.208878_NymI
`2351cb8`	2023-02-21_20:38:05.249517_gszl 2023-02-21_20:38:05.254997_VexN 2023-02-21_20:38:05.255010_wPtw 2023-02-21_20:38:05.255016_JIRF 2023-02-21_20:38:05.255161_RQcE 2023-02-21_20:38:05.255167_TPYt 2023-02-21_20:38:05.255173_Oest 2023-02-21_20:38:05.255181_bFHf 2023-02-21_20:38:05.255186_rkhK 2023-02-21_20:38:05.255334_kpwz

redfin-30

Percentile	`c60f76b`	`2351cb8`	Diff	Significant (?)
p10	230 ±4 ms	250 ±4 ms	+20.0 ms (+8.7%)	MAYBE
p25	237 ±4 ms	256 ±3 ms	+19.6 ms (+8.3%)	YES
p50	244 ±4 ms	263 ±4 ms	+19.4 ms (+8.0%)	YES
p75	251 ±5 ms	272 ±3 ms	+20.4 ms (+8.1%)	MAYBE
p90	261 ±6 ms	284 ±5 ms	+23.0 ms (+8.8%)	MAYBE

20 test runs in comparison

Commit	Test Runs
`c60f76b`	2023-02-21_19:04:30.206365_Iyri 2023-02-21_19:04:30.208829_JKSV 2023-02-21_19:04:30.208841_lKur 2023-02-21_19:04:30.208847_eRSy 2023-02-21_19:04:30.208852_vFUl 2023-02-21_19:04:30.208858_GnOE 2023-02-21_19:04:30.208863_EzdV 2023-02-21_19:04:30.208868_sqoC 2023-02-21_19:04:30.208873_SIlR 2023-02-21_19:04:30.208878_NymI
`2351cb8`	2023-02-21_20:38:05.249517_gszl 2023-02-21_20:38:05.254997_VexN 2023-02-21_20:38:05.255010_wPtw 2023-02-21_20:38:05.255016_JIRF 2023-02-21_20:38:05.255161_RQcE 2023-02-21_20:38:05.255167_TPYt 2023-02-21_20:38:05.255173_Oest 2023-02-21_20:38:05.255181_bFHf 2023-02-21_20:38:05.255186_rkhK 2023-02-21_20:38:05.255334_kpwz

https://storage.googleapis.com/firebase-sdk-metric-reports/5wvzpTvib0/index.html

Use query API for getCanonicalId test rather than Target API.

d8d2994

google-oss-bot added the size/XS label Feb 21, 2023

ehsannas requested a review from cherylEnkidu February 21, 2023 20:28

ehsannas assigned cherylEnkidu Feb 21, 2023

cherylEnkidu approved these changes Feb 21, 2023

View reviewed changes

ehsannas added the main-merge-ack label Feb 27, 2023

ehsannas merged commit 5c11b8a into master Feb 27, 2023

ehsannas deleted the ehsann/better-unit-test branch February 27, 2023 20:48

firebase locked and limited conversation to collaborators Mar 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use query API for getCanonicalId test rather than Target API. #4705

Use query API for getCanonicalId test rather than Target API. #4705

Uh oh!

ehsannas commented Feb 21, 2023

Uh oh!

github-actions bot commented Feb 21, 2023 •

edited

Loading

Uh oh!

google-oss-bot commented Feb 21, 2023

Uh oh!

google-oss-bot commented Feb 21, 2023

`firebase-firestore`

Uh oh!

github-actions bot commented Feb 21, 2023

Uh oh!

google-oss-bot commented Feb 21, 2023

Uh oh!

google-oss-bot commented Feb 21, 2023

`fire-fst`

`timeToInitialDisplay`

Uh oh!

Uh oh!

Use query API for getCanonicalId test rather than Target API. #4705

Use query API for getCanonicalId test rather than Target API. #4705

Uh oh!

Conversation

ehsannas commented Feb 21, 2023

Uh oh!

github-actions bot commented Feb 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 PRs merging into main branch

Uh oh!

google-oss-bot commented Feb 21, 2023

Uh oh!

google-oss-bot commented Feb 21, 2023

Coverage Report 1

Affected Products

firebase-firestore

Test Logs

Uh oh!

github-actions bot commented Feb 21, 2023

Unit Test Results

Uh oh!

google-oss-bot commented Feb 21, 2023

Size Report 1

Affected Products

Test Logs

Uh oh!

google-oss-bot commented Feb 21, 2023

Startup Time Report 1

Notes

Startup Times

fire-fst

timeToInitialDisplay

Uh oh!

Uh oh!

github-actions bot commented Feb 21, 2023 •

edited

Loading

Coverage Report ¹

`firebase-firestore`

Size Report ¹

Startup Time Report ¹

`fire-fst`

`timeToInitialDisplay`