-
Notifications
You must be signed in to change notification settings - Fork 624
Add '-Werror' for main build and suppress one deprecation warning #471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@rsgowman The tests failed, but I cannot reproduce locally. If you know on top of your mind why this fails please let me know. |
Try merging master. The first error I see here is:
grpc was recently updated in master (by me), so it's entirely possible that grpc has deprecated some features between the old version and the current one. Ideally, I would've noticed this while doing the update, but of course didn't, since we didn't have -Werror enabled. This is exactly the sort of thing we'll be able to avoid thanks to your change. :) As to what to do here, https://grpc.github.io/grpc-java/javadoc/io/grpc/CallCredentials2.html says Aside from our test suite, it would likely be worthwhile to run a quick manual test to ensure everything's still fine. This class deals with auth tokens, so something that logs in/out would be a good candidate. FriendlyEats (https://github.com/firebase/friendlyeats-android) should do it. If you're unsure of how to go about this, I can walk you through it. |
451d84e
to
60fb0d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed all warnings and also run fireeats against this PR, it seems to work fine.
No description provided.