Skip to content

Update DackkaPlugin to use 1.2.0 #4714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Feb 27, 2023
Merged

Update DackkaPlugin to use 1.2.0 #4714

merged 23 commits into from
Feb 27, 2023

Conversation

daymxn
Copy link
Member

@daymxn daymxn commented Feb 23, 2023

Per b/262894853,

This upgrades the our Dackka version from 1.0.3 to 1.2.0 and changes our DackkaPlugin to accommodate such. With this, comes additional configuration that Dackka has gracefully exposed for us (alongside a plethora of bug fixes):

  • Changing reference paths between Kotlin and Java (b/243674305)
  • Changing reference head tag paths between Kotlin and Java (b/248316730)
  • Removing the google group ID (b/257293594) (although we aren't able to take advantage of this, as it's currently a global setting- see b/270593375)

As such, this PR does the following:

  • Removes our transform for reference paths
  • Removes our transform for reference head tags paths
  • Updates the FiresiteTransform documentation
  • Removes the seperateDackkaFiles task, as it is replaced by Dackka exposing configuration to set output paths between Kotlin and Java
  • Removes the copyJavaDocToCommonDirectory and copyKotlinDocToCommonDirectory tasks, and combines them into a single copyDocsToCommonDirectory (thanks to the removal of the seperateDackkaFiles task)
  • Builds Javadocs in Dackka (thanks to b/243324828)
  • Removes the needing of doc stubs
  • Avoids building Javadocs for -ktx libraries
  • Cleans up the DackkaPlugin code entirely to be more accessible to folks unfamiliar with Kotlin
  • Updates the DackkaPlugin documentation
  • Provides additional documentation for DackkaPlugin methods
  • Removes the need for DEVSITE_TENANT in our Dackka generation (and is set via the new fqPluginName Dackka configuration instead)
  • Updates DackkaGenerationTask to accommodate the changes from 1.0.3 to 1.2.0
  • Updates the DackkaGenerationTask documentation
  • Cleans up the DackkaGenerationTask code entirely to be more accessible to folks unfamiliar with Kotlin
  • Adds a note to FirebaseLibraryExtension about refactoring it into a modernized version that respects newer gradle conventions
  • Refactors some util methods to be more Kotlin idiomatic
  • Adds additional documentation to some util methods
  • Adds a util method to create Attribute types, and set their value; in a more Kotlin friendly way
  • Adds a util method to submit WorkQueues in a more Kotlin friendly way
  • Adds extension properties to Project types that map to FirebaseLibraryExtension, and identify if the module is a -ktx variant
  • Removes the old firesite_transform.sh script
  • Fixes spelling errors in various Javadocs
  • Hides artifacts from doc generation that should've previously been hidden
  • Fixes various Javadocs to conform to existing Dackka bugs
  • Reduces some verbose links to their short-hand variant
  • Adds a package-list file for the AndroidX package

This upgrade was particularly large, because it involved (finally) fully migrating our Javadoc generation out of Metalava and into Dackka. Any future upgrades to Dackka versions should be very small in comparison.

Note that the changes that occur from doc generation in Dackka instead of Metalava are already approved and merged into Firesite.

@daymxn daymxn enabled auto-merge (squash) February 23, 2023 23:55
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject appcheck_firebase-appcheck-interop:
error: Removed class com.google.firebase.appcheck.interop.InternalAppCheckTokenProvider [RemovedInterface]

The public api surface has changed for the subproject firebase-annotations:
error: Removed package com.google.firebase.annotations.concurrent [RemovedPackage]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2023

Unit Test Results

   782 files  +   404     782 suites  +404   34m 49s ⏱️ + 18m 12s
4 804 tests +1 906  4 783 ✔️ +1 901  21 💤 +  5  0 ±0 
9 517 runs  +3 721  9 475 ✔️ +3 711  42 💤 +10  0 ±0 

Results for commit 106ab34. ± Comparison against base commit df07a40.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 24, 2023

Size Report 1

Affected Products

  • firebase-abt

    TypeBase (df07a40)Merge (0e9e151)Diff
    apk (release)1.27 MB1.27 MB-24 B (-0.0%)
  • firebase-appcheck

    TypeBase (df07a40)Merge (0e9e151)Diff
    apk (release)1.56 MB1.56 MB-20 B (-0.0%)
  • firebase-appcheck-debug

    TypeBase (df07a40)Merge (0e9e151)Diff
    aar11.1 kB11.1 kB+3 B (+0.0%)
    apk (release)1.56 MB1.56 MB-112 B (-0.0%)
  • firebase-appcheck-debug-testing

    TypeBase (df07a40)Merge (0e9e151)Diff
    aar7.27 kB7.27 kB-5 B (-0.1%)
    apk (release)1.60 MB1.60 MB-48 B (-0.0%)
  • firebase-appcheck-ktx

    TypeBase (df07a40)Merge (0e9e151)Diff
    apk (release)1.94 MB1.94 MB+24 B (+0.0%)
  • firebase-appcheck-playintegrity

    TypeBase (df07a40)Merge (0e9e151)Diff
    aar11.0 kB11.0 kB-1 B (-0.0%)
    apk (release)1.57 MB1.57 MB-24 B (-0.0%)
  • firebase-appcheck-safetynet

    TypeBase (df07a40)Merge (0e9e151)Diff
    aar10.4 kB10.4 kB+8 B (+0.1%)
    apk (release)1.57 MB1.57 MB-80 B (-0.0%)
  • firebase-appdistribution

    TypeBase (df07a40)Merge (0e9e151)Diff
    apk (release)2.63 MB2.63 MB+48 B (+0.0%)
  • firebase-appdistribution-api

    TypeBase (df07a40)Merge (0e9e151)Diff
    apk (release)1.27 MB1.27 MB-36 B (-0.0%)
  • firebase-appdistribution-api-ktx

    TypeBase (df07a40)Merge (0e9e151)Diff
    apk (release)1.65 MB1.65 MB+12 B (+0.0%)
  • firebase-common

    TypeBase (df07a40)Merge (0e9e151)Diff
    aar67.6 kB67.6 kB+1 B (+0.0%)
    apk (release)1.26 MB1.26 MB-84 B (-0.0%)
  • firebase-common-ktx

    TypeBase (df07a40)Merge (0e9e151)Diff
    apk (release)1.64 MB1.64 MB+128 B (+0.0%)
  • firebase-config

    TypeBase (df07a40)Merge (0e9e151)Diff
    apk (release)1.31 MB1.31 MB-20 B (-0.0%)
  • firebase-config-ktx

    TypeBase (df07a40)Merge (0e9e151)Diff
    apk (release)1.69 MB1.69 MB+152 B (+0.0%)
  • firebase-crashlytics

    TypeBase (df07a40)Merge (0e9e151)Diff
    apk (release)1.47 MB1.47 MB+48 B (+0.0%)
  • firebase-crashlytics-ktx

    TypeBase (df07a40)Merge (0e9e151)Diff
    apk (release)1.86 MB1.86 MB-120 B (-0.0%)
  • firebase-database

    TypeBase (df07a40)Merge (0e9e151)Diff
    aar488 kB488 kB+17 B (+0.0%)
    apk (release)1.72 MB1.72 MB-48 B (-0.0%)
  • firebase-database-ktx

    TypeBase (df07a40)Merge (0e9e151)Diff
    apk (release)2.10 MB2.10 MB-60 B (-0.0%)
  • firebase-datatransport

    TypeBase (df07a40)Merge (0e9e151)Diff
    apk (release)1.35 MB1.35 MB+12 B (+0.0%)
  • firebase-dynamic-links

    TypeBase (df07a40)Merge (0e9e151)Diff
    aar54.6 kB54.6 kB-5 B (-0.0%)
    apk (release)1.56 MB1.56 MB+68 B (+0.0%)
  • firebase-dynamic-links-ktx

    TypeBase (df07a40)Merge (0e9e151)Diff
    apk (release)1.94 MB1.94 MB-120 B (-0.0%)
  • firebase-dynamic-module-support

    TypeBase (df07a40)Merge (0e9e151)Diff
    apk (release)1.31 MB1.31 MB+72 B (+0.0%)
  • firebase-firestore

    TypeBase (df07a40)Merge (0e9e151)Diff
    apk (release)3.93 MB3.93 MB+144 B (+0.0%)
  • firebase-firestore-ktx

    TypeBase (df07a40)Merge (0e9e151)Diff
    apk (release)4.32 MB4.32 MB-8 B (-0.0%)
  • firebase-functions

    TypeBase (df07a40)Merge (0e9e151)Diff
    apk (release)1.81 MB1.81 MB-44 B (-0.0%)
  • firebase-functions-ktx

    TypeBase (df07a40)Merge (0e9e151)Diff
    apk (release)2.19 MB2.19 MB+36 B (+0.0%)
  • firebase-inappmessaging

    TypeBase (df07a40)Merge (0e9e151)Diff
    aar454 kB454 kB+6 B (+0.0%)
    apk (release)3.95 MB3.95 MB+80 B (+0.0%)
  • firebase-inappmessaging-display

    TypeBase (df07a40)Merge (0e9e151)Diff
    apk (release)5.21 MB5.21 MB+20 B (+0.0%)
  • firebase-inappmessaging-display-ktx

    TypeBase (df07a40)Merge (0e9e151)Diff
    apk (release)5.59 MB5.59 MB+28 B (+0.0%)
  • firebase-inappmessaging-ktx

    TypeBase (df07a40)Merge (0e9e151)Diff
    apk (release)4.33 MB4.33 MB+4 B (+0.0%)
  • firebase-installations

    TypeBase (df07a40)Merge (0e9e151)Diff
    apk (release)1.28 MB1.28 MB+28 B (+0.0%)
  • firebase-installations-ktx

    TypeBase (df07a40)Merge (0e9e151)Diff
    apk (release)1.67 MB1.67 MB-16 B (-0.0%)
  • firebase-messaging

    TypeBase (df07a40)Merge (0e9e151)Diff
    apk (release)1.72 MB1.72 MB+108 B (+0.0%)
  • firebase-messaging-directboot

    TypeBase (df07a40)Merge (0e9e151)Diff
    apk (release)1.72 MB1.72 MB+12 B (+0.0%)
  • firebase-messaging-ktx

    TypeBase (df07a40)Merge (0e9e151)Diff
    apk (release)2.10 MB2.10 MB-32 B (-0.0%)
  • firebase-ml-modeldownloader

    TypeBase (df07a40)Merge (0e9e151)Diff
    apk (release)1.41 MB1.41 MB-32 B (-0.0%)
  • firebase-ml-modeldownloader-ktx

    TypeBase (df07a40)Merge (0e9e151)Diff
    apk (release)1.79 MB1.79 MB-12 B (-0.0%)
  • firebase-perf

    TypeBase (df07a40)Merge (0e9e151)Diff
    aar315 kB315 kB+5 B (+0.0%)
    apk (release)3.05 MB3.05 MB-96 B (-0.0%)
  • firebase-perf-ktx

    TypeBase (df07a40)Merge (0e9e151)Diff
    apk (release)3.44 MB3.44 MB+60 B (+0.0%)
  • firebase-storage

    TypeBase (df07a40)Merge (0e9e151)Diff
    apk (release)1.59 MB1.59 MB-8 B (-0.0%)
  • firebase-storage-ktx

    TypeBase (df07a40)Merge (0e9e151)Diff
    apk (release)1.97 MB1.97 MB-108 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/684X2PPWhB.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 24, 2023

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.15% (df07a40) to 50.14% (0e9e151) by -0.01%.

    FilenameBase (df07a40)Merge (0e9e151)Diff
    DefaultPersistenceManager.java74.76%75.73%+0.97%
    DoubleNode.java88.24%100.00%+11.76%
    WebsocketConnection.java35.03%32.77%-2.26%
  • firebase-firestore

    Overall coverage changed from ? (df07a40) to 44.14% (0e9e151) by ?.

    315 individual files with coverage change

    FilenameBase (df07a40)Merge (0e9e151)Diff
    AbstractStream.java?34.81%?
    ActivityScope.java?0.00%?
    AggregateQuery.java?15.00%?
    AggregateQuerySnapshot.java?0.00%?
    AggregateSource.java?0.00%?
    AggregationResult.java?0.00%?
    AggregationResultOrBuilder.java?0.00%?
    AggregationResultProto.java?0.00%?
    AndroidConnectivityMonitor.java?39.51%?
    ApiUtil.java?12.50%?
    ArrayContainsAnyFilter.java?100.00%?
    ArrayContainsFilter.java?100.00%?
    ArrayTransformOperation.java?86.49%?
    ArrayValue.java?48.60%?
    ArrayValueOrBuilder.java?0.00%?
    Assert.java?60.00%?
    AsyncEventListener.java?0.00%?
    AsyncQueue.java?70.65%?
    AutoValue_FieldIndex.java?58.33%?
    AutoValue_FieldIndex_IndexOffset.java?58.62%?
    AutoValue_FieldIndex_IndexState.java?59.09%?
    AutoValue_FieldIndex_Segment.java?54.17%?
    AutoValue_IndexEntry.java?34.21%?
    AutoValue_Overlay.java?54.55%?
    BackgroundQueue.java?81.25%?
    BasePath.java?86.54%?
    BatchGetDocumentsRequest.java?0.00%?
    BatchGetDocumentsRequestOrBuilder.java?0.00%?
    BatchGetDocumentsResponse.java?0.00%?
    BatchGetDocumentsResponseOrBuilder.java?0.00%?
    BeginTransactionRequest.java?0.00%?
    BeginTransactionRequestOrBuilder.java?0.00%?
    BeginTransactionResponse.java?0.00%?
    BeginTransactionResponseOrBuilder.java?0.00%?
    Blob.java?76.92%?
    Bound.java?39.29%?
    BundleCache.java?0.00%?
    BundleCallback.java?0.00%?
    BundledDocumentMetadata.java?0.00%?
    BundledDocumentMetadataOrBuilder.java?0.00%?
    BundleDocument.java?90.00%?
    BundledQuery.java?34.57%?
    BundledQueryOrBuilder.java?0.00%?
    BundleElement.java?0.00%?
    BundleElementOrBuilder.java?0.00%?
    BundleLoader.java?100.00%?
    BundleMetadata.java?0.00%?
    BundleMetadataOrBuilder.java?0.00%?
    BundleProto.java?0.00%?
    BundleReader.java?95.29%?
    BundleSerializer.java?89.47%?
    ByteBufferInputStream.java?83.33%?
    CollectionReference.java?13.64%?
    CommitRequest.java?0.00%?
    CommitRequestOrBuilder.java?0.00%?
    CommitResponse.java?0.00%?
    CommitResponseOrBuilder.java?0.00%?
    CommonProto.java?0.00%?
    ComponentProvider.java?100.00%?
    CompositeFilter.java?98.57%?
    ConnectivityMonitor.java?0.00%?
    Consumer.java?0.00%?
    CreateDocumentRequest.java?0.00%?
    CreateDocumentRequestOrBuilder.java?0.00%?
    CredentialsProvider.java?100.00%?
    Cursor.java?35.29%?
    CursorOrBuilder.java?0.00%?
    CustomClassMapper.java?84.25%?
    DatabaseId.java?70.37%?
    DatabaseInfo.java?90.91%?
    Datastore.java?23.28%?
    DatastoreTestTrace.java?0.00%?
    DeleteDocumentRequest.java?0.00%?
    DeleteDocumentRequestOrBuilder.java?0.00%?
    DeleteMutation.java?95.24%?
    DirectionalIndexByteEncoder.java?100.00%?
    Document.java?100.00%?
    DocumentChange.java?67.61%?
    DocumentChangeOrBuilder.java?0.00%?
    DocumentCollections.java?83.33%?
    DocumentDelete.java?34.62%?
    DocumentDeleteOrBuilder.java?0.00%?
    DocumentId.java?0.00%?
    DocumentKey.java?97.14%?
    DocumentMask.java?40.66%?
    DocumentMaskOrBuilder.java?0.00%?
    DocumentOrBuilder.java?0.00%?
    DocumentOverlayCache.java?0.00%?
    DocumentProto.java?0.00%?
    DocumentReference.java?13.24%?
    DocumentRemove.java?29.23%?
    DocumentRemoveOrBuilder.java?0.00%?
    DocumentSet.java?83.78%?
    DocumentSnapshot.java?37.50%?
    DocumentTransform.java?29.31%?
    DocumentTransformOrBuilder.java?0.00%?
    DocumentViewChange.java?90.91%?
    DocumentViewChangeSet.java?87.88%?
    EncodedPath.java?93.22%?
    EventListener.java?0.00%?
    EventManager.java?96.15%?
    Exclude.java?0.00%?
    Executors.java?100.00%?
    ExistenceFilter.java?80.00%?
    ExistenceFilterOrBuilder.java?0.00%?
    ExponentialBackoff.java?30.43%?
    FieldFilter.java?93.06%?
    FieldIndex.java?98.18%?
    FieldMask.java?57.89%?
    FieldPath.java?89.66%?
    FieldTransform.java?64.71%?
    FieldValue.java?82.14%?
    FileUtil.java?0.00%?
    Filter.java?0.00%?
    FirebaseAppCheckTokenProvider.java?93.75%?
    FirebaseAuthCredentialsProvider.java?100.00%?
    FirebaseClientGrpcMetadataProvider.java?44.00%?
    FirebaseFirestore.java?36.67%?
    FirebaseFirestoreException.java?83.72%?
    FirebaseFirestoreSettings.java?75.00%?
    FirestoreCallCredentials.java?18.60%?
    FirestoreChannel.java?18.10%?
    FirestoreClient.java?36.11%?
    FirestoreGrpc.java?2.46%?
    FirestoreIndexValueWriter.java?77.11%?
    FirestoreMultiDbComponent.java?100.00%?
    FirestoreProto.java?0.00%?
    FirestoreRegistrar.java?100.00%?
    Function.java?0.00%?
    GeoPoint.java?91.67%?
    GetDocumentRequest.java?0.00%?
    GetDocumentRequestOrBuilder.java?0.00%?
    GrpcCallProvider.java?69.41%?
    GrpcMetadataProvider.java?0.00%?
    IgnoreExtraProperties.java?0.00%?
    IncomingStreamObserver.java?0.00%?
    Index.java?30.02%?
    IndexBackfiller.java?100.00%?
    IndexByteEncoder.java?88.57%?
    IndexEntry.java?100.00%?
    IndexManager.java?100.00%?
    IndexOrBuilder.java?0.00%?
    IndexProto.java?0.00%?
    InFilter.java?100.00%?
    IntMath.java?41.67%?
    KeyFieldFilter.java?66.67%?
    KeyFieldInFilter.java?0.00%?
    KeyFieldNotInFilter.java?0.00%?
    LimboDocumentChange.java?70.59%?
    ListCollectionIdsRequest.java?0.00%?
    ListCollectionIdsRequestOrBuilder.java?0.00%?
    ListCollectionIdsResponse.java?0.00%?
    ListCollectionIdsResponseOrBuilder.java?0.00%?
    ListDocumentsRequest.java?0.00%?
    ListDocumentsRequestOrBuilder.java?0.00%?
    ListDocumentsResponse.java?0.00%?
    ListDocumentsResponseOrBuilder.java?0.00%?
    Listener.java?0.00%?
    ListenerRegistration.java?0.00%?
    ListenerRegistrationImpl.java?0.00%?
    ListenRequest.java?10.66%?
    ListenRequestOrBuilder.java?0.00%?
    ListenResponse.java?32.64%?
    ListenResponseOrBuilder.java?0.00%?
    ListenSequence.java?100.00%?
    LoadBundleTask.java?25.26%?
    LoadBundleTaskProgress.java?60.47%?
    LocalDocumentsResult.java?100.00%?
    LocalDocumentsView.java?100.00%?
    LocalSerializer.java?97.35%?
    LocalStore.java?100.00%?
    LocalViewChanges.java?100.00%?
    Logger.java?75.00%?
    LogicUtils.java?96.67%?
    LruDelegate.java?0.00%?
    LruGarbageCollector.java?97.20%?
    MapValue.java?53.00%?
    MapValueOrBuilder.java?0.00%?
    MemoryBundleCache.java?100.00%?
    MemoryComponentProvider.java?100.00%?
    MemoryDocumentOverlayCache.java?100.00%?
    MemoryEagerReferenceDelegate.java?100.00%?
    MemoryIndexManager.java?68.97%?
    MemoryLruReferenceDelegate.java?96.00%?
    MemoryMutationQueue.java?98.57%?
    MemoryOverlayMigrationManager.java?100.00%?
    MemoryPersistence.java?100.00%?
    MemoryRemoteDocumentCache.java?98.28%?
    MemoryTargetCache.java?100.00%?
    MetadataChanges.java?100.00%?
    MutableDocument.java?100.00%?
    Mutation.java?100.00%?
    MutationBatch.java?89.23%?
    MutationBatchResult.java?100.00%?
    MutationQueue.java?0.00%?
    MutationResult.java?100.00%?
    NamedQuery.java?0.00%?
    NamedQueryOrBuilder.java?0.00%?
    NotInFilter.java?85.71%?
    NumberComparisonHelper.java?100.00%?
    NumericIncrementTransformOperation.java?87.50%?
    ObjectValue.java?99.06%?
    OnlineState.java?100.00%?
    OnlineStateTracker.java?98.11%?
    OnProgressListener.java?0.00%?
    OrderBy.java?96.55%?
    OrderedCodeWriter.java?68.52%?
    Overlay.java?100.00%?
    OverlayedDocument.java?100.00%?
    OverlayMigrationManager.java?0.00%?
    PatchMutation.java?98.39%?
    Persistence.java?100.00%?
    Precondition.java?37.82%?
    PreconditionOrBuilder.java?0.00%?
    Preconditions.java?57.89%?
    PropertyName.java?0.00%?
    Query.java?4.04%?
    QueryDocumentSnapshot.java?64.71%?
    QueryEngine.java?98.63%?
    QueryListener.java?100.00%?
    QueryProto.java?0.00%?
    QueryPurpose.java?100.00%?
    QueryResult.java?100.00%?
    QuerySnapshot.java?76.36%?
    QueryView.java?100.00%?
    ReferenceDelegate.java?0.00%?
    ReferenceSet.java?92.45%?
    RemoteDocumentCache.java?0.00%?
    RemoteEvent.java?92.31%?
    RemoteSerializer.java?84.63%?
    RemoteStore.java?88.49%?
    ResourcePath.java?94.74%?
    RollbackRequest.java?0.00%?
    RollbackRequestOrBuilder.java?0.00%?
    RunAggregationQueryRequest.java?0.00%?
    RunAggregationQueryRequestOrBuilder.java?0.00%?
    RunAggregationQueryResponse.java?0.00%?
    RunAggregationQueryResponseOrBuilder.java?0.00%?
    RunQueryRequest.java?0.00%?
    RunQueryRequestOrBuilder.java?0.00%?
    RunQueryResponse.java?0.00%?
    RunQueryResponseOrBuilder.java?0.00%?
    Scheduler.java?0.00%?
    ServerTimestamp.java?0.00%?
    ServerTimestampOperation.java?100.00%?
    ServerTimestamps.java?79.17%?
    SetMutation.java?94.44%?
    SetOptions.java?0.00%?
    SnapshotMetadata.java?68.75%?
    SnapshotVersion.java?87.50%?
    Source.java?0.00%?
    SQLiteBundleCache.java?90.00%?
    SQLiteComponentProvider.java?100.00%?
    SQLiteDocumentOverlayCache.java?97.85%?
    SQLiteIndexManager.java?99.49%?
    SQLiteLruReferenceDelegate.java?98.67%?
    SQLiteMutationQueue.java?82.76%?
    SQLiteOverlayMigrationManager.java?90.48%?
    SQLitePersistence.java?86.34%?
    SQLiteRemoteDocumentCache.java?98.21%?
    SQLiteSchema.java?96.63%?
    SQLiteTargetCache.java?98.47%?
    Stream.java?100.00%?
    StructuredAggregationQuery.java?0.00%?
    StructuredAggregationQueryOrBuilder.java?0.00%?
    StructuredQuery.java?32.54%?
    StructuredQueryOrBuilder.java?0.00%?
    Supplier.java?0.00%?
    SyncEngine.java?93.31%?
    Target.java?95.79%?
    TargetCache.java?0.00%?
    TargetChange.java?80.00%?
    TargetChangeOrBuilder.java?0.00%?
    TargetData.java?77.50%?
    TargetIdGenerator.java?100.00%?
    TargetIndexMatcher.java?100.00%?
    TargetOrBuilder.java?0.00%?
    TargetState.java?97.78%?
    ThrottledForwardingExecutor.java?100.00%?
    ThrowOnExtraProperties.java?0.00%?
    Timestamp.java?80.39%?
    Token.java?0.00%?
    Transaction.java?0.00%?
    TransactionOptions.java?0.00%?
    TransactionOptionsOrBuilder.java?0.00%?
    TransactionRunner.java?0.00%?
    TransformOperation.java?0.00%?
    UpdateDocumentRequest.java?0.00%?
    UpdateDocumentRequestOrBuilder.java?0.00%?
    User.java?78.57%?
    UserData.java?66.00%?
    UserDataReader.java?70.48%?
    UserDataWriter.java?51.02%?
    Util.java?67.63%?
    Value.java?40.97%?
    ValueOrBuilder.java?0.00%?
    Values.java?95.65%?
    VerifyMutation.java?46.15%?
    View.java?96.82%?
    ViewChange.java?100.00%?
    ViewSnapshot.java?89.23%?
    WatchChange.java?70.51%?
    WatchChangeAggregator.java?98.21%?
    WatchStream.java?19.23%?
    Write.java?36.11%?
    WriteBatch.java?0.00%?
    WriteOrBuilder.java?0.00%?
    WriteProto.java?0.00%?
    WriteRequest.java?10.41%?
    WriteRequestOrBuilder.java?0.00%?
    WriteResponse.java?11.70%?
    WriteResponseOrBuilder.java?0.00%?
    WriteResult.java?0.00%?
    WriteResultOrBuilder.java?0.00%?
    WriteStream.java?31.82%?

  • firebase-messaging

    Overall coverage changed from 85.33% (df07a40) to 85.18% (0e9e151) by -0.15%.

    FilenameBase (df07a40)Merge (0e9e151)Diff
    FirebaseMessaging.java76.21%75.77%-0.44%
    Metadata.java61.90%57.14%-4.76%
  • firebase-storage

    Overall coverage changed from 85.95% (df07a40) to 85.86% (0e9e151) by -0.09%.

    FilenameBase (df07a40)Merge (0e9e151)Diff
    StorageException.java69.09%65.45%-3.64%
    StorageTask.java83.69%83.38%-0.30%
    UploadTask.java81.46%81.79%+0.33%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/AzuW6PhLV3.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 24, 2023

Startup Time Report 1

The report is too large (117,054 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ZnAop9Kamo/index.html

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject appcheck_firebase-appcheck-interop:
error: Removed class com.google.firebase.appcheck.interop.InternalAppCheckTokenProvider [RemovedInterface]

The public api surface has changed for the subproject firebase-annotations:
error: Removed class com.google.firebase.annotations.concurrent.Blocking [RemovedClass]
error: Removed class com.google.firebase.annotations.concurrent.Lightweight [RemovedClass]
error: Removed class com.google.firebase.annotations.concurrent.UiThread [RemovedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2023

buildSrc Test Results

18 tests   18 ✔️  1m 32s ⏱️
  4 suites    0 💤
  4 files      0

Results for commit 106ab34.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject appcheck_firebase-appcheck-interop:
error: Removed class com.google.firebase.appcheck.interop.InternalAppCheckTokenProvider [RemovedInterface]

The public api surface has changed for the subproject firebase-annotations:
error: Removed class com.google.firebase.annotations.concurrent.Blocking [RemovedClass]
error: Removed class com.google.firebase.annotations.concurrent.Lightweight [RemovedClass]
error: Removed class com.google.firebase.annotations.concurrent.UiThread [RemovedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

7 similar comments
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject appcheck_firebase-appcheck-interop:
error: Removed class com.google.firebase.appcheck.interop.InternalAppCheckTokenProvider [RemovedInterface]

The public api surface has changed for the subproject firebase-annotations:
error: Removed class com.google.firebase.annotations.concurrent.Blocking [RemovedClass]
error: Removed class com.google.firebase.annotations.concurrent.Lightweight [RemovedClass]
error: Removed class com.google.firebase.annotations.concurrent.UiThread [RemovedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject appcheck_firebase-appcheck-interop:
error: Removed class com.google.firebase.appcheck.interop.InternalAppCheckTokenProvider [RemovedInterface]

The public api surface has changed for the subproject firebase-annotations:
error: Removed class com.google.firebase.annotations.concurrent.Blocking [RemovedClass]
error: Removed class com.google.firebase.annotations.concurrent.Lightweight [RemovedClass]
error: Removed class com.google.firebase.annotations.concurrent.UiThread [RemovedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject appcheck_firebase-appcheck-interop:
error: Removed class com.google.firebase.appcheck.interop.InternalAppCheckTokenProvider [RemovedInterface]

The public api surface has changed for the subproject firebase-annotations:
error: Removed class com.google.firebase.annotations.concurrent.Blocking [RemovedClass]
error: Removed class com.google.firebase.annotations.concurrent.Lightweight [RemovedClass]
error: Removed class com.google.firebase.annotations.concurrent.UiThread [RemovedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject appcheck_firebase-appcheck-interop:
error: Removed class com.google.firebase.appcheck.interop.InternalAppCheckTokenProvider [RemovedInterface]

The public api surface has changed for the subproject firebase-annotations:
error: Removed class com.google.firebase.annotations.concurrent.Blocking [RemovedClass]
error: Removed class com.google.firebase.annotations.concurrent.Lightweight [RemovedClass]
error: Removed class com.google.firebase.annotations.concurrent.UiThread [RemovedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject appcheck_firebase-appcheck-interop:
error: Removed class com.google.firebase.appcheck.interop.InternalAppCheckTokenProvider [RemovedInterface]

The public api surface has changed for the subproject firebase-annotations:
error: Removed class com.google.firebase.annotations.concurrent.Blocking [RemovedClass]
error: Removed class com.google.firebase.annotations.concurrent.Lightweight [RemovedClass]
error: Removed class com.google.firebase.annotations.concurrent.UiThread [RemovedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject appcheck_firebase-appcheck-interop:
error: Removed class com.google.firebase.appcheck.interop.InternalAppCheckTokenProvider [RemovedInterface]

The public api surface has changed for the subproject firebase-annotations:
error: Removed class com.google.firebase.annotations.concurrent.Blocking [RemovedClass]
error: Removed class com.google.firebase.annotations.concurrent.Lightweight [RemovedClass]
error: Removed class com.google.firebase.annotations.concurrent.UiThread [RemovedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject appcheck_firebase-appcheck-interop:
error: Removed class com.google.firebase.appcheck.interop.InternalAppCheckTokenProvider [RemovedInterface]

The public api surface has changed for the subproject firebase-annotations:
error: Removed class com.google.firebase.annotations.concurrent.Blocking [RemovedClass]
error: Removed class com.google.firebase.annotations.concurrent.Lightweight [RemovedClass]
error: Removed class com.google.firebase.annotations.concurrent.UiThread [RemovedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@daymxn daymxn force-pushed the daymon-update-dackka-1.0.5 branch from 9d4e5cc to 3548a9f Compare February 25, 2023 18:02
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject appcheck_firebase-appcheck-interop:
error: Removed class com.google.firebase.appcheck.interop.InternalAppCheckTokenProvider [RemovedInterface]

The public api surface has changed for the subproject firebase-annotations:
error: Removed class com.google.firebase.annotations.concurrent.Blocking [RemovedClass]
error: Removed class com.google.firebase.annotations.concurrent.Lightweight [RemovedClass]
error: Removed class com.google.firebase.annotations.concurrent.UiThread [RemovedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@daymxn daymxn requested a review from rlazo February 25, 2023 21:32
@daymxn daymxn merged commit bb62df1 into master Feb 27, 2023
@daymxn daymxn deleted the daymon-update-dackka-1.0.5 branch February 27, 2023 17:26
davidmotson pushed a commit that referenced this pull request Feb 28, 2023
@firebase firebase locked and limited conversation to collaborators Mar 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants