-
Notifications
You must be signed in to change notification settings - Fork 624
Update DackkaPlugin to use 1.2.0 #4714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The public api surface has changed for the subproject appcheck_firebase-appcheck-interop: The public api surface has changed for the subproject firebase-annotations: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
Size Report 1Affected Products
Test Logs |
Coverage Report 1Affected Products
Test Logs |
firebase-annotations/src/main/java/com/google/firebase/annotations/concurrent/Background.java
Outdated
Show resolved
Hide resolved
firebase-perf/src/main/java/com/google/firebase/perf/application/AppStateUpdateHandler.java
Show resolved
Hide resolved
The public api surface has changed for the subproject appcheck_firebase-appcheck-interop: The public api surface has changed for the subproject firebase-annotations: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
The public api surface has changed for the subproject appcheck_firebase-appcheck-interop: The public api surface has changed for the subproject firebase-annotations: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
7 similar comments
The public api surface has changed for the subproject appcheck_firebase-appcheck-interop: The public api surface has changed for the subproject firebase-annotations: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
The public api surface has changed for the subproject appcheck_firebase-appcheck-interop: The public api surface has changed for the subproject firebase-annotations: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
The public api surface has changed for the subproject appcheck_firebase-appcheck-interop: The public api surface has changed for the subproject firebase-annotations: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
The public api surface has changed for the subproject appcheck_firebase-appcheck-interop: The public api surface has changed for the subproject firebase-annotations: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
The public api surface has changed for the subproject appcheck_firebase-appcheck-interop: The public api surface has changed for the subproject firebase-annotations: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
The public api surface has changed for the subproject appcheck_firebase-appcheck-interop: The public api surface has changed for the subproject firebase-annotations: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
The public api surface has changed for the subproject appcheck_firebase-appcheck-interop: The public api surface has changed for the subproject firebase-annotations: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
9d4e5cc
to
3548a9f
Compare
The public api surface has changed for the subproject appcheck_firebase-appcheck-interop: The public api surface has changed for the subproject firebase-annotations: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
Per b/262894853,
This upgrades the our Dackka version from
1.0.3
to1.2.0
and changes ourDackkaPlugin
to accommodate such. With this, comes additional configuration that Dackka has gracefully exposed for us (alongside a plethora of bug fixes):As such, this PR does the following:
FiresiteTransform
documentationseperateDackkaFiles
task, as it is replaced by Dackka exposing configuration to set output paths between Kotlin and JavacopyJavaDocToCommonDirectory
andcopyKotlinDocToCommonDirectory
tasks, and combines them into a singlecopyDocsToCommonDirectory
(thanks to the removal of theseperateDackkaFiles
task)-ktx
librariesDackkaPlugin
code entirely to be more accessible to folks unfamiliar with KotlinDackkaPlugin
documentationDEVSITE_TENANT
in our Dackka generation (and is set via the newfqPluginName
Dackka configuration instead)DackkaGenerationTask
to accommodate the changes from1.0.3
to1.2.0
DackkaGenerationTask
documentationDackkaGenerationTask
code entirely to be more accessible to folks unfamiliar with KotlinFirebaseLibraryExtension
about refactoring it into a modernized version that respects newer gradle conventionsAttribute
types, and set their value; in a more Kotlin friendly wayProject
types that map toFirebaseLibraryExtension
, and identify if the module is a-ktx
variantfiresite_transform.sh
scriptpackage-list
file for theAndroidX
packageThis upgrade was particularly large, because it involved (finally) fully migrating our Javadoc generation out of Metalava and into Dackka. Any future upgrades to Dackka versions should be very small in comparison.