Support Sum/Avg in Android SDK #4735

cherylEnkidu · 2023-03-02T02:17:12Z

No description provided.

github-actions · 2023-03-02T02:17:26Z

Javadoc Changes:

--- /Users/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/firestore/AggregateQuery.html	2023-03-31 20:10:43.000000000 +0000
+++ /Users/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/firestore/AggregateQuery.html	2023-03-31 20:06:05.000000000 +0000
@@ -27,7 +27,7 @@
         </thead>
         <tbody class="list">
           <tr>
-            <td><code>final <a href="/docs/reference/android/com/google/firebase/firestore/Query.html">Query</a></code></td>
+            <td><code>final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/firestore/Query.html">Query</a></code></td>
             <td>
               <div><code><a href="/docs/reference/android/com/google/firebase/firestore/AggregateQuery.html#query()">query</a></code></div>
             </td>
@@ -82,7 +82,7 @@
       <h2>Public fields</h2>
       <div class="api-item"><a name="getQuery()"></a><a name="setQuery()"></a><a name="getQuery--"></a><a name="setQuery--"></a>
         <h3 class="api-name" id="query()">query</h3>
-        <pre class="api-signature no-pretty-print">public&nbsp;final&nbsp;<a href="/docs/reference/android/com/google/firebase/firestore/Query.html">Query</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/firestore/AggregateQuery.html#query()">query</a></pre>
+        <pre class="api-signature no-pretty-print">public&nbsp;final&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/firestore/Query.html">Query</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/firestore/AggregateQuery.html#query()">query</a></pre>
       </div>
     </div>
     <div class="list">

--- /Users/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/firestore/AggregateQuerySnapshot.html	2023-03-31 20:10:43.000000000 +0000
+++ /Users/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/firestore/AggregateQuerySnapshot.html	2023-03-31 20:06:05.000000000 +0000
@@ -27,15 +27,9 @@
         </thead>
         <tbody class="list">
           <tr>
-            <td><code>final long</code></td>
-            <td>
-              <div><code><a href="/docs/reference/android/com/google/firebase/firestore/AggregateQuerySnapshot.html#count()">count</a></code></div>
-            </td>
-          </tr>
-          <tr>
             <td><code>final <a href="/docs/reference/android/com/google/firebase/firestore/AggregateQuery.html">AggregateQuery</a></code></td>
             <td>
-              <div><code><a href="/docs/reference/android/com/google/firebase/firestore/AggregateQuerySnapshot.html#query()">query</a></code></div>
+              <div><code>@<a href="/docs/reference/android/javax/annotation/Nonnull.html">Nonnull</a><br><a href="/docs/reference/android/com/google/firebase/firestore/AggregateQuerySnapshot.html#query()">query</a></code></div>
             </td>
           </tr>
         </tbody>
@@ -86,13 +80,9 @@
     </div>
     <div class="list">
       <h2>Public fields</h2>
-      <div class="api-item"><a name="getCount()"></a><a name="setCount()"></a><a name="getCount--"></a><a name="setCount--"></a>
-        <h3 class="api-name" id="count()">count</h3>
-        <pre class="api-signature no-pretty-print">public&nbsp;final&nbsp;long&nbsp;<a href="/docs/reference/android/com/google/firebase/firestore/AggregateQuerySnapshot.html#count()">count</a></pre>
-      </div>
       <div class="api-item"><a name="getQuery()"></a><a name="setQuery()"></a><a name="getQuery--"></a><a name="setQuery--"></a>
         <h3 class="api-name" id="query()">query</h3>
-        <pre class="api-signature no-pretty-print">public&nbsp;final&nbsp;<a href="/docs/reference/android/com/google/firebase/firestore/AggregateQuery.html">AggregateQuery</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/firestore/AggregateQuerySnapshot.html#query()">query</a></pre>
+        <pre class="api-signature no-pretty-print">@<a href="/docs/reference/android/javax/annotation/Nonnull.html">Nonnull</a><br>public&nbsp;final&nbsp;<a href="/docs/reference/android/com/google/firebase/firestore/AggregateQuery.html">AggregateQuery</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/firestore/AggregateQuerySnapshot.html#query()">query</a></pre>
       </div>
     </div>
     <div class="list">

--- /Users/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/firestore/Query.html	2023-03-31 20:10:43.000000000 +0000
+++ /Users/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/firestore/Query.html	2023-03-31 20:06:05.000000000 +0000
@@ -779,7 +779,7 @@
               <tr>
                 <td><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/firestore/AggregateQuery.html">AggregateQuery</a></code></td>
                 <td>
-                  <p>a query that counts the documents in the result set of this query.</p>
+                  <p>The <code>AggregateQuery</code> that counts the documents in the result set of this query.</p>
                 </td>
               </tr>
             </tbody>

--- /Users/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/firestore/AggregateQuery.html	2023-03-31 20:10:42.000000000 +0000
+++ /Users/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/firestore/AggregateQuery.html	2023-03-31 20:06:05.000000000 +0000
@@ -63,7 +63,7 @@
         </thead>
         <tbody class="list">
           <tr>
-            <td><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/Query.html">Query</a>!</code></td>
+            <td><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/Query.html">Query</a></code></td>
             <td>
               <div><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/AggregateQuery.html#query()">query</a></code></div>
             </td>
@@ -205,7 +205,7 @@
       <h2>Public properties</h2>
       <div class="api-item"><a name="getQuery()"></a><a name="setQuery()"></a><a name="getQuery--"></a><a name="setQuery--"></a>
         <h3 class="api-name" id="query()">query</h3>
-        <pre class="api-signature no-pretty-print">val&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/AggregateQuery.html#query()">query</a>:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/Query.html">Query</a>!</pre>
+        <pre class="api-signature no-pretty-print">val&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/AggregateQuery.html#query()">query</a>:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/Query.html">Query</a></pre>
       </div>
     </div>
   </body>

--- /Users/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/firestore/AggregateQuerySnapshot.html	2023-03-31 20:10:42.000000000 +0000
+++ /Users/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/firestore/AggregateQuerySnapshot.html	2023-03-31 20:06:05.000000000 +0000
@@ -34,6 +34,13 @@
             </td>
           </tr>
           <tr>
+            <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-long/index.html">Long</a></code></td>
+            <td>
+              <div><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/AggregateQuerySnapshot.html#getCount()">getCount</a>()</code></div>
+              <p>Returns the number of documents in the result set of the underlying query.</p>
+            </td>
+          </tr>
+          <tr>
             <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-int/index.html">Int</a></code></td>
             <td>
               <div><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/AggregateQuerySnapshot.html#hashCode()">hashCode</a>()</code></div>
@@ -56,15 +63,9 @@
         </thead>
         <tbody class="list">
           <tr>
-            <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-long/index.html">Long</a></code></td>
-            <td>
-              <div><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/AggregateQuerySnapshot.html#count()">count</a></code></div>
-            </td>
-          </tr>
-          <tr>
             <td><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/AggregateQuery.html">AggregateQuery</a>!</code></td>
             <td>
-              <div><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/AggregateQuerySnapshot.html#query()">query</a></code></div>
+              <div><code>@<a href="/docs/reference/kotlin/javax/annotation/Nonnull.html">Nonnull</a><br><a href="/docs/reference/kotlin/com/google/firebase/firestore/AggregateQuerySnapshot.html#query()">query</a></code></div>
             </td>
           </tr>
         </tbody>
@@ -126,6 +127,11 @@
           </table>
         </div>
       </div>
+      <div class="api-item"><a name="getCount--"></a><a name="getcount"></a>
+        <h3 class="api-name" id="getCount()">getCount</h3>
+        <pre class="api-signature no-pretty-print">fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/AggregateQuerySnapshot.html#getCount()">getCount</a>():&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-long/index.html">Long</a></pre>
+        <p>Returns the number of documents in the result set of the underlying query.</p>
+      </div>
       <div class="api-item"><a name="hashCode--"></a><a name="hashcode"></a>
         <h3 class="api-name" id="hashCode()">hashCode</h3>
         <pre class="api-signature no-pretty-print">fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/AggregateQuerySnapshot.html#hashCode()">hashCode</a>():&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-int/index.html">Int</a></pre>
@@ -155,13 +161,9 @@
     </div>
     <div class="list">
       <h2>Public properties</h2>
-      <div class="api-item"><a name="getCount()"></a><a name="setCount()"></a><a name="getCount--"></a><a name="setCount--"></a>
-        <h3 class="api-name" id="count()">count</h3>
-        <pre class="api-signature no-pretty-print">val&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/AggregateQuerySnapshot.html#count()">count</a>:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-long/index.html">Long</a></pre>
-      </div>
       <div class="api-item"><a name="getQuery()"></a><a name="setQuery()"></a><a name="getQuery--"></a><a name="setQuery--"></a>
         <h3 class="api-name" id="query()">query</h3>
-        <pre class="api-signature no-pretty-print">val&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/AggregateQuerySnapshot.html#query()">query</a>:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/AggregateQuery.html">AggregateQuery</a>!</pre>
+        <pre class="api-signature no-pretty-print">@<a href="/docs/reference/kotlin/javax/annotation/Nonnull.html">Nonnull</a><br>val&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/AggregateQuerySnapshot.html#query()">query</a>:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/AggregateQuery.html">AggregateQuery</a>!</pre>
       </div>
     </div>
   </body>

--- /Users/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/firestore/Query.html	2023-03-31 20:10:42.000000000 +0000
+++ /Users/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/firestore/Query.html	2023-03-31 20:06:05.000000000 +0000
@@ -765,7 +765,7 @@
               <tr>
                 <td><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/AggregateQuery.html">AggregateQuery</a></code></td>
                 <td>
-                  <p>a query that counts the documents in the result set of this query.</p>
+                  <p>The <code>AggregateQuery</code> that counts the documents in the result set of this query.</p>
                 </td>
               </tr>
             </tbody>

google-oss-bot · 2023-03-02T02:24:53Z

Coverage Report ¹

Affected Products

`firebase-firestore`

Overall coverage changed from 44.17% (b68c1f6) to 44.06% (212f529) by -0.11%.

Filename	Base (`b68c1f6`)	Merge (`212f529`)	Diff
AggregateField.java	?	27.59%	?
AggregateQuery.java	15.00%	18.18%	+3.18%
Datastore.java	23.28%	26.47%	+3.19%
LocalStore.java	100.00%	99.39%	-0.61%
LruGarbageCollector.java	97.20%	93.46%	-3.74%
Query.java	4.04%	3.96%	-0.08%
RemoteSerializer.java	84.63%	80.57%	-4.07%

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/dSRZh6MpM3.html

github-actions · 2023-03-02T02:26:28Z

Unit Test Results

  158 files -   616   158 suites - 616 1m 59s ⏱️ - 31m 31s
1 117 tests - 3 736 1 101 ✔️ - 3 731 16 💤 -   5 0 ❌ ±0
2 234 runs - 7 269 2 202 ✔️ - 7 259 32 💤 - 10 0 ❌ ±0

Results for commit 9991a9a. ± Comparison against base commit b68c1f6.

♻️ This comment has been updated with latest results.

google-oss-bot · 2023-03-02T02:31:37Z

Size Report ¹

Affected Products

firebase-firestore
Type Base (b68c1f6) Merge (212f529) Diff
aar 1.32 MB 1.33 MB +6.70 kB (+0.5%)
apk (release) 3.94 MB 3.94 MB +1.84 kB (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/rNdJnIsiwg.html

google-oss-bot · 2023-03-02T03:03:38Z

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

This report is for comparing the base commit (b68c1f6) and the CI merge commit (212f529)
Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
- b68c1f6: https://storage.googleapis.com/firebase-sdk-metric-reports/aSJHqLmqzh/index.html
- 212f529: https://storage.googleapis.com/firebase-sdk-metric-reports/klYMERu5Yy/index.html

Startup Times

`fire-fst`

Device Statistics Distributions

oriole-32

Percentile	`b68c1f6`	`212f529`	Diff	Significant (?)
p10	343 ±42 μs	331 ±27 μs	-12.1 μs (-3.5%)	NO
p25	361 ±65 μs	346 ±32 μs	-16.0 μs (-4.4%)	NO
p50	397 ±95 μs	383 ±62 μs	-14.0 μs (-3.5%)	NO
p75	454 ±165 μs	461 ±122 μs	+6.85 μs (+1.5%)	NO
p90	535 ±251 μs	544 ±173 μs	+8.48 μs (+1.6%)	NO

20 test runs in comparison

Commit	Test Runs
`b68c1f6`	2023-03-31_18:02:27.817560_QdxD 2023-03-31_18:02:27.824440_RGSH 2023-03-31_18:02:27.824462_gQSV 2023-03-31_18:02:27.824468_Utlb 2023-03-31_18:02:27.824475_VoHT 2023-03-31_18:02:27.824480_mlCO 2023-03-31_18:02:27.824486_AWDd 2023-03-31_18:02:27.824491_UGfJ 2023-03-31_18:02:27.824496_aEgs 2023-03-31_18:02:27.824502_fIQv
`212f529`	2023-03-31_20:17:49.742686_PyBn 2023-03-31_20:17:49.743384_zZmV 2023-03-31_20:17:49.743394_qMPg 2023-03-31_20:17:49.743400_DGGM 2023-03-31_20:17:49.743405_nasO 2023-03-31_20:17:49.743411_aCTS 2023-03-31_20:17:49.743417_MNhy 2023-03-31_20:17:49.743422_Zmrm 2023-03-31_20:17:49.743427_zDKw 2023-03-31_20:17:49.743433_MnFY

redfin-30

Percentile	`b68c1f6`	`212f529`	Diff	Significant (?)
p10	638 ±38 μs	656 ±32 μs	+17.7 μs (+2.8%)	NO
p25	653 ±41 μs	676 ±36 μs	+22.3 μs (+3.4%)	NO
p50	677 ±46 μs	708 ±47 μs	+30.9 μs (+4.6%)	NO
p75	707 ±60 μs	751 ±63 μs	+44.7 μs (+6.3%)	NO
p90	747 ±85 μs	822 ±102 μs	+75.5 μs (+10.1%)	NO

20 test runs in comparison

Commit	Test Runs
`b68c1f6`	2023-03-31_18:02:27.817560_QdxD 2023-03-31_18:02:27.824440_RGSH 2023-03-31_18:02:27.824462_gQSV 2023-03-31_18:02:27.824468_Utlb 2023-03-31_18:02:27.824475_VoHT 2023-03-31_18:02:27.824480_mlCO 2023-03-31_18:02:27.824486_AWDd 2023-03-31_18:02:27.824491_UGfJ 2023-03-31_18:02:27.824496_aEgs 2023-03-31_18:02:27.824502_fIQv
`212f529`	2023-03-31_20:17:49.742686_PyBn 2023-03-31_20:17:49.743384_zZmV 2023-03-31_20:17:49.743394_qMPg 2023-03-31_20:17:49.743400_DGGM 2023-03-31_20:17:49.743405_nasO 2023-03-31_20:17:49.743411_aCTS 2023-03-31_20:17:49.743417_MNhy 2023-03-31_20:17:49.743422_Zmrm 2023-03-31_20:17:49.743427_zDKw 2023-03-31_20:17:49.743433_MnFY

`timeToInitialDisplay`

Device Statistics Distributions

oriole-32

Percentile	`b68c1f6`	`212f529`	Diff	Significant (?)
p10	193 ±9 ms	195 ±4 ms	+2.09 ms (+1.1%)	NO
p25	201 ±10 ms	201 ±5 ms	+48.1 μs (+0.0%)	NO
p50	211 ±18 ms	208 ±5 ms	-3.53 ms (-1.7%)	NO
p75	224 ±29 ms	218 ±6 ms	-5.94 ms (-2.6%)	NO
p90	234 ±32 ms	232 ±7 ms	-1.31 ms (-0.6%)	NO

20 test runs in comparison

Commit	Test Runs
`b68c1f6`	2023-03-31_18:02:27.817560_QdxD 2023-03-31_18:02:27.824440_RGSH 2023-03-31_18:02:27.824462_gQSV 2023-03-31_18:02:27.824468_Utlb 2023-03-31_18:02:27.824475_VoHT 2023-03-31_18:02:27.824480_mlCO 2023-03-31_18:02:27.824486_AWDd 2023-03-31_18:02:27.824491_UGfJ 2023-03-31_18:02:27.824496_aEgs 2023-03-31_18:02:27.824502_fIQv
`212f529`	2023-03-31_20:17:49.742686_PyBn 2023-03-31_20:17:49.743384_zZmV 2023-03-31_20:17:49.743394_qMPg 2023-03-31_20:17:49.743400_DGGM 2023-03-31_20:17:49.743405_nasO 2023-03-31_20:17:49.743411_aCTS 2023-03-31_20:17:49.743417_MNhy 2023-03-31_20:17:49.743422_Zmrm 2023-03-31_20:17:49.743427_zDKw 2023-03-31_20:17:49.743433_MnFY

redfin-30

Percentile	`b68c1f6`	`212f529`	Diff	Significant (?)
p10	231 ±5 ms	258 ±7 ms	+27.0 ms (+11.7%)	MAYBE
p25	237 ±5 ms	264 ±7 ms	+27.3 ms (+11.5%)	MAYBE
p50	244 ±6 ms	271 ±7 ms	+27.1 ms (+11.1%)	MAYBE
p75	251 ±6 ms	280 ±8 ms	+28.6 ms (+11.4%)	MAYBE
p90	261 ±9 ms	294 ±11 ms	+32.3 ms (+12.4%)	MAYBE

20 test runs in comparison

Commit	Test Runs
`b68c1f6`	2023-03-31_18:02:27.817560_QdxD 2023-03-31_18:02:27.824440_RGSH 2023-03-31_18:02:27.824462_gQSV 2023-03-31_18:02:27.824468_Utlb 2023-03-31_18:02:27.824475_VoHT 2023-03-31_18:02:27.824480_mlCO 2023-03-31_18:02:27.824486_AWDd 2023-03-31_18:02:27.824491_UGfJ 2023-03-31_18:02:27.824496_aEgs 2023-03-31_18:02:27.824502_fIQv
`212f529`	2023-03-31_20:17:49.742686_PyBn 2023-03-31_20:17:49.743384_zZmV 2023-03-31_20:17:49.743394_qMPg 2023-03-31_20:17:49.743400_DGGM 2023-03-31_20:17:49.743405_nasO 2023-03-31_20:17:49.743411_aCTS 2023-03-31_20:17:49.743417_MNhy 2023-03-31_20:17:49.743422_Zmrm 2023-03-31_20:17:49.743427_zDKw 2023-03-31_20:17:49.743433_MnFY

https://storage.googleapis.com/firebase-sdk-metric-reports/kExYFfYTaC/index.html

ehsannas · 2023-03-22T23:13:31Z

If you intend to merge this PR, you should make the tests only run against the emulator for now.
context: CI Tests / Instrumentation Tests (:firebase-firestore) bot failed.

MarkDuckworth

Code is looking really good! I have a few questions and discussion topics.

firebase-firestore/src/main/java/com/google/firebase/firestore/AggregateField.java

firebase-firestore/src/main/java/com/google/firebase/firestore/AggregateQuery.java

firebase-firestore/src/main/java/com/google/firebase/firestore/AggregateQuerySnapshot.java

firebase-firestore/src/androidTest/java/com/google/firebase/firestore/AggregationTest.java

firebase-firestore/src/main/java/com/google/firebase/firestore/AggregateField.java

MarkDuckworth

Moves in the right direction. I'd like to hear your thoughts on the remaining comments.

firebase-firestore/src/androidTest/java/com/google/firebase/firestore/AggregationTest.java

firebase-firestore/src/main/java/com/google/firebase/firestore/AggregateField.java

firebase-firestore/src/main/java/com/google/firebase/firestore/AggregateQuerySnapshot.java

MarkDuckworth

Awesome!

cherylEnkidu self-assigned this Mar 2, 2023

google-oss-bot added the size/L label Mar 2, 2023

cherylEnkidu added no-changelog main-merge-ack and removed size/L labels Mar 2, 2023

google-oss-bot added the size/XXL label Mar 16, 2023

cherylEnkidu force-pushed the cheryllin/sum-avg branch 2 times, most recently from a841f19 to 291f3ae Compare March 21, 2023 04:11

firebase deleted a comment from google-oss-bot Mar 21, 2023

cherylEnkidu requested review from ehsannas and MarkDuckworth March 21, 2023 04:13

cherylEnkidu assigned ehsannas and MarkDuckworth and unassigned cherylEnkidu Mar 21, 2023

cherylEnkidu force-pushed the cheryllin/sum-avg branch from 291f3ae to e1553b0 Compare March 21, 2023 04:25

firebase deleted a comment from google-oss-bot Mar 21, 2023

ehsannas removed their assignment Mar 22, 2023

ehsannas removed their request for review March 22, 2023 19:19

MarkDuckworth reviewed Mar 23, 2023

View reviewed changes

MarkDuckworth assigned cherylEnkidu and unassigned MarkDuckworth Mar 24, 2023

MarkDuckworth reviewed Mar 27, 2023

View reviewed changes

firebase-firestore/src/main/java/com/google/firebase/firestore/AggregateField.java Show resolved Hide resolved

firebase deleted a comment from google-oss-bot Mar 28, 2023

cherylEnkidu added 4 commits March 29, 2023 13:20

Tests if existing count test passes

4d8710d

add integration tests

e0e36c1

Add test coverage

af1bbd0

Clean up code

712d03d

cherylEnkidu force-pushed the cheryllin/sum-avg branch from e1553b0 to 0ec7ba3 Compare March 29, 2023 23:29

Address feedback

3b4ee6a

cherylEnkidu force-pushed the cheryllin/sum-avg branch from 0ec7ba3 to 3b4ee6a Compare March 29, 2023 23:42

cherylEnkidu assigned MarkDuckworth and unassigned cherylEnkidu Mar 30, 2023

MarkDuckworth reviewed Mar 30, 2023

View reviewed changes

MarkDuckworth assigned cherylEnkidu and unassigned MarkDuckworth Mar 30, 2023

cherylEnkidu force-pushed the cheryllin/sum-avg branch from f84a079 to 31fbd9d Compare March 31, 2023 19:47

Address feedback2

9991a9a

cherylEnkidu force-pushed the cheryllin/sum-avg branch from 31fbd9d to 9991a9a Compare March 31, 2023 20:01

cherylEnkidu assigned MarkDuckworth and unassigned cherylEnkidu Apr 2, 2023

MarkDuckworth approved these changes Apr 3, 2023

View reviewed changes

cherylEnkidu merged commit 26de539 into master Apr 4, 2023

cherylEnkidu deleted the cheryllin/sum-avg branch April 4, 2023 02:47

firebase locked and limited conversation to collaborators May 5, 2023

Support Sum/Avg in Android SDK #4735

Support Sum/Avg in Android SDK #4735

Uh oh!

Conversation

cherylEnkidu commented Mar 2, 2023

Uh oh!

github-actions bot commented Mar 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

google-oss-bot commented Mar 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report 1

Affected Products

firebase-firestore

Test Logs

Uh oh!

github-actions bot commented Mar 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Results

Uh oh!

google-oss-bot commented Mar 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

firebase-firestore

Test Logs

Uh oh!

google-oss-bot commented Mar 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Startup Time Report 1

Notes

Startup Times

fire-fst

timeToInitialDisplay

Uh oh!

ehsannas commented Mar 22, 2023

Uh oh!

MarkDuckworth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MarkDuckworth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MarkDuckworth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 2, 2023 •

edited

Loading

google-oss-bot commented Mar 2, 2023 •

edited

Loading

Coverage Report ¹

`firebase-firestore`

github-actions bot commented Mar 2, 2023 •

edited

Loading

google-oss-bot commented Mar 2, 2023 •

edited

Loading

Size Report ¹

`firebase-firestore`

google-oss-bot commented Mar 2, 2023 •

edited

Loading

Startup Time Report ¹

`fire-fst`

`timeToInitialDisplay`