A simple refactor on LocalStore.java

[wu-hui]

No description provided.

[github-actions]

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended.

[google-oss-bot]

	1 Warning
⚠️	Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

[google-oss-bot]

Coverage Report ¹

Affected Products

• firebase-firestore

  Overall coverage changed from 44.15% (02b3365) to 44.14% (bdd58a1) by -0.01%.

  Filename	Base (02b3365)	Merge (bdd58a1)	Diff
  DeleteMutation.java	90.48%	95.24%	+4.76%
  LocalStore.java	100.00%	99.39%	-0.61%
  LruGarbageCollector.java	97.20%	93.46%	-3.74%
  SetMutation.java	94.44%	97.22%	+2.78%

Test Logs

• Base (02b3365): https://github.com/firebase/firebase-android-sdk/actions/runs/4348826268
• Merge (bdd58a1): https://github.com/firebase/firebase-android-sdk/actions/runs/4366770609

1. https://storage.googleapis.com/firebase-sdk-metric-reports/6GJLjlDUXA.html

[github-actions]

Unit Test Results

   158 files   -    509     158 suites   - 509   1m 45s ⏱️ - 27m 38s
1 116 tests  - 3 246  1 100 ✔️  - 3 240  16 💤  -   5  0 ❌  - 1 
2 232 runs   - 6 021  2 200 ✔️  - 6 010  32 💤  - 10  0 ❌  - 1 

Results for commit 6e2cc84. ± Comparison against base commit 02b3365.

♻️ This comment has been updated with latest results.

[google-oss-bot]

Size Report ¹

Affected Products

• firebase-firestore

  Type	Base (02b3365)	Merge (bdd58a1)	Diff
  aar	1.32 MB	1.32 MB	+68 B (+0.0%)
  apk (release)	3.94 MB	3.94 MB	-68 B (-0.0%)

Test Logs

• Base (02b3365): https://github.com/firebase/firebase-android-sdk/actions/runs/4348826268
• Merge (bdd58a1): https://github.com/firebase/firebase-android-sdk/actions/runs/4366770609

1. https://storage.googleapis.com/firebase-sdk-metric-reports/fuds39UiXp.html

[google-oss-bot]

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

• This report is for comparing the base commit (02b3365) and the CI merge commit (bdd58a1)
• Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
  • 02b3365: https://storage.googleapis.com/firebase-sdk-metric-reports/bYeITGjqoi/index.html
  • bdd58a1: https://storage.googleapis.com/firebase-sdk-metric-reports/0ElniXqDBw/index.html

Startup Times

• fire-fst

  Device	Statistics	Distributions
  oriole-32	Percentile 02b3365 bdd58a1 Diff Significant (?) p10 347 ±32 μs 343 ±47 μs -4.04 μs (-1.2%) NO p25 375 ±46 μs 361 ±64 μs -14.0 μs (-3.7%) NO p50 422 ±62 μs 401 ±104 μs -20.3 μs (-4.8%) NO p75 515 ±97 μs 454 ±142 μs -61.3 μs (-11.9%) NO p90 607 ±148 μs 544 ±195 μs -63.1 μs (-10.4%) NO 20 test runs in comparison Commit Test Runs 02b3365 2023-03-06_23:25:02.770572_OgSq 2023-03-06_23:25:02.772755_JdKn 2023-03-06_23:25:02.772772_VYaQ 2023-03-06_23:25:02.772779_cNgO 2023-03-06_23:25:02.772784_ObHX 2023-03-06_23:25:02.772790_uABk 2023-03-06_23:25:02.772797_LdCt 2023-03-06_23:25:02.772803_wPto 2023-03-06_23:25:02.772808_xonD 2023-03-06_23:25:02.772814_Ufww bdd58a1 2023-03-08_17:32:45.692700_jccb 2023-03-08_17:32:45.700827_jJzO 2023-03-08_17:32:45.701008_DSnc 2023-03-08_17:32:45.701017_goUE 2023-03-08_17:32:45.701258_txMn 2023-03-08_17:32:45.701265_mQOI 2023-03-08_17:32:45.701272_nCUp 2023-03-08_17:32:45.701279_NzJq 2023-03-08_17:32:45.701284_mtcd 2023-03-08_17:32:45.701290_ireN
  redfin-30	Percentile 02b3365 bdd58a1 Diff Significant (?) p10 653 ±29 μs 664 ±26 μs +10.7 μs (+1.6%) NO p25 675 ±35 μs 685 ±30 μs +9.72 μs (+1.4%) NO p50 707 ±46 μs 713 ±37 μs +6.67 μs (+0.9%) NO p75 744 ±55 μs 760 ±49 μs +16.3 μs (+2.2%) NO p90 789 ±76 μs 814 ±67 μs +25.1 μs (+3.2%) NO 20 test runs in comparison Commit Test Runs 02b3365 2023-03-06_23:25:02.770572_OgSq 2023-03-06_23:25:02.772755_JdKn 2023-03-06_23:25:02.772772_VYaQ 2023-03-06_23:25:02.772779_cNgO 2023-03-06_23:25:02.772784_ObHX 2023-03-06_23:25:02.772790_uABk 2023-03-06_23:25:02.772797_LdCt 2023-03-06_23:25:02.772803_wPto 2023-03-06_23:25:02.772808_xonD 2023-03-06_23:25:02.772814_Ufww bdd58a1 2023-03-08_17:32:45.692700_jccb 2023-03-08_17:32:45.700827_jJzO 2023-03-08_17:32:45.701008_DSnc 2023-03-08_17:32:45.701017_goUE 2023-03-08_17:32:45.701258_txMn 2023-03-08_17:32:45.701265_mQOI 2023-03-08_17:32:45.701272_nCUp 2023-03-08_17:32:45.701279_NzJq 2023-03-08_17:32:45.701284_mtcd 2023-03-08_17:32:45.701290_ireN

• timeToInitialDisplay

  Device	Statistics	Distributions
  oriole-32	Percentile 02b3365 bdd58a1 Diff Significant (?) p10 193 ±4 ms 200 ±17 ms +7.02 ms (+3.6%) NO p25 200 ±6 ms 207 ±20 ms +7.47 ms (+3.7%) NO p50 208 ±8 ms 217 ±25 ms +8.69 ms (+4.2%) NO p75 220 ±19 ms 227 ±29 ms +6.67 ms (+3.0%) NO p90 230 ±22 ms 242 ±32 ms +12.4 ms (+5.4%) NO 20 test runs in comparison Commit Test Runs 02b3365 2023-03-06_23:25:02.770572_OgSq 2023-03-06_23:25:02.772755_JdKn 2023-03-06_23:25:02.772772_VYaQ 2023-03-06_23:25:02.772779_cNgO 2023-03-06_23:25:02.772784_ObHX 2023-03-06_23:25:02.772790_uABk 2023-03-06_23:25:02.772797_LdCt 2023-03-06_23:25:02.772803_wPto 2023-03-06_23:25:02.772808_xonD 2023-03-06_23:25:02.772814_Ufww bdd58a1 2023-03-08_17:32:45.692700_jccb 2023-03-08_17:32:45.700827_jJzO 2023-03-08_17:32:45.701008_DSnc 2023-03-08_17:32:45.701017_goUE 2023-03-08_17:32:45.701258_txMn 2023-03-08_17:32:45.701265_mQOI 2023-03-08_17:32:45.701272_nCUp 2023-03-08_17:32:45.701279_NzJq 2023-03-08_17:32:45.701284_mtcd 2023-03-08_17:32:45.701290_ireN
  redfin-30	Percentile 02b3365 bdd58a1 Diff Significant (?) p10 230 ±6 ms 251 ±4 ms +20.8 ms (+9.0%) MAYBE p25 236 ±6 ms 257 ±4 ms +20.6 ms (+8.7%) MAYBE p50 243 ±7 ms 264 ±4 ms +20.8 ms (+8.6%) MAYBE p75 251 ±7 ms 273 ±5 ms +21.5 ms (+8.6%) NO p90 259 ±6 ms 285 ±9 ms +25.9 ms (+10.0%) MAYBE 20 test runs in comparison Commit Test Runs 02b3365 2023-03-06_23:25:02.770572_OgSq 2023-03-06_23:25:02.772755_JdKn 2023-03-06_23:25:02.772772_VYaQ 2023-03-06_23:25:02.772779_cNgO 2023-03-06_23:25:02.772784_ObHX 2023-03-06_23:25:02.772790_uABk 2023-03-06_23:25:02.772797_LdCt 2023-03-06_23:25:02.772803_wPto 2023-03-06_23:25:02.772808_xonD 2023-03-06_23:25:02.772814_Ufww bdd58a1 2023-03-08_17:32:45.692700_jccb 2023-03-08_17:32:45.700827_jJzO 2023-03-08_17:32:45.701008_DSnc 2023-03-08_17:32:45.701017_goUE 2023-03-08_17:32:45.701258_txMn 2023-03-08_17:32:45.701265_mQOI 2023-03-08_17:32:45.701272_nCUp 2023-03-08_17:32:45.701279_NzJq 2023-03-08_17:32:45.701284_mtcd 2023-03-08_17:32:45.701290_ireN

1. https://storage.googleapis.com/firebase-sdk-metric-reports/8FczBW5jcR/index.html