Skip to content

Make NumberedEnum public, not internal #4776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2023
Merged

Make NumberedEnum public, not internal #4776

merged 1 commit into from
Mar 13, 2023

Conversation

mrober
Copy link
Contributor

@mrober mrober commented Mar 13, 2023

Make NumberedEnum public, not internal. This is needed to use it in other Firebase libraries.

@mrober mrober requested a review from davidmotson March 13, 2023 15:37
@mrober mrober enabled auto-merge (squash) March 13, 2023 15:37
@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2023 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended.

1 similar comment
@github-actions
Copy link
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended.

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

No changes between base commit (ac5fc85) and merge commit (84e977e).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/o6UGrSmJEY.html

@github-actions
Copy link
Contributor

Unit Test Results

  4 files  ±0    4 suites  ±0   21s ⏱️ +5s
32 tests ±0  32 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
64 runs  ±0  64 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2021b72. ± Comparison against base commit ac5fc85.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-encoders-json

    TypeBase (ac5fc85)Merge (84e977e)Diff
    aar11.3 kB11.3 kB-2 B (-0.0%)
    apk (release)596 kB596 kB-4 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/gnPSQrn1Mn.html

@mrober mrober merged commit 7a0f906 into master Mar 13, 2023
@mrober mrober deleted the firebase-encoder-enum-fix branch March 13, 2023 17:30
@firebase firebase locked and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidmotson davidmotson davidmotson approved these changes

Assignees
No one assigned
Labels
main-merge-ack no-changelog size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrober @google-oss-bot @davidmotson