Skip to content

Add Kotlin format instructions to the README file #4798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 28, 2023
Merged

Add Kotlin format instructions to the README file #4798

merged 4 commits into from
Mar 28, 2023

Conversation

mrober
Copy link
Contributor

@mrober mrober commented Mar 17, 2023

No description provided.

@mrober mrober requested a review from davidmotson March 17, 2023 14:13
@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2023 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2023 •
edited
Loading

Unit Test Results

   774 files  +  43     774 suites  +43   34m 29s ⏱️ + 5m 26s
4 853 tests +  75  4 832 ✔️ +  76  21 💤 ±0  0 ❌  - 1 
9 503 runs  +562  9 461 ✔️ +563  42 💤 ±0  0 ❌  - 1 

Results for commit 40945cd. ± Comparison against base commit 1320a47.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 17, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (1320a47) and merge commit (467b7a8).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/nWsHV8yIBk.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 17, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.18% (1320a47) to 50.22% (467b7a8) by +0.04%.

    FilenameBase (1320a47)Merge (467b7a8)Diff
    WebsocketConnection.java32.77%35.03%+2.26%

  • firebase-firestore

    Overall coverage changed from 44.17% (1320a47) to 44.17% (467b7a8) by +0.00%.

    FilenameBase (1320a47)Merge (467b7a8)Diff
    DeleteMutation.java95.24%90.48%-4.76%
    PatchMutation.java98.39%100.00%+1.61%
    SetMutation.java94.44%97.22%+2.78%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/WjMXibqn4L.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 17, 2023 •
edited
Loading

Startup Time Report 1

The report is too large (117,055 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/6ykoQG99SX/index.html

@mrober mrober enabled auto-merge (squash) March 17, 2023 17:23
@davidmotson davidmotson disabled auto-merge March 28, 2023 19:51
@davidmotson davidmotson merged commit d72542b into master Mar 28, 2023
@davidmotson davidmotson deleted the firebase-kotlin-format branch March 28, 2023 19:51
@firebase firebase locked and limited conversation to collaborators Apr 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidmotson davidmotson davidmotson approved these changes

Assignees
No one assigned
Labels
api: sessions main-merge-ack no-changelog size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrober @google-oss-bot @davidmotson @samedson