Populate firebaseInstallationId field in session #4801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrober
commented
Mar 20, 2023
| val sessionCoordinator = | ||
| SessionCoordinator( | ||
| firebaseInstallations = FakeFirebaseInstallations("FaKeFiD"), | ||
| backgroundDispatcher = StandardTestDispatcher(testScheduler), |
There was a problem hiding this comment.
:integ-testing doesn't have any test CoroutineDispatchers to work well with runTesting.
There was a problem hiding this comment.
:integ-testing is to provide executors for testing that mimic the executors provided by firebase-common with policies e.g. don't do blocking network requests on Background. See https://firebase.github.io/firebase-android-sdk/components/executors/#testing
So these tests don't mimic the Background policy. I tried to use TestOnlyExecutors.background().asCoroutineDispatcher() when I first wrote this test, but then I couldn't call runCurrent() to wait for the suspend functions to finish before doing the assert.
Coverage Report 1Affected Products
Test Logs |
Size Report 1Affected Products
Test Logs |
davidmotson
approved these changes
Mar 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Populate
firebaseInstallationIdfield in session data.Add
SessionCoordinatorclass and plumb in aCoroutineDispatcher.Setup coroutines including testing.