Skip to content

Migrate Database to KTS + VC #4816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Mar 29, 2023
Merged

Conversation

daymxn
Copy link
Member

@daymxn daymxn commented Mar 23, 2023

Per b/274927706,

This migrates all the database build scripts from Groovy to Kotlin, and from the old ext based common dep versioning to the new Version Catalog based versioning.

More specifically, this migrates the following SDKs:

  • firebase-database
  • firebase-database-ktx
  • firebase-database-collection

This also fixes a minor bug with IntegrationTestValues that causes the IDE to freak out regarding resources populated at runtime not being present.

@daymxn daymxn self-assigned this Mar 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2023

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 23, 2023

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.16% (d72542b) to 50.18% (9c6efda) by +0.01%.

    FilenameBase (d72542b)Merge (9c6efda)Diff
    DoubleNode.java88.24%100.00%+11.76%
    QueryParams.java90.36%89.76%-0.60%
  • firebase-firestore

    Overall coverage changed from 44.18% (d72542b) to 44.17% (9c6efda) by -0.01%.

    FilenameBase (d72542b)Merge (9c6efda)Diff
    DeleteMutation.java95.24%90.48%-4.76%
    SetMutation.java97.22%94.44%-2.78%
  • firebase-messaging

    Overall coverage changed from ? (d72542b) to 85.29% (9c6efda) by ?.

    41 individual files with coverage change

    FilenameBase (d72542b)Merge (9c6efda)Diff
    AutoProtoEncoderDoNotUseEncoder.java?98.17%?
    ByteStreams.java?59.72%?
    CommonNotificationBuilder.java?90.78%?
    Constants.java?92.86%?
    DisplayNotification.java?91.38%?
    EnhancedIntentService.java?76.60%?
    ExecutorFactory.java?0.00%?
    FcmBroadcastProcessor.java?93.33%?
    FcmExecutors.java?80.00%?
    FcmLifecycleCallbacks.java?89.29%?
    FirebaseInstanceIdReceiver.java?72.73%?
    FirebaseMessaging.java?75.77%?
    FirebaseMessagingRegistrar.java?100.00%?
    FirebaseMessagingService.java?94.03%?
    GmsRpc.java?83.15%?
    ImageDownload.java?93.33%?
    MessagingAnalytics.java?81.78%?
    MessagingClientEvent.java?93.58%?
    MessagingClientEventExtension.java?76.47%?
    Metadata.java?61.90%?
    NotificationParams.java?98.71%?
    PoolableExecutors.java?29.17%?
    ProtoEncoderDoNotUse.java?50.00%?
    ProxyNotificationInitializer.java?93.75%?
    ProxyNotificationPreferences.java?88.89%?
    RemoteMessage.java?95.48%?
    RemoteMessageCreator.java?88.89%?
    RequestDeduplicator.java?90.00%?
    SendException.java?100.00%?
    ServiceStarter.java?87.50%?
    SharedPreferencesQueue.java?98.65%?
    Store.java?74.19%?
    SyncTask.java?70.83%?
    ThreadPriority.java?100.00%?
    TopicOperation.java?90.00%?
    TopicsStore.java?100.00%?
    TopicsSubscriber.java?89.47%?
    TopicsSyncTask.java?53.33%?
    WakeLockHolder.java?95.92%?
    WithinAppServiceBinder.java?90.91%?
    WithinAppServiceConnection.java?84.15%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Bg9outfPba.html

@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2023

Unit Test Results

   774 files  ±0     774 suites  ±0   32m 9s ⏱️ -43s
4 853 tests ±0  4 832 ✔️ ±0  21 💤 ±0  0 ±0 
9 503 runs  ±0  9 461 ✔️ ±0  42 💤 ±0  0 ±0 

Results for commit 41beac6. ± Comparison against base commit d72542b.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 23, 2023

Size Report 1

Affected Products

  • firebase-database

    TypeBase (d72542b)Merge (9c6efda)Diff
    apk (aggressive)360 kB359 kB-1.28 kB (-0.4%)
    apk (release)1.72 MB1.72 MB+3.26 kB (+0.2%)
  • firebase-database-collection

    TypeBase (d72542b)Merge (9c6efda)Diff
    apk (aggressive)312 kB312 kB+20 B (+0.0%)
    apk (release)941 kB942 kB+656 B (+0.1%)
  • firebase-database-ktx

    TypeBase (d72542b)Merge (9c6efda)Diff
    aar22.6 kB22.6 kB+2 B (+0.0%)
    apk (aggressive)368 kB367 kB-1.33 kB (-0.4%)
    apk (release)2.10 MB2.11 MB+2.19 kB (+0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/njUJ6RLbr1.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 23, 2023

Startup Time Report 1

The report is too large (117,093 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/GbQIxFKjj7/index.html

@daymxn daymxn requested a review from rlazo March 27, 2023 19:37
@daymxn daymxn requested a review from rlazo March 29, 2023 18:12
@daymxn daymxn requested a review from rlazo March 29, 2023 20:00
@daymxn daymxn disabled auto-merge March 29, 2023 20:28
@daymxn daymxn merged commit f63aa5e into master Mar 29, 2023
@daymxn daymxn deleted the daymon-migrate-database-buildscript branch March 29, 2023 20:28
@firebase firebase locked and limited conversation to collaborators Apr 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants