Skip to content

Fix bundle query resume issue #4824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 14, 2023
Merged

Fix bundle query resume issue #4824

merged 6 commits into from
Apr 14, 2023

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Mar 27, 2023 •
edited
Loading

fixes b/272830558

@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2023 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 27, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from ? (5cc1bf5) to 44.10% (417c3d7) by ?.

    321 individual files with coverage change

    FilenameBase (5cc1bf5)Merge (417c3d7)Diff
    AbstractStream.java?34.81%?
    ActivityScope.java?0.00%?
    AggregateField.java?27.59%?
    AggregateQuery.java?18.18%?
    AggregateQuerySnapshot.java?0.00%?
    AggregateSource.java?0.00%?
    AggregationResult.java?0.00%?
    AggregationResultOrBuilder.java?0.00%?
    AggregationResultProto.java?0.00%?
    AndroidConnectivityMonitor.java?39.51%?
    ApiUtil.java?12.50%?
    ArrayContainsAnyFilter.java?100.00%?
    ArrayContainsFilter.java?100.00%?
    ArrayTransformOperation.java?86.49%?
    ArrayValue.java?48.60%?
    ArrayValueOrBuilder.java?0.00%?
    Assert.java?60.00%?
    AsyncEventListener.java?0.00%?
    AsyncQueue.java?70.65%?
    AutoValue_FieldIndex.java?58.33%?
    AutoValue_FieldIndex_IndexOffset.java?58.62%?
    AutoValue_FieldIndex_IndexState.java?59.09%?
    AutoValue_FieldIndex_Segment.java?54.17%?
    AutoValue_IndexEntry.java?34.21%?
    AutoValue_Overlay.java?54.55%?
    AutoValue_TestingHooks_ExistenceFilterMismatchInfo.java?20.00%?
    BackgroundQueue.java?81.25%?
    BasePath.java?86.54%?
    BatchGetDocumentsRequest.java?0.00%?
    BatchGetDocumentsRequestOrBuilder.java?0.00%?
    BatchGetDocumentsResponse.java?0.00%?
    BatchGetDocumentsResponseOrBuilder.java?0.00%?
    BeginTransactionRequest.java?0.00%?
    BeginTransactionRequestOrBuilder.java?0.00%?
    BeginTransactionResponse.java?0.00%?
    BeginTransactionResponseOrBuilder.java?0.00%?
    Blob.java?76.92%?
    Bound.java?39.29%?
    BundleCache.java?0.00%?
    BundleCallback.java?0.00%?
    BundledDocumentMetadata.java?0.00%?
    BundledDocumentMetadataOrBuilder.java?0.00%?
    BundleDocument.java?90.00%?
    BundledQuery.java?34.57%?
    BundledQueryOrBuilder.java?0.00%?
    BundleElement.java?0.00%?
    BundleElementOrBuilder.java?0.00%?
    BundleLoader.java?100.00%?
    BundleMetadata.java?0.00%?
    BundleMetadataOrBuilder.java?0.00%?
    BundleProto.java?0.00%?
    BundleReader.java?95.29%?
    BundleSerializer.java?89.52%?
    ByteBufferInputStream.java?83.33%?
    CollectionReference.java?13.64%?
    CommitRequest.java?0.00%?
    CommitRequestOrBuilder.java?0.00%?
    CommitResponse.java?0.00%?
    CommitResponseOrBuilder.java?0.00%?
    CommonProto.java?0.00%?
    ComponentProvider.java?100.00%?
    CompositeFilter.java?98.57%?
    ConnectivityMonitor.java?0.00%?
    Consumer.java?0.00%?
    CreateDocumentRequest.java?0.00%?
    CreateDocumentRequestOrBuilder.java?0.00%?
    CredentialsProvider.java?100.00%?
    Cursor.java?35.29%?
    CursorOrBuilder.java?0.00%?
    CustomClassMapper.java?84.25%?
    DatabaseId.java?70.37%?
    DatabaseInfo.java?90.91%?
    Datastore.java?26.47%?
    DatastoreTestTrace.java?0.00%?
    DeleteDocumentRequest.java?0.00%?
    DeleteDocumentRequestOrBuilder.java?0.00%?
    DeleteMutation.java?95.24%?
    DirectionalIndexByteEncoder.java?100.00%?
    Document.java?100.00%?
    DocumentChange.java?67.61%?
    DocumentChangeOrBuilder.java?0.00%?
    DocumentCollections.java?83.33%?
    DocumentDelete.java?34.62%?
    DocumentDeleteOrBuilder.java?0.00%?
    DocumentId.java?0.00%?
    DocumentKey.java?97.14%?
    DocumentMask.java?40.66%?
    DocumentMaskOrBuilder.java?0.00%?
    DocumentOrBuilder.java?0.00%?
    DocumentOverlayCache.java?0.00%?
    DocumentProto.java?0.00%?
    DocumentReference.java?13.24%?
    DocumentRemove.java?29.23%?
    DocumentRemoveOrBuilder.java?0.00%?
    DocumentSet.java?83.78%?
    DocumentSnapshot.java?37.50%?
    DocumentTransform.java?29.31%?
    DocumentTransformOrBuilder.java?0.00%?
    DocumentViewChange.java?90.91%?
    DocumentViewChangeSet.java?87.88%?
    EncodedPath.java?93.22%?
    EventListener.java?0.00%?
    EventManager.java?96.15%?
    Exclude.java?0.00%?
    Executors.java?100.00%?
    ExistenceFilter.java?80.00%?
    ExistenceFilterOrBuilder.java?0.00%?
    ExponentialBackoff.java?30.43%?
    FieldFilter.java?93.06%?
    FieldIndex.java?98.18%?
    FieldMask.java?57.89%?
    FieldPath.java?89.66%?
    FieldTransform.java?64.71%?
    FieldValue.java?82.14%?
    FileUtil.java?0.00%?
    Filter.java?0.00%?
    FirebaseAppCheckTokenProvider.java?93.75%?
    FirebaseAuthCredentialsProvider.java?100.00%?
    FirebaseClientGrpcMetadataProvider.java?44.00%?
    FirebaseFirestore.java?36.67%?
    FirebaseFirestoreException.java?83.72%?
    FirebaseFirestoreSettings.java?71.76%?
    FirestoreCallCredentials.java?18.60%?
    FirestoreChannel.java?18.10%?
    FirestoreClient.java?36.11%?
    FirestoreGrpc.java?2.46%?
    FirestoreIndexValueWriter.java?77.11%?
    FirestoreMultiDbComponent.java?100.00%?
    FirestoreProto.java?0.00%?
    FirestoreRegistrar.java?100.00%?
    Function.java?0.00%?
    GeoPoint.java?91.67%?
    GetDocumentRequest.java?0.00%?
    GetDocumentRequestOrBuilder.java?0.00%?
    GrpcCallProvider.java?69.41%?
    GrpcMetadataProvider.java?0.00%?
    IgnoreExtraProperties.java?0.00%?
    IncomingStreamObserver.java?0.00%?
    Index.java?30.02%?
    IndexBackfiller.java?100.00%?
    IndexByteEncoder.java?88.57%?
    IndexEntry.java?100.00%?
    IndexManager.java?100.00%?
    IndexOrBuilder.java?0.00%?
    IndexProto.java?0.00%?
    InFilter.java?100.00%?
    IntMath.java?41.67%?
    KeyFieldFilter.java?66.67%?
    KeyFieldInFilter.java?0.00%?
    KeyFieldNotInFilter.java?0.00%?
    LimboDocumentChange.java?70.59%?
    ListCollectionIdsRequest.java?0.00%?
    ListCollectionIdsRequestOrBuilder.java?0.00%?
    ListCollectionIdsResponse.java?0.00%?
    ListCollectionIdsResponseOrBuilder.java?0.00%?
    ListDocumentsRequest.java?0.00%?
    ListDocumentsRequestOrBuilder.java?0.00%?
    ListDocumentsResponse.java?0.00%?
    ListDocumentsResponseOrBuilder.java?0.00%?
    Listener.java?0.00%?
    ListenerRegistration.java?0.00%?
    ListenerRegistrationImpl.java?0.00%?
    ListenRequest.java?10.66%?
    ListenRequestOrBuilder.java?0.00%?
    ListenResponse.java?32.64%?
    ListenResponseOrBuilder.java?0.00%?
    ListenSequence.java?100.00%?
    LoadBundleTask.java?25.26%?
    LoadBundleTaskProgress.java?60.47%?
    LocalCacheSettings.java?0.00%?
    LocalDocumentsResult.java?100.00%?
    LocalDocumentsView.java?100.00%?
    LocalSerializer.java?97.35%?
    LocalStore.java?99.39%?
    LocalViewChanges.java?100.00%?
    Logger.java?75.00%?
    LogicUtils.java?96.67%?
    LruDelegate.java?0.00%?
    LruGarbageCollector.java?93.46%?
    MapValue.java?53.00%?
    MapValueOrBuilder.java?0.00%?
    MemoryBundleCache.java?100.00%?
    MemoryCacheSettings.java?28.57%?
    MemoryComponentProvider.java?100.00%?
    MemoryDocumentOverlayCache.java?100.00%?
    MemoryEagerReferenceDelegate.java?100.00%?
    MemoryIndexManager.java?68.97%?
    MemoryLruReferenceDelegate.java?96.00%?
    MemoryMutationQueue.java?98.57%?
    MemoryOverlayMigrationManager.java?100.00%?
    MemoryPersistence.java?100.00%?
    MemoryRemoteDocumentCache.java?98.28%?
    MemoryTargetCache.java?100.00%?
    MetadataChanges.java?100.00%?
    MutableDocument.java?100.00%?
    Mutation.java?100.00%?
    MutationBatch.java?89.23%?
    MutationBatchResult.java?100.00%?
    MutationQueue.java?0.00%?
    MutationResult.java?100.00%?
    NamedQuery.java?0.00%?
    NamedQueryOrBuilder.java?0.00%?
    NotInFilter.java?85.71%?
    NumberComparisonHelper.java?100.00%?
    NumericIncrementTransformOperation.java?87.50%?
    ObjectValue.java?99.06%?
    OnlineState.java?100.00%?
    OnlineStateTracker.java?98.11%?
    OnProgressListener.java?0.00%?
    OrderBy.java?96.55%?
    OrderedCodeWriter.java?68.52%?
    Overlay.java?100.00%?
    OverlayedDocument.java?100.00%?
    OverlayMigrationManager.java?0.00%?
    PatchMutation.java?100.00%?
    Persistence.java?100.00%?
    PersistentCacheSettings.java?62.50%?
    Precondition.java?37.82%?
    PreconditionOrBuilder.java?0.00%?
    Preconditions.java?57.89%?
    PropertyName.java?0.00%?
    Query.java?3.96%?
    QueryDocumentSnapshot.java?64.71%?
    QueryEngine.java?98.63%?
    QueryListener.java?100.00%?
    QueryProto.java?0.00%?
    QueryPurpose.java?100.00%?
    QueryResult.java?100.00%?
    QuerySnapshot.java?76.36%?
    QueryView.java?100.00%?
    ReferenceDelegate.java?0.00%?
    ReferenceSet.java?92.45%?
    RemoteDocumentCache.java?0.00%?
    RemoteEvent.java?92.31%?
    RemoteSerializer.java?80.57%?
    RemoteStore.java?88.49%?
    ResourcePath.java?94.74%?
    RollbackRequest.java?0.00%?
    RollbackRequestOrBuilder.java?0.00%?
    RunAggregationQueryRequest.java?0.00%?
    RunAggregationQueryRequestOrBuilder.java?0.00%?
    RunAggregationQueryResponse.java?0.00%?
    RunAggregationQueryResponseOrBuilder.java?0.00%?
    RunQueryRequest.java?0.00%?
    RunQueryRequestOrBuilder.java?0.00%?
    RunQueryResponse.java?0.00%?
    RunQueryResponseOrBuilder.java?0.00%?
    Scheduler.java?0.00%?
    ServerTimestamp.java?0.00%?
    ServerTimestampOperation.java?100.00%?
    ServerTimestamps.java?96.00%?
    SetMutation.java?97.22%?
    SetOptions.java?0.00%?
    SnapshotMetadata.java?68.75%?
    SnapshotVersion.java?87.50%?
    Source.java?0.00%?
    SQLiteBundleCache.java?90.00%?
    SQLiteComponentProvider.java?100.00%?
    SQLiteDocumentOverlayCache.java?97.85%?
    SQLiteIndexManager.java?99.49%?
    SQLiteLruReferenceDelegate.java?98.67%?
    SQLiteMutationQueue.java?82.76%?
    SQLiteOverlayMigrationManager.java?90.48%?
    SQLitePersistence.java?86.34%?
    SQLiteRemoteDocumentCache.java?98.21%?
    SQLiteSchema.java?96.63%?
    SQLiteTargetCache.java?98.47%?
    Stream.java?100.00%?
    StructuredAggregationQuery.java?0.00%?
    StructuredAggregationQueryOrBuilder.java?0.00%?
    StructuredQuery.java?32.54%?
    StructuredQueryOrBuilder.java?0.00%?
    Supplier.java?0.00%?
    SyncEngine.java?93.31%?
    Target.java?95.79%?
    TargetCache.java?0.00%?
    TargetChange.java?80.00%?
    TargetChangeOrBuilder.java?0.00%?
    TargetData.java?77.50%?
    TargetIdGenerator.java?100.00%?
    TargetIndexMatcher.java?100.00%?
    TargetOrBuilder.java?0.00%?
    TargetState.java?97.78%?
    TestingHooks.java?40.91%?
    ThrottledForwardingExecutor.java?100.00%?
    ThrowOnExtraProperties.java?0.00%?
    Timestamp.java?80.39%?
    Token.java?0.00%?
    Transaction.java?0.00%?
    TransactionOptions.java?0.00%?
    TransactionOptionsOrBuilder.java?0.00%?
    TransactionRunner.java?0.00%?
    TransformOperation.java?0.00%?
    UpdateDocumentRequest.java?0.00%?
    UpdateDocumentRequestOrBuilder.java?0.00%?
    User.java?78.57%?
    UserData.java?66.00%?
    UserDataReader.java?70.48%?
    UserDataWriter.java?51.02%?
    Util.java?67.63%?
    Value.java?41.22%?
    ValueOrBuilder.java?0.00%?
    Values.java?95.65%?
    VerifyMutation.java?46.15%?
    View.java?96.82%?
    ViewChange.java?100.00%?
    ViewSnapshot.java?89.23%?
    WatchChange.java?70.51%?
    WatchChangeAggregator.java?98.26%?
    WatchStream.java?19.23%?
    Write.java?36.11%?
    WriteBatch.java?0.00%?
    WriteOrBuilder.java?0.00%?
    WriteProto.java?0.00%?
    WriteRequest.java?10.41%?
    WriteRequestOrBuilder.java?0.00%?
    WriteResponse.java?11.70%?
    WriteResponseOrBuilder.java?0.00%?
    WriteResult.java?0.00%?
    WriteResultOrBuilder.java?0.00%?
    WriteStream.java?31.82%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/knzOeS8OSH.html

@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2023 •
edited
Loading

Unit Test Results

   158 files   -    605     158 suites   - 605   2m 48s ⏱️ - 29m 48s
1 123 tests  - 3 739  1 107 ✔️  - 3 730  16 💤  -   5  0 ❌  - 4 
2 246 runs   - 6 916  2 214 ✔️  - 6 902  32 💤  - 10  0 ❌  - 4 

Results for commit be7e393. ± Comparison against base commit 5cc1bf5.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 27, 2023 •
edited
Loading

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (5cc1bf5)Merge (417c3d7)Diff
    aar1.33 MB1.33 MB+24 B (+0.0%)
    apk (release)3.94 MB3.94 MB+136 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/zpiIMAe5Pf.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 27, 2023 •
edited
Loading

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-fst

    DeviceStatisticsDistributions
    oriole-32
    Percentile5cc1bf5417c3d7DiffSignificant (?)
    p10332 ±20 μs445 ±129 μs+114 μs (+34.2%)NO
    p25346 ±23 μs470 ±142 μs+124 μs (+35.8%)NO
    p50382 ±51 μs505 ±165 μs+123 μs (+32.1%)NO
    p75455 ±78 μs609 ±244 μs+153 μs (+33.7%)NO
    p90543 ±114 μs794 ±431 μs+252 μs (+46.4%)NO

    20 test runs in comparison
    CommitTest Runs
    5cc1bf5
    • 2023-04-14_17:22:46.017744_uxns
    • 2023-04-14_17:22:46.019872_YdPT
    • 2023-04-14_17:22:46.019882_aCeW
    • 2023-04-14_17:22:46.019888_ZiaU
    • 2023-04-14_17:22:46.020011_gfQn
    • 2023-04-14_17:22:46.020017_tAwQ
    • 2023-04-14_17:22:46.020023_CuZX
    • 2023-04-14_17:22:46.020028_SLxO
    • 2023-04-14_17:22:46.020034_Lkgo
    • 2023-04-14_17:22:46.020039_qMWA
    417c3d7
    • 2023-04-14_17:49:28.166526_kvID
    • 2023-04-14_17:49:28.169812_gjIU
    • 2023-04-14_17:49:28.169823_xYOM
    • 2023-04-14_17:49:28.169830_xbyW
    • 2023-04-14_17:49:28.169836_sdSM
    • 2023-04-14_17:49:28.169845_bJrJ
    • 2023-04-14_17:49:28.169851_fIKB
    • 2023-04-14_17:49:28.169857_vayI
    • 2023-04-14_17:49:28.169862_aXzo
    • 2023-04-14_17:49:28.169867_QLIl
    redfin-30
    Percentile5cc1bf5417c3d7DiffSignificant (?)
    p10613 ±21 μs626 ±37 μs+13.2 μs (+2.2%)NO
    p25629 ±22 μs640 ±41 μs+10.4 μs (+1.6%)NO
    p50649 ±26 μs658 ±48 μs+9.18 μs (+1.4%)NO
    p75683 ±38 μs687 ±56 μs+3.69 μs (+0.5%)NO
    p90716 ±44 μs722 ±71 μs+6.42 μs (+0.9%)NO

    20 test runs in comparison
    CommitTest Runs
    5cc1bf5
    • 2023-04-14_17:22:46.017744_uxns
    • 2023-04-14_17:22:46.019872_YdPT
    • 2023-04-14_17:22:46.019882_aCeW
    • 2023-04-14_17:22:46.019888_ZiaU
    • 2023-04-14_17:22:46.020011_gfQn
    • 2023-04-14_17:22:46.020017_tAwQ
    • 2023-04-14_17:22:46.020023_CuZX
    • 2023-04-14_17:22:46.020028_SLxO
    • 2023-04-14_17:22:46.020034_Lkgo
    • 2023-04-14_17:22:46.020039_qMWA
    417c3d7
    • 2023-04-14_17:49:28.166526_kvID
    • 2023-04-14_17:49:28.169812_gjIU
    • 2023-04-14_17:49:28.169823_xYOM
    • 2023-04-14_17:49:28.169830_xbyW
    • 2023-04-14_17:49:28.169836_sdSM
    • 2023-04-14_17:49:28.169845_bJrJ
    • 2023-04-14_17:49:28.169851_fIKB
    • 2023-04-14_17:49:28.169857_vayI
    • 2023-04-14_17:49:28.169862_aXzo
    • 2023-04-14_17:49:28.169867_QLIl

  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile5cc1bf5417c3d7DiffSignificant (?)
    p10194 ±8 ms236 ±41 ms+41.4 ms (+21.3%)NO
    p25200 ±9 ms246 ±43 ms+46.5 ms (+23.3%)NO
    p50207 ±9 ms260 ±48 ms+53.8 ms (+26.0%)NO
    p75215 ±9 ms277 ±54 ms+62.2 ms (+28.9%)NO
    p90222 ±9.6 ms296 ±54 ms+73.6 ms (+33.1%)NO

    20 test runs in comparison
    CommitTest Runs
    5cc1bf5
    • 2023-04-14_17:22:46.017744_uxns
    • 2023-04-14_17:22:46.019872_YdPT
    • 2023-04-14_17:22:46.019882_aCeW
    • 2023-04-14_17:22:46.019888_ZiaU
    • 2023-04-14_17:22:46.020011_gfQn
    • 2023-04-14_17:22:46.020017_tAwQ
    • 2023-04-14_17:22:46.020023_CuZX
    • 2023-04-14_17:22:46.020028_SLxO
    • 2023-04-14_17:22:46.020034_Lkgo
    • 2023-04-14_17:22:46.020039_qMWA
    417c3d7
    • 2023-04-14_17:49:28.166526_kvID
    • 2023-04-14_17:49:28.169812_gjIU
    • 2023-04-14_17:49:28.169823_xYOM
    • 2023-04-14_17:49:28.169830_xbyW
    • 2023-04-14_17:49:28.169836_sdSM
    • 2023-04-14_17:49:28.169845_bJrJ
    • 2023-04-14_17:49:28.169851_fIKB
    • 2023-04-14_17:49:28.169857_vayI
    • 2023-04-14_17:49:28.169862_aXzo
    • 2023-04-14_17:49:28.169867_QLIl
    redfin-30
    Percentile5cc1bf5417c3d7DiffSignificant (?)
    p10229 ±5 ms254 ±3 ms+24.9 ms (+10.9%)YES
    p25236 ±5 ms259 ±3 ms+23.8 ms (+10.1%)YES
    p50243 ±5 ms267 ±4 ms+23.9 ms (+9.8%)YES
    p75250 ±5 ms277 ±5 ms+26.1 ms (+10.4%)YES
    p90258 ±6 ms289 ±8 ms+30.5 ms (+11.8%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    5cc1bf5
    • 2023-04-14_17:22:46.017744_uxns
    • 2023-04-14_17:22:46.019872_YdPT
    • 2023-04-14_17:22:46.019882_aCeW
    • 2023-04-14_17:22:46.019888_ZiaU
    • 2023-04-14_17:22:46.020011_gfQn
    • 2023-04-14_17:22:46.020017_tAwQ
    • 2023-04-14_17:22:46.020023_CuZX
    • 2023-04-14_17:22:46.020028_SLxO
    • 2023-04-14_17:22:46.020034_Lkgo
    • 2023-04-14_17:22:46.020039_qMWA
    417c3d7
    • 2023-04-14_17:49:28.166526_kvID
    • 2023-04-14_17:49:28.169812_gjIU
    • 2023-04-14_17:49:28.169823_xYOM
    • 2023-04-14_17:49:28.169830_xbyW
    • 2023-04-14_17:49:28.169836_sdSM
    • 2023-04-14_17:49:28.169845_bJrJ
    • 2023-04-14_17:49:28.169851_fIKB
    • 2023-04-14_17:49:28.169857_vayI
    • 2023-04-14_17:49:28.169862_aXzo
    • 2023-04-14_17:49:28.169867_QLIl

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/dPC3JaqIcd/index.html

@wu-hui wu-hui requested a review from MarkDuckworth March 27, 2023 17:07
@wu-hui wu-hui merged commit f314ff7 into master Apr 14, 2023
@wu-hui wu-hui deleted the wuandy/FixNamedQueryResume branch April 14, 2023 18:24
@firebase firebase locked and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MarkDuckworth MarkDuckworth MarkDuckworth approved these changes

Assignees

@MarkDuckworth MarkDuckworth

Labels
main-merge-ack size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wu-hui @google-oss-bot @MarkDuckworth