Skip to content

Semver check for firebase sdks #4826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Apr 6, 2023
Merged

Semver check for firebase sdks #4826

merged 17 commits into from
Apr 6, 2023

Conversation

VinayGuthal
Copy link
Contributor

@VinayGuthal VinayGuthal commented Mar 27, 2023

Based on the list of changes (specified in DeltaType in the code) we decide if there needs to be a minor/major/patch bump for the current sdk by comparing the current releasable aar and the previous aar obtained from gmaven

@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2023

Javadoc Changes:
--- /Users/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/database/DataSnapshot.html	2023-03-30 17:01:29.000000000 +0000
+++ /Users/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/database/DataSnapshot.html	2023-03-30 16:55:58.000000000 +0000
@@ -53,13 +53,13 @@
             </td>
           </tr>
           <tr>
-            <td><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Nullable.html">Nullable</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a></code></td>
+            <td><code><a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a></code></td>
             <td>
               <div><code><a href="/docs/reference/android/com/google/firebase/database/DataSnapshot.html#getKey()">getKey</a>()</code></div>
             </td>
           </tr>
           <tr>
-            <td><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Nullable.html">Nullable</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a></code></td>
+            <td><code><a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a></code></td>
             <td>
               <div><code><a href="/docs/reference/android/com/google/firebase/database/DataSnapshot.html#getPriority()">getPriority</a>()</code></div>
               <p>Returns the priority of the data contained in this snapshot as a native type.</p>
@@ -73,28 +73,28 @@
             </td>
           </tr>
           <tr>
-            <td><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Nullable.html">Nullable</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a></code></td>
+            <td><code><a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a></code></td>
             <td>
               <div><code><a href="/docs/reference/android/com/google/firebase/database/DataSnapshot.html#getValue()">getValue</a>()</code></div>
               <p>getValue() returns the data contained in this snapshot as native types.</p>
             </td>
           </tr>
           <tr>
-            <td><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Nullable.html">Nullable</a> T</code></td>
+            <td><code>T</code></td>
             <td>
               <div><code>&lt;T&gt; <a href="/docs/reference/android/com/google/firebase/database/DataSnapshot.html#getValue(com.google.firebase.database.GenericTypeIndicator&lt;T&gt;)">getValue</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/database/GenericTypeIndicator.html">GenericTypeIndicator</a>&lt;T&gt;&nbsp;t)</code></div>
               <p>Due to the way that Java implements generics, it takes an extra step to get back a properly-typed Collection.</p>
             </td>
           </tr>
           <tr>
-            <td><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Nullable.html">Nullable</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a></code></td>
+            <td><code><a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a></code></td>
             <td>
               <div><code><a href="/docs/reference/android/com/google/firebase/database/DataSnapshot.html#getValue(boolean)">getValue</a>(boolean&nbsp;useExportFormat)</code></div>
               <p>getValue() returns the data contained in this snapshot as native types.</p>
             </td>
           </tr>
           <tr>
-            <td><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Nullable.html">Nullable</a> T</code></td>
+            <td><code>T</code></td>
             <td>
               <div><code>&lt;T&gt; <a href="/docs/reference/android/com/google/firebase/database/DataSnapshot.html#getValue(java.lang.Class&lt;T&gt;)">getValue</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Class.html">Class</a>&lt;T&gt;&nbsp;valueType)</code></div>
               <p>This method is used to marshall the data contained in this snapshot into a class of your choosing.</p>
@@ -255,7 +255,7 @@
       </div>
       <div class="api-item"><a name="getKey--"></a><a name="getkey"></a>
         <h3 class="api-name" id="getKey()">getKey</h3>
-        <pre class="api-signature no-pretty-print">public&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Nullable.html">Nullable</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/database/DataSnapshot.html#getKey()">getKey</a>()</pre>
+        <pre class="api-signature no-pretty-print">public&nbsp;<a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/database/DataSnapshot.html#getKey()">getKey</a>()</pre>
         <div class="devsite-table-wrapper">
           <table class="responsive">
             <colgroup>
@@ -269,7 +269,7 @@
             </thead>
             <tbody class="list">
               <tr>
-                <td><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Nullable.html">Nullable</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a></code></td>
+                <td><code><a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a></code></td>
                 <td>
                   <p>The key name for the source location of this snapshot or null if this snapshot points to the database root.</p>
                 </td>
@@ -280,7 +280,7 @@
       </div>
       <div class="api-item"><a name="getPriority--"></a><a name="getpriority"></a>
         <h3 class="api-name" id="getPriority()">getPriority</h3>
-        <pre class="api-signature no-pretty-print">public&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Nullable.html">Nullable</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/database/DataSnapshot.html#getPriority()">getPriority</a>()</pre>
+        <pre class="api-signature no-pretty-print">public&nbsp;<a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/database/DataSnapshot.html#getPriority()">getPriority</a>()</pre>
         <p>Returns the priority of the data contained in this snapshot as a native type. Possible return types: </p>
         <ul>
           <li><code>Double</code></li>
@@ -300,7 +300,7 @@
             </thead>
             <tbody class="list">
               <tr>
-                <td><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Nullable.html">Nullable</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a></code></td>
+                <td><code><a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a></code></td>
                 <td>
                   <p>the priority of the data contained in this snapshot as a native type</p>
                 </td>
@@ -337,7 +337,7 @@
       </div>
       <div class="api-item"><a name="getValue--"></a><a name="getvalue"></a>
         <h3 class="api-name" id="getValue()">getValue</h3>
-        <pre class="api-signature no-pretty-print">public&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Nullable.html">Nullable</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/database/DataSnapshot.html#getValue()">getValue</a>()</pre>
+        <pre class="api-signature no-pretty-print">public&nbsp;<a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/database/DataSnapshot.html#getValue()">getValue</a>()</pre>
         <p>getValue() returns the data contained in this snapshot as native types. The possible types returned are: </p>
         <ul>
           <li><code>Boolean</code></li>
@@ -361,7 +361,7 @@
             </thead>
             <tbody class="list">
               <tr>
-                <td><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Nullable.html">Nullable</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a></code></td>
+                <td><code><a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a></code></td>
                 <td>
                   <p>The data contained in this snapshot as native types or null if there is no data at this location.</p>
                 </td>
@@ -372,7 +372,7 @@
       </div>
       <div class="api-item"><a name="getValue-com.google.firebase.database.GenericTypeIndicator&lt;T&gt;-"></a><a name="getvalue"></a>
         <h3 class="api-name" id="getValue(com.google.firebase.database.GenericTypeIndicator&lt;T&gt;)">getValue</h3>
-        <pre class="api-signature no-pretty-print">public&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Nullable.html">Nullable</a> T&nbsp;&lt;T&gt; <a href="/docs/reference/android/com/google/firebase/database/DataSnapshot.html#getValue(com.google.firebase.database.GenericTypeIndicator&lt;T&gt;)">getValue</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/database/GenericTypeIndicator.html">GenericTypeIndicator</a>&lt;T&gt;&nbsp;t)</pre>
+        <pre class="api-signature no-pretty-print">public&nbsp;T&nbsp;&lt;T&gt; <a href="/docs/reference/android/com/google/firebase/database/DataSnapshot.html#getValue(com.google.firebase.database.GenericTypeIndicator&lt;T&gt;)">getValue</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/database/GenericTypeIndicator.html">GenericTypeIndicator</a>&lt;T&gt;&nbsp;t)</pre>
         <p>Due to the way that Java implements generics, it takes an extra step to get back a properly-typed Collection. So, in the case where you want a <code><a href="https://developer.android.com/reference/kotlin/java/util/List.html">java.util.List</a></code> of Message instances, you will need to do something like the following: </p>
         <pre class="prettyprint">    GenericTypeIndicator&lt;List&lt;Message&gt;&gt; t = new GenericTypeIndicator&lt;List&lt;Message&gt;&gt;() {};
     List&lt;Message&gt; messages = snapshot.getValue(t);
@@ -418,7 +418,7 @@
             </thead>
             <tbody class="list">
               <tr>
-                <td><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Nullable.html">Nullable</a> T</code></td>
+                <td><code>T</code></td>
                 <td>
                   <p>A properly typed collection, populated with the data from this snapshot, or null if there is no data at this location.</p>
                 </td>
@@ -429,7 +429,7 @@
       </div>
       <div class="api-item"><a name="getValue-boolean-"></a><a name="getvalue"></a>
         <h3 class="api-name" id="getValue(boolean)">getValue</h3>
-        <pre class="api-signature no-pretty-print">public&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Nullable.html">Nullable</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/database/DataSnapshot.html#getValue(boolean)">getValue</a>(boolean&nbsp;useExportFormat)</pre>
+        <pre class="api-signature no-pretty-print">public&nbsp;<a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/database/DataSnapshot.html#getValue(boolean)">getValue</a>(boolean&nbsp;useExportFormat)</pre>
         <p>getValue() returns the data contained in this snapshot as native types. The possible types returned are: </p>
         <ul>
           <li><code>Boolean</code></li>
@@ -475,7 +475,7 @@
             </thead>
             <tbody class="list">
               <tr>
-                <td><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Nullable.html">Nullable</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a></code></td>
+                <td><code><a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a></code></td>
                 <td>
                   <p>The data in native types, along with its priority, or null if there is no data at this location.</p>
                 </td>
@@ -486,7 +486,7 @@
       </div>
       <div class="api-item"><a name="getValue-java.lang.Class&lt;T&gt;-"></a><a name="getvalue"></a>
         <h3 class="api-name" id="getValue(java.lang.Class&lt;T&gt;)">getValue</h3>
-        <pre class="api-signature no-pretty-print">public&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Nullable.html">Nullable</a> T&nbsp;&lt;T&gt; <a href="/docs/reference/android/com/google/firebase/database/DataSnapshot.html#getValue(java.lang.Class&lt;T&gt;)">getValue</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Class.html">Class</a>&lt;T&gt;&nbsp;valueType)</pre>
+        <pre class="api-signature no-pretty-print">public&nbsp;T&nbsp;&lt;T&gt; <a href="/docs/reference/android/com/google/firebase/database/DataSnapshot.html#getValue(java.lang.Class&lt;T&gt;)">getValue</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Class.html">Class</a>&lt;T&gt;&nbsp;valueType)</pre>
         <p>This method is used to marshall the data contained in this snapshot into a class of your choosing. The class must fit 2 simple constraints: </p>
         <ol>
           <li>The class must have a default constructor that takes no arguments </li>
@@ -557,7 +557,7 @@
             </thead>
             <tbody class="list">
               <tr>
-                <td><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Nullable.html">Nullable</a> T</code></td>
+                <td><code>T</code></td>
                 <td>
                   <p>An instance of the class passed in, populated with the data from this snapshot, or null if there is no data at this location.</p>
                 </td>
--- /Users/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/functions/FirebaseFunctions.html	2023-03-30 17:01:59.000000000 +0000
+++ /Users/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/functions/FirebaseFunctions.html	2023-03-30 16:56:26.000000000 +0000
@@ -21,6 +21,27 @@
         </colgroup>
         <thead>
           <tr>
+            <th colspan="100%"><h3>Public fields</h3></th>
+          </tr>
+        </thead>
+        <tbody class="list">
+          <tr>
+            <td><code>final <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a></code></td>
+            <td>
+              <div><code><a href="/docs/reference/android/com/google/firebase/functions/FirebaseFunctions.html#hello()">hello</a></code></div>
+            </td>
+          </tr>
+        </tbody>
+      </table>
+    </div>
+    <div class="devsite-table-wrapper">
+      <table class="responsive">
+        <colgroup>
+          <col width="40%">
+          <col>
+        </colgroup>
+        <thead>
+          <tr>
             <th colspan="100%"><h3>Public methods</h3></th>
           </tr>
         </thead>
@@ -87,6 +108,13 @@
       </table>
     </div>
     <div class="list">
+      <h2>Public fields</h2>
+      <div class="api-item"><a name="getHello()"></a><a name="setHello()"></a><a name="getHello--"></a><a name="setHello--"></a>
+        <h3 class="api-name" id="hello()">hello</h3>
+        <pre class="api-signature no-pretty-print">public&nbsp;final&nbsp;<a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/functions/FirebaseFunctions.html#hello()">hello</a></pre>
+      </div>
+    </div>
+    <div class="list">
       <h2>Public methods</h2>
       <div class="api-item"><a name="getHttpsCallable-java.lang.String-"></a><a name="gethttpscallable"></a>
         <h3 class="api-name" id="getHttpsCallable(java.lang.String)">getHttpsCallable</h3>
--- /Users/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/database/DataSnapshot.html	2023-03-30 17:01:29.000000000 +0000
+++ /Users/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/database/DataSnapshot.html	2023-03-30 16:55:58.000000000 +0000
@@ -53,13 +53,13 @@
             </td>
           </tr>
           <tr>
-            <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>?</code></td>
+            <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>!</code></td>
             <td>
               <div><code><a href="/docs/reference/kotlin/com/google/firebase/database/DataSnapshot.html#getKey()">getKey</a>()</code></div>
             </td>
           </tr>
           <tr>
-            <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>?</code></td>
+            <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>!</code></td>
             <td>
               <div><code><a href="/docs/reference/kotlin/com/google/firebase/database/DataSnapshot.html#getPriority()">getPriority</a>()</code></div>
               <p>Returns the priority of the data contained in this snapshot as a native type.</p>
@@ -73,28 +73,28 @@
             </td>
           </tr>
           <tr>
-            <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>?</code></td>
+            <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>!</code></td>
             <td>
               <div><code><a href="/docs/reference/kotlin/com/google/firebase/database/DataSnapshot.html#getValue()">getValue</a>()</code></div>
               <p>getValue() returns the data contained in this snapshot as native types.</p>
             </td>
           </tr>
           <tr>
-            <td><code>T?</code></td>
+            <td><code>T!</code></td>
             <td>
               <div><code>&lt;T&gt; <a href="/docs/reference/kotlin/com/google/firebase/database/DataSnapshot.html#getValue(com.google.firebase.database.GenericTypeIndicator&lt;T&gt;)">getValue</a>(t:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/database/GenericTypeIndicator.html">GenericTypeIndicator</a>&lt;T!&gt;)</code></div>
               <p>Due to the way that Java implements generics, it takes an extra step to get back a properly-typed Collection.</p>
             </td>
           </tr>
           <tr>
-            <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>?</code></td>
+            <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>!</code></td>
             <td>
               <div><code><a href="/docs/reference/kotlin/com/google/firebase/database/DataSnapshot.html#getValue(boolean)">getValue</a>(useExportFormat:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-boolean/index.html">Boolean</a>)</code></div>
               <p>getValue() returns the data contained in this snapshot as native types.</p>
             </td>
           </tr>
           <tr>
-            <td><code>T?</code></td>
+            <td><code>T!</code></td>
             <td>
               <div><code>&lt;T&gt; <a href="/docs/reference/kotlin/com/google/firebase/database/DataSnapshot.html#getValue(java.lang.Class&lt;T&gt;)">getValue</a>(valueType:&nbsp;<a href="https://developer.android.com/reference/kotlin/java/lang/Class.html">Class</a>&lt;T!&gt;)</code></div>
               <p>This method is used to marshall the data contained in this snapshot into a class of your choosing.</p>
@@ -255,7 +255,7 @@
       </div>
       <div class="api-item"><a name="getKey--"></a><a name="getkey"></a>
         <h3 class="api-name" id="getKey()">getKey</h3>
-        <pre class="api-signature no-pretty-print">fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/database/DataSnapshot.html#getKey()">getKey</a>():&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>?</pre>
+        <pre class="api-signature no-pretty-print">fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/database/DataSnapshot.html#getKey()">getKey</a>():&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>!</pre>
         <div class="devsite-table-wrapper">
           <table class="responsive">
             <colgroup>
@@ -269,7 +269,7 @@
             </thead>
             <tbody class="list">
               <tr>
-                <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>?</code></td>
+                <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>!</code></td>
                 <td>
                   <p>The key name for the source location of this snapshot or null if this snapshot points to the database root.</p>
                 </td>
@@ -280,7 +280,7 @@
       </div>
       <div class="api-item"><a name="getPriority--"></a><a name="getpriority"></a>
         <h3 class="api-name" id="getPriority()">getPriority</h3>
-        <pre class="api-signature no-pretty-print">fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/database/DataSnapshot.html#getPriority()">getPriority</a>():&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>?</pre>
+        <pre class="api-signature no-pretty-print">fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/database/DataSnapshot.html#getPriority()">getPriority</a>():&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>!</pre>
         <p>Returns the priority of the data contained in this snapshot as a native type. Possible return types: </p>
         <ul>
           <li><code>Double</code></li>
@@ -300,7 +300,7 @@
             </thead>
             <tbody class="list">
               <tr>
-                <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>?</code></td>
+                <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>!</code></td>
                 <td>
                   <p>the priority of the data contained in this snapshot as a native type</p>
                 </td>
@@ -337,7 +337,7 @@
       </div>
       <div class="api-item"><a name="getValue--"></a><a name="getvalue"></a>
         <h3 class="api-name" id="getValue()">getValue</h3>
-        <pre class="api-signature no-pretty-print">fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/database/DataSnapshot.html#getValue()">getValue</a>():&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>?</pre>
+        <pre class="api-signature no-pretty-print">fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/database/DataSnapshot.html#getValue()">getValue</a>():&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>!</pre>
         <p>getValue() returns the data contained in this snapshot as native types. The possible types returned are: </p>
         <ul>
           <li><code>Boolean</code></li>
@@ -361,7 +361,7 @@
             </thead>
             <tbody class="list">
               <tr>
-                <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>?</code></td>
+                <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>!</code></td>
                 <td>
                   <p>The data contained in this snapshot as native types or null if there is no data at this location.</p>
                 </td>
@@ -372,7 +372,7 @@
       </div>
       <div class="api-item"><a name="getValue-com.google.firebase.database.GenericTypeIndicator&lt;T&gt;-"></a><a name="getvalue"></a>
         <h3 class="api-name" id="getValue(com.google.firebase.database.GenericTypeIndicator&lt;T&gt;)">getValue</h3>
-        <pre class="api-signature no-pretty-print">fun&nbsp;&lt;T&gt; <a href="/docs/reference/kotlin/com/google/firebase/database/DataSnapshot.html#getValue(com.google.firebase.database.GenericTypeIndicator&lt;T&gt;)">getValue</a>(t:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/database/GenericTypeIndicator.html">GenericTypeIndicator</a>&lt;T!&gt;):&nbsp;T?</pre>
+        <pre class="api-signature no-pretty-print">fun&nbsp;&lt;T&gt; <a href="/docs/reference/kotlin/com/google/firebase/database/DataSnapshot.html#getValue(com.google.firebase.database.GenericTypeIndicator&lt;T&gt;)">getValue</a>(t:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/database/GenericTypeIndicator.html">GenericTypeIndicator</a>&lt;T!&gt;):&nbsp;T!</pre>
         <p>Due to the way that Java implements generics, it takes an extra step to get back a properly-typed Collection. So, in the case where you want a <code><a href="https://developer.android.com/reference/kotlin/java/util/List.html">java.util.List</a></code> of Message instances, you will need to do something like the following: </p>
         <pre class="prettyprint">    GenericTypeIndicator&lt;List&lt;Message&gt;&gt; t = new GenericTypeIndicator&lt;List&lt;Message&gt;&gt;() {};
     List&lt;Message&gt; messages = snapshot.getValue(t);
@@ -418,7 +418,7 @@
             </thead>
             <tbody class="list">
               <tr>
-                <td><code>T?</code></td>
+                <td><code>T!</code></td>
                 <td>
                   <p>A properly typed collection, populated with the data from this snapshot, or null if there is no data at this location.</p>
                 </td>
@@ -429,7 +429,7 @@
       </div>
       <div class="api-item"><a name="getValue-boolean-"></a><a name="getvalue"></a>
         <h3 class="api-name" id="getValue(boolean)">getValue</h3>
-        <pre class="api-signature no-pretty-print">fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/database/DataSnapshot.html#getValue(boolean)">getValue</a>(useExportFormat:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-boolean/index.html">Boolean</a>):&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>?</pre>
+        <pre class="api-signature no-pretty-print">fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/database/DataSnapshot.html#getValue(boolean)">getValue</a>(useExportFormat:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-boolean/index.html">Boolean</a>):&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>!</pre>
         <p>getValue() returns the data contained in this snapshot as native types. The possible types returned are: </p>
         <ul>
           <li><code>Boolean</code></li>
@@ -475,7 +475,7 @@
             </thead>
             <tbody class="list">
               <tr>
-                <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>?</code></td>
+                <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>!</code></td>
                 <td>
                   <p>The data in native types, along with its priority, or null if there is no data at this location.</p>
                 </td>
@@ -486,7 +486,7 @@
       </div>
       <div class="api-item"><a name="getValue-java.lang.Class&lt;T&gt;-"></a><a name="getvalue"></a>
         <h3 class="api-name" id="getValue(java.lang.Class&lt;T&gt;)">getValue</h3>
-        <pre class="api-signature no-pretty-print">fun&nbsp;&lt;T&gt; <a href="/docs/reference/kotlin/com/google/firebase/database/DataSnapshot.html#getValue(java.lang.Class&lt;T&gt;)">getValue</a>(valueType:&nbsp;<a href="https://developer.android.com/reference/kotlin/java/lang/Class.html">Class</a>&lt;T!&gt;):&nbsp;T?</pre>
+        <pre class="api-signature no-pretty-print">fun&nbsp;&lt;T&gt; <a href="/docs/reference/kotlin/com/google/firebase/database/DataSnapshot.html#getValue(java.lang.Class&lt;T&gt;)">getValue</a>(valueType:&nbsp;<a href="https://developer.android.com/reference/kotlin/java/lang/Class.html">Class</a>&lt;T!&gt;):&nbsp;T!</pre>
         <p>This method is used to marshall the data contained in this snapshot into a class of your choosing. The class must fit 2 simple constraints: </p>
         <ol>
           <li>The class must have a default constructor that takes no arguments </li>
@@ -557,7 +557,7 @@
             </thead>
             <tbody class="list">
               <tr>
-                <td><code>T?</code></td>
+                <td><code>T!</code></td>
                 <td>
                   <p>An instance of the class passed in, populated with the data from this snapshot, or null if there is no data at this location.</p>
                 </td>
--- /Users/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/functions/FirebaseFunctions.html	2023-03-30 17:01:59.000000000 +0000
+++ /Users/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/functions/FirebaseFunctions.html	2023-03-30 16:56:26.000000000 +0000
@@ -86,6 +86,27 @@
         </tbody>
       </table>
     </div>
+    <div class="devsite-table-wrapper">
+      <table class="responsive">
+        <colgroup>
+          <col width="40%">
+          <col>
+        </colgroup>
+        <thead>
+          <tr>
+            <th colspan="100%"><h3>Public properties</h3></th>
+          </tr>
+        </thead>
+        <tbody class="list">
+          <tr>
+            <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>!</code></td>
+            <td>
+              <div><code><a href="/docs/reference/kotlin/com/google/firebase/functions/FirebaseFunctions.html#hello()">hello</a></code></div>
+            </td>
+          </tr>
+        </tbody>
+      </table>
+    </div>
     <div class="list">
       <h2>Public functions</h2>
       <div class="api-item"><a name="getHttpsCallable-java.lang.String-"></a><a name="gethttpscallable"></a>
@@ -230,6 +251,13 @@
         </aside>
       </div>
     </div>
+    <div class="list">
+      <h2>Public properties</h2>
+      <div class="api-item"><a name="getHello()"></a><a name="setHello()"></a><a name="getHello--"></a><a name="setHello--"></a>
+        <h3 class="api-name" id="hello()">hello</h3>
+        <pre class="api-signature no-pretty-print">val&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/functions/FirebaseFunctions.html#hello()">hello</a>:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>!</pre>
+      </div>
+    </div>
   </body>
 </html>
 

@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2023

buildSrc Test Results

28 tests   28 ✔️  1m 20s ⏱️
  5 suites    0 💤
  5 files      0

Results for commit 9afe607.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2023

Unit Test Results

   788 files  +  57     788 suites  +57   36m 24s ⏱️ + 7m 21s
4 854 tests +  76  4 831 ✔️ +  75  21 💤 ±0  2 +1 
9 617 runs  +676  9 573 ✔️ +675  42 💤 ±0  2 +1 

For more details on these failures, see this check.

Results for commit 9afe607. ± Comparison against base commit 1320a47.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 27, 2023

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 27, 2023

Coverage Report 1

Affected Products

  • firebase-storage

    Overall coverage changed from ? (73db13a) to 85.86% (e05440f) by ?.

    46 individual files with coverage change

    FilenameBase (73db13a)Merge (e05440f)Diff
    ActivityLifecycleListener.java?74.14%?
    AdaptiveStreamBuffer.java?84.62%?
    CancelException.java?100.00%?
    CancellableTask.java?100.00%?
    ControllableTask.java?100.00%?
    DeleteNetworkRequest.java?100.00%?
    DeleteStorageTask.java?100.00%?
    ExponentialBackoffSender.java?86.00%?
    FileDownloadTask.java?80.00%?
    FirebaseStorage.java?83.67%?
    FirebaseStorageComponent.java?100.00%?
    GetDownloadUrlTask.java?96.77%?
    GetMetadataNetworkRequest.java?100.00%?
    GetMetadataTask.java?85.19%?
    GetNetworkRequest.java?100.00%?
    HttpURLConnectionFactory.java?0.00%?
    HttpURLConnectionFactoryImpl.java?50.00%?
    ListNetworkRequest.java?100.00%?
    ListResult.java?100.00%?
    ListTask.java?85.71%?
    NetworkRequest.java?86.60%?
    OnPausedListener.java?0.00%?
    OnProgressListener.java?0.00%?
    ResumableNetworkRequest.java?100.00%?
    ResumableUploadByteRequest.java?90.91%?
    ResumableUploadCancelRequest.java?100.00%?
    ResumableUploadQueryRequest.java?100.00%?
    ResumableUploadStartRequest.java?95.24%?
    Slashes.java?88.24%?
    Sleeper.java?0.00%?
    SleeperImpl.java?100.00%?
    SmartHandler.java?87.50%?
    StorageException.java?65.45%?
    StorageMetadata.java?86.34%?
    StorageReference.java?89.94%?
    StorageReferenceUri.java?100.00%?
    StorageRegistrar.java?100.00%?
    StorageTask.java?83.38%?
    StorageTaskManager.java?100.00%?
    StorageTaskScheduler.java?100.00%?
    StreamDownloadTask.java?88.89%?
    TaskListenerImpl.java?100.00%?
    UpdateMetadataNetworkRequest.java?100.00%?
    UpdateMetadataTask.java?82.14%?
    UploadTask.java?81.79%?
    Util.java?73.24%?

  • firebase-messaging

    FilenameBase (73db13a)Merge (e05440f)Diff
    FirebaseMessaging.java76.21%75.77%-0.44%
    MessagingAnalytics.java81.38%81.78%+0.40%
  • firebase-firestore

    FilenameBase (73db13a)Merge (e05440f)Diff
    PatchMutation.java100.00%98.39%-1.61%
    SetMutation.java94.44%97.22%+2.78%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/maBf9xxlvq.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 27, 2023

Startup Time Report 1

The report is too large (117,087 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/PQxbJfromB/index.html

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-functions:
error: Added field com.google.firebase.functions.FirebaseFunctions.hello [AddedField]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

import org.objectweb.asm.tree.FieldNode
import org.objectweb.asm.tree.MethodNode

class ClassInfo(val _node: ClassNode, val _classNodes: Map<String, ClassNode>) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From https://developer.android.com/kotlin/style-guide#backing-properties seems like the use of _<name> is as a backing property to allow you to expose <name> using a getter. But _node is exposed as is. And _classNodes are only in the call to getAllMethods()

@VinayGuthal VinayGuthal requested a review from rlazo April 6, 2023 18:14
@VinayGuthal VinayGuthal merged commit fe8c9df into master Apr 6, 2023
@VinayGuthal VinayGuthal deleted the semver_check branch April 6, 2023 19:45
@firebase firebase locked and limited conversation to collaborators May 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants