Skip to content

Remove Javadoc + Fireescape artifacts from releasing jars #4833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 31, 2023

Conversation

daymxn
Copy link
Member

@daymxn daymxn commented Mar 29, 2023

Per b/275751188,

We no longer utilize thefireescape.jar bundled in our released jars, so I've removed its generation and references.

Per b/275755115,

We have decided to drop the javadoc jar from our released jars. As an oversight, it has been empty for quite a while- and in noticing it now, after some evaluation, we've decided to just drop it completely.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2023

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended.

@github-actions
Copy link
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended.

1 similar comment
@github-actions
Copy link
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended.

@github-actions
Copy link
Contributor

buildSrc Test Results

28 tests   28 ✔️  2m 10s ⏱️
  5 suites    0 💤
  5 files      0

Results for commit 1f97326.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2023

Unit Test Results

   774 files  ±0     774 suites  ±0   32m 54s ⏱️ +2s
4 853 tests ±0  4 831 ✔️  - 1  21 💤 ±0  1 +1 
9 503 runs  ±0  9 460 ✔️  - 1  42 💤 ±0  1 +1 

For more details on these failures, see this check.

Results for commit 1f97326. ± Comparison against base commit d72542b.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.16% (d72542b) to 50.13% (4fa76d9) by -0.03%.

    FilenameBase (d72542b)Merge (4fa76d9)Diff
    DoubleNode.java88.24%100.00%+11.76%
    QueryParams.java90.36%89.76%-0.60%
    WebsocketConnection.java35.03%32.77%-2.26%
  • firebase-firestore

    Overall coverage changed from 44.18% (d72542b) to 44.17% (4fa76d9) by -0.01%.

    FilenameBase (d72542b)Merge (4fa76d9)Diff
    DeleteMutation.java95.24%90.48%-4.76%
    PatchMutation.java100.00%98.39%-1.61%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/pUIC21v7BW.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 29, 2023

Startup Time Report 1

The report is too large (117,099 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/XP8rRlxRoZ/index.html

@daymxn daymxn merged commit b68c1f6 into master Mar 31, 2023
@daymxn daymxn deleted the daymon-remove-extra-zips branch March 31, 2023 17:40
@firebase firebase locked and limited conversation to collaborators May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants