-
Notifications
You must be signed in to change notification settings - Fork 624
Remove Javadoc + Fireescape artifacts from releasing jars #4833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended. |
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended. |
1 similar comment
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended. |
Unit Test Results 774 files ±0 774 suites ±0 32m 54s ⏱️ +2s For more details on these failures, see this check. Results for commit 1f97326. ± Comparison against base commit d72542b. ♻️ This comment has been updated with latest results. |
Size Report 1Affected ProductsNo changes between base commit (d72542b) and merge commit (4fa76d9).Test Logs |
Coverage Report 1Affected Products
Test Logs |
Per b/275751188,
We no longer utilize the
fireescape.jar
bundled in our released jars, so I've removed its generation and references.Per b/275755115,
We have decided to drop the javadoc jar from our released jars. As an oversight, it has been empty for quite a while- and in noticing it now, after some evaluation, we've decided to just drop it completely.