Skip to content

Fix Firebase Sessions test app temporarily #4858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2023
Merged

Fix Firebase Sessions test app temporarily #4858

merged 1 commit into from
Apr 5, 2023

Conversation

samedson
Copy link
Contributor

@samedson samedson commented Apr 5, 2023 •
edited
Loading

Needs to depend on Sessions because it's not eager.

@samedson samedson requested a review from mrober April 5, 2023 19:47
@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

No changes between base commit (9300b74) and merge commit (323178c).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/CeggmmQenu.html

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 58e1eb1.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (9300b74) and merge commit (323178c).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/aJZLK0BYZr.html

@samedson samedson merged commit e7050b3 into firebase-sessions Apr 5, 2023
@samedson samedson deleted the testapp branch April 5, 2023 20:44
@firebase firebase locked and limited conversation to collaborators May 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrober mrober mrober approved these changes

Assignees
No one assigned
Labels
api: sessions size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samedson @google-oss-bot @mrober