Refactor Publisher #4879
Merged
Refactor Publisher #4879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Coverage Report 1Affected Products
Test Logs |
rlazo
reviewed
Apr 11, 2023
buildSrc/src/main/java/com/google/firebase/gradle/plugins/BaseFirebaseLibraryPlugin.kt
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/com/google/firebase/gradle/plugins/BaseFirebaseLibraryPlugin.kt
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/com/google/firebase/gradle/plugins/BaseFirebaseLibraryPlugin.kt
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/com/google/firebase/gradle/plugins/BaseFirebaseLibraryPlugin.kt
Show resolved
Hide resolved
buildSrc/src/main/java/com/google/firebase/gradle/plugins/BaseFirebaseLibraryPlugin.kt
Outdated
Show resolved
Hide resolved
davidmotson
approved these changes
Apr 11, 2023
buildSrc/src/main/java/com/google/firebase/gradle/plugins/KotlinUtils.kt
Show resolved
Hide resolved
rlazo
approved these changes
Apr 12, 2023
rlazo
reviewed
Apr 17, 2023
buildSrc/src/main/java/com/google/firebase/gradle/plugins/publish/PublishingPlugin.java
Show resolved
Hide resolved
rlazo
reviewed
Apr 17, 2023
buildSrc/src/test/kotlin/com/google/firebase/gradle/plugins/PublishingPluginTests.kt
Outdated
Show resolved
Hide resolved
buildSrc/src/test/kotlin/com/google/firebase/gradle/plugins/PublishingPluginTests.kt
Outdated
Show resolved
Hide resolved
Size Report 1Affected ProductsNo changes between base commit (8840eee) and merge commit (cab6fe9).Test Logs |
rlazo
approved these changes
Apr 17, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per b/277637432,
This removes the
Publisherclass, and refactors the functionality that we still need intoBaseFirebaseLibraryPlugin. This PR also comes with some optimizations and QOL improvements, such as;afterEvaluateto where it's actually needed, instead of wrapping all of our publishing configuration in it (which will allow earlier access to the publishing plugin)