Use test app for Sessions e2e test #4881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Report 1Affected Products
Test Logs |
samedson
approved these changes
Apr 11, 2023
visumickey
reviewed
Apr 11, 2023
...test-app/src/androidTest/kotlin/com/google/firebase/testing/sessions/FirebaseSessionsTest.kt
Outdated
Show resolved
Hide resolved
| androidTestImplementation("com.google.firebase:firebase-common-ktx:20.3.2") | ||
| androidTestImplementation(libs.androidx.test.junit) | ||
| androidTestImplementation(libs.androidx.test.runner) | ||
| androidTestImplementation(libs.truth) |
There was a problem hiding this comment.
Why do we need this dependency? truth
There was a problem hiding this comment.
I prefer using Guava's Truth than JUnit's regular asserts. Truth reads much better, and other Firebase SDKs use it in their tests too.
There was a problem hiding this comment.
My comment was in the context of why we use that for the test app. For SDK's it makes sense to me. Do we have tests for the test app and we are using Guava's truth library for that?
There was a problem hiding this comment.
Oh is there any reason we should avoid it?
Right now we do 1 Truth.assertThat(...) on the placeholder api. That is how the test verifies that Sessions and everything got initialized correctly in the test app for now. We could make a simpler assert like that the instance is not null? But after my TODO is resolved, I expect to add different asserts on the logs. E.g. assert that the session was successfully sent to firelog.
Coverage Report 1This report is too large (209,912 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Startup time comparison between the CI merge commit (987a052) and the base commit (229d597) are not available. No macrobenchmark data found for the base commit (229d597). Analysis for the CI merge commit (987a052) can be found at: |
visumickey
approved these changes
Apr 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.