Skip to content

Move currentTimeUs into WallClock #4890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2023
Merged

Move currentTimeUs into WallClock #4890

merged 1 commit into from
Apr 13, 2023

Conversation

samedson
Copy link
Contributor

Follow up from #4870 (comment)

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from ? (78f303c) to 65.09% (1736570) by ?.

    14 individual files with coverage change

    FilenameBase (78f303c)Merge (1736570)Diff
    ApplicationInfo.kt?100.00%?
    EventGDTLogger.kt?75.00%?
    FirebaseSessions.kt?0.00%?
    FirebaseSessionsEarly.kt?0.00%?
    FirebaseSessionsRegistrar.kt?0.00%?
    LocalOverrideSettings.kt?90.00%?
    SessionCoordinator.kt?76.47%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?97.06%?
    SessionGenerator.kt?22.73%?
    SessionInitiator.kt?66.67%?
    SessionsSettings.kt?84.62%?
    SettingsProvider.kt?0.00%?
    WallClock.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/o9I1aTzfa6.html

@github-actions
Copy link
Contributor

Unit Test Results

18 files  18 suites   21s ⏱️
22 tests 22 ✔️ 0 💤 0 ❌
44 runs  44 ✔️ 0 💤 0 ❌

Results for commit 263ae6e.

@firebase firebase deleted a comment from google-oss-bot Apr 13, 2023
@samedson samedson requested a review from mrober April 13, 2023 15:29
@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • base

    TypeBase (78f303c)Merge (1736570)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)

  • firebase-datatransport

    TypeBase (78f303c)Merge (1736570)Diff
    aar?4.94 kB? (?)
    apk (aggressive)?161 kB? (?)
    apk (release)?1.35 MB? (?)

  • firebase-sessions

    TypeBase (78f303c)Merge (1736570)Diff
    aar?47.8 kB? (?)
    apk (aggressive)?251 kB? (?)
    apk (release)?1.77 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/bCJMm0mTqi.html

@samedson samedson merged commit 32f5d93 into firebase-sessions Apr 13, 2023
@samedson samedson deleted the wall-clock branch April 13, 2023 16:11
@firebase firebase locked and limited conversation to collaborators May 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrober mrober mrober approved these changes

Assignees
No one assigned
Labels
no-changelog size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samedson @google-oss-bot @mrober