Skip to content

Populate sampling rate in session event #4891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 14, 2023
Merged

Conversation

mrober
Copy link
Contributor

@mrober mrober commented Apr 13, 2023

Populate sampling rate in session event.

I also refactored the fake firebase app a bit to make it easier to access it multiple times inside one test.
And I am playing with a way to use the test data but override 1 value nested a bit deep into the data class.

mrober added 3 commits April 13, 2023 13:24
# Conflicts:
#	firebase-sessions/src/main/kotlin/com/google/firebase/sessions/SessionEvents.kt
@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from ? (32f5d93) to 65.22% (a8485a4) by ?.

    14 individual files with coverage change

    FilenameBase (32f5d93)Merge (a8485a4)Diff
    ApplicationInfo.kt?100.00%?
    EventGDTLogger.kt?75.00%?
    FirebaseSessions.kt?0.00%?
    FirebaseSessionsEarly.kt?0.00%?
    FirebaseSessionsRegistrar.kt?0.00%?
    LocalOverrideSettings.kt?90.00%?
    SessionCoordinator.kt?76.47%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?97.10%?
    SessionGenerator.kt?22.73%?
    SessionInitiator.kt?66.67%?
    SessionsSettings.kt?84.62%?
    SettingsProvider.kt?0.00%?
    WallClock.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/3Muoar02Iy.html

@github-actions
Copy link
Contributor

Unit Test Results

18 files  18 suites   19s ⏱️
23 tests 23 ✔️ 0 💤 0
46 runs  46 ✔️ 0 💤 0

Results for commit b86d1b4.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • base

    TypeBase (32f5d93)Merge (a8485a4)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)
  • firebase-datatransport

    TypeBase (32f5d93)Merge (a8485a4)Diff
    aar?4.94 kB? (?)
    apk (aggressive)?161 kB? (?)
    apk (release)?1.35 MB? (?)
  • firebase-sessions

    TypeBase (32f5d93)Merge (a8485a4)Diff
    aar?47.9 kB? (?)
    apk (aggressive)?251 kB? (?)
    apk (release)?1.77 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/CfoQ341809.html

@mrober mrober merged commit 7ca2763 into firebase-sessions Apr 14, 2023
@mrober mrober deleted the sessions-sampling branch April 14, 2023 14:11
@firebase firebase locked and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants