Skip to content

Fix warning about mismatch between java/kotlin target version #4893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2023
Merged

Fix warning about mismatch between java/kotlin target version #4893

merged 1 commit into from
Apr 14, 2023

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Apr 14, 2023

No description provided.

@rlazo rlazo requested a review from davidmotson April 14, 2023 05:29
@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2023 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@github-actions
Copy link
Contributor

buildSrc Test Results

28 tests   28 ✔️  1m 38s ⏱️
  5 suites    0 💤
  5 files      0 ❌

Results for commit 13973fc.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2023 •
edited
Loading

Unit Test Results

   788 files  +     75     788 suites  +75   34m 52s ⏱️ - 2m 10s
4 859 tests ±       0  4 838 ✔️ +       2  21 💤 ±  0  0 ❌  - 2 
9 627 runs  +1 110  9 585 ✔️ +1 096  42 💤 +16  0 ❌  - 2 

Results for commit 13973fc. ± Comparison against base commit 7375cab.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (7375cab) and merge commit (394f49f).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ZGzVSpcxsu.html

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.16% (7375cab) to 50.18% (394f49f) by +0.01%.

    FilenameBase (7375cab)Merge (394f49f)Diff
    ChildChangeAccumulator.java83.33%96.67%+13.33%
    ViewProcessor.java91.79%92.10%+0.30%
    WebsocketConnection.java35.03%32.77%-2.26%

  • firebase-firestore

    Overall coverage changed from 44.08% (7375cab) to 44.08% (394f49f) by +0.00%.

    FilenameBase (7375cab)Merge (394f49f)Diff
    PatchMutation.java98.39%100.00%+1.61%

  • firebase-storage

    Overall coverage changed from ? (7375cab) to 85.86% (394f49f) by ?.

    46 individual files with coverage change

    FilenameBase (7375cab)Merge (394f49f)Diff
    ActivityLifecycleListener.java?74.14%?
    AdaptiveStreamBuffer.java?84.62%?
    CancelException.java?100.00%?
    CancellableTask.java?100.00%?
    ControllableTask.java?100.00%?
    DeleteNetworkRequest.java?100.00%?
    DeleteStorageTask.java?100.00%?
    ExponentialBackoffSender.java?86.00%?
    FileDownloadTask.java?80.00%?
    FirebaseStorage.java?83.67%?
    FirebaseStorageComponent.java?100.00%?
    GetDownloadUrlTask.java?96.77%?
    GetMetadataNetworkRequest.java?100.00%?
    GetMetadataTask.java?85.19%?
    GetNetworkRequest.java?100.00%?
    HttpURLConnectionFactory.java?0.00%?
    HttpURLConnectionFactoryImpl.java?50.00%?
    ListNetworkRequest.java?100.00%?
    ListResult.java?100.00%?
    ListTask.java?85.71%?
    NetworkRequest.java?86.60%?
    OnPausedListener.java?0.00%?
    OnProgressListener.java?0.00%?
    ResumableNetworkRequest.java?100.00%?
    ResumableUploadByteRequest.java?90.91%?
    ResumableUploadCancelRequest.java?100.00%?
    ResumableUploadQueryRequest.java?100.00%?
    ResumableUploadStartRequest.java?95.24%?
    Slashes.java?88.24%?
    Sleeper.java?0.00%?
    SleeperImpl.java?100.00%?
    SmartHandler.java?87.50%?
    StorageException.java?65.45%?
    StorageMetadata.java?86.34%?
    StorageReference.java?89.94%?
    StorageReferenceUri.java?100.00%?
    StorageRegistrar.java?100.00%?
    StorageTask.java?83.38%?
    StorageTaskManager.java?100.00%?
    StorageTaskScheduler.java?100.00%?
    StreamDownloadTask.java?88.89%?
    TaskListenerImpl.java?100.00%?
    UpdateMetadataNetworkRequest.java?100.00%?
    UpdateMetadataTask.java?82.14%?
    UploadTask.java?81.79%?
    Util.java?73.24%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/erWZWRnMci.html

@rlazo rlazo requested a review from daymxn April 14, 2023 06:14
@rlazo
Copy link
Collaborator Author

rlazo commented Apr 14, 2023

For reference, this is only necessary until we jump to gradle 8

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

The report is too large (117,068 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/SSSQjOdvW1/index.html

daymxn
daymxn approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@daymxn daymxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:OOO

@rlazo rlazo merged commit 5cc1bf5 into master Apr 14, 2023
@rlazo rlazo deleted the rl.mismatch89 branch April 14, 2023 17:06
@firebase firebase locked and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daymxn daymxn daymxn approved these changes

@davidmotson davidmotson Awaiting requested review from davidmotson

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rlazo @google-oss-bot @daymxn