Skip to content

Use to setup-java@v3 to Node16 (@v2 uses node12 which is deprecated) #4902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2023
Merged

Use to setup-java@v3 to Node16 (@v2 uses node12 which is deprecated) #4902

merged 1 commit into from
Apr 17, 2023

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Apr 17, 2023

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2023 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@github-actions
Copy link
Contributor

Unit Test Results

   788 files  +  25     788 suites  +25   36m 37s ⏱️ + 4m 45s
4 864 tests ±    0  4 843 ✔️ +    1  21 💤 ±0  0 ❌  - 1 
9 637 runs  +471  9 595 ✔️ +472  42 💤 ±0  0 ❌  - 1 

Results for commit 1927efb. ± Comparison against base commit 734adc0.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (734adc0) and merge commit (e9b6793).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Xap8lJK0D6.html

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.22% (734adc0) to 50.14% (e9b6793) by -0.08%.

    FilenameBase (734adc0)Merge (e9b6793)Diff
    ChildChangeAccumulator.java96.67%83.33%-13.33%
    DefaultPersistenceManager.java74.76%75.73%+0.97%
    WebsocketConnection.java35.03%32.77%-2.26%

  • firebase-installations

    Overall coverage changed from ? (734adc0) to 58.61% (e9b6793) by ?.

    22 individual files with coverage change

    FilenameBase (734adc0)Merge (e9b6793)Diff
    AutoValue_InstallationResponse.java?58.93%?
    AutoValue_PersistedInstallationEntry.java?61.18%?
    AutoValue_TokenResult.java?45.65%?
    AwaitListener.java?0.00%?
    Clock.java?0.00%?
    CrossProcessLock.java?51.85%?
    FirebaseInstallations.java?96.62%?
    FirebaseInstallationServiceClient.java?4.80%?
    FirebaseInstallationsException.java?78.57%?
    FirebaseInstallationsRegistrar.java?100.00%?
    GetAuthTokenListener.java?100.00%?
    GetIdListener.java?70.00%?
    IidStore.java?22.39%?
    InstallationResponse.java?100.00%?
    PersistedInstallation.java?97.01%?
    PersistedInstallationEntry.java?100.00%?
    RandomFidGenerator.java?20.00%?
    RequestLimiter.java?100.00%?
    StateListener.java?0.00%?
    SystemClock.java?100.00%?
    TokenResult.java?100.00%?
    Utils.java?95.00%?

  • firebase-messaging

    Overall coverage changed from 85.18% (734adc0) to 85.22% (e9b6793) by +0.04%.

    FilenameBase (734adc0)Merge (e9b6793)Diff
    MessagingAnalytics.java81.38%81.78%+0.40%

  • firebase-ml-modeldownloader

    Overall coverage changed from ? (734adc0) to 0.00% (e9b6793) by ?.

    35 individual files with coverage change

    FilenameBase (734adc0)Merge (e9b6793)Diff
    AutoFirebaseMlLogEventEncoder.java?0.00%?
    AutoValue_FirebaseMlLogEvent.java?0.00%?
    AutoValue_FirebaseMlLogEvent_DeleteModelLogEvent.java?0.00%?
    AutoValue_FirebaseMlLogEvent_ModelDownloadLogEvent.java?0.00%?
    AutoValue_FirebaseMlLogEvent_ModelDownloadLogEvent_ModelOptions.java?0.00%?
    AutoValue_FirebaseMlLogEvent_ModelDownloadLogEvent_ModelOptions_ModelInfo.java?0.00%?
    AutoValue_FirebaseMlLogEvent_SystemInfo.java?0.00%?
    CustomModel.java?0.00%?
    CustomModelDownloadConditions.java?0.00%?
    CustomModelDownloadService.java?0.00%?
    CustomModelDownloadService_Factory.java?0.00%?
    CustomModel_Factory.java?0.00%?
    CustomModel_Factory_Impl.java?0.00%?
    DaggerModelDownloaderComponent.java?0.00%?
    DataTransportMlEventSender.java?0.00%?
    DataTransportMlEventSender_Factory.java?0.00%?
    DownloadType.java?0.00%?
    FirebaseMlException.java?0.00%?
    FirebaseMlLogEvent.java?0.00%?
    FirebaseMlLogger.java?0.00%?
    FirebaseMlLogger_Factory.java?0.00%?
    FirebaseModelDownloader.java?0.00%?
    FirebaseModelDownloaderRegistrar.java?0.00%?
    FirebaseModelDownloader_Factory.java?0.00%?
    ModelDownloaderComponent.java?0.00%?
    ModelDownloaderComponent_MainModule_AppPackageNameFactory.java?0.00%?
    ModelDownloaderComponent_MainModule_AppVersionCodeFactory.java?0.00%?
    ModelDownloaderComponent_MainModule_FirebaseOptionsFactory.java?0.00%?
    ModelDownloaderComponent_MainModule_PersistenceKeyFactory.java?0.00%?
    ModelFileDownloadService.java?0.00%?
    ModelFileDownloadService_Factory.java?0.00%?
    ModelFileManager.java?0.00%?
    ModelFileManager_Factory.java?0.00%?
    SharedPreferencesUtil.java?0.00%?
    SharedPreferencesUtil_Factory.java?0.00%?

  • firebase-storage

    Overall coverage changed from 86.21% (734adc0) to 85.99% (e9b6793) by -0.21%.

    FilenameBase (734adc0)Merge (e9b6793)Diff
    StorageTask.java83.99%83.69%-0.30%
    UploadTask.java83.11%81.79%-1.32%

  • firebase-firestore

    FilenameBase (734adc0)Merge (e9b6793)Diff
    PatchMutation.java98.39%100.00%+1.61%
    SetMutation.java97.22%94.44%-2.78%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/7RgZRv1Wm2.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

The report is too large (117,058 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Uh5WcsC8tS/index.html

@rlazo rlazo merged commit 47cb47a into master Apr 17, 2023
@rlazo rlazo deleted the rl.setupjavaupdat branch April 17, 2023 17:13
@firebase firebase locked and limited conversation to collaborators May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emilypgoogle emilypgoogle emilypgoogle approved these changes

@VinayGuthal VinayGuthal Awaiting requested review from VinayGuthal

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rlazo @google-oss-bot @emilypgoogle