Skip to content

Don't rely on transitive dependency for guava test. #4906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2023
Merged

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Apr 17, 2023

No description provided.

@rlazo rlazo requested review from emilypgoogle and daymxn April 17, 2023 21:00
@rlazo rlazo enabled auto-merge (squash) April 17, 2023 21:00
@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2023

Javadoc Changes:
--- /Users/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/appcheck/FirebaseAppCheck.html	2023-04-17 21:22:40.000000000 +0000
+++ /Users/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/appcheck/FirebaseAppCheck.html	2023-04-17 21:13:28.000000000 +0000
@@ -8,7 +8,7 @@
     <div id="metadata-info-block"></div>
     <h1>FirebaseAppCheck</h1>
     <p>
-      <pre>public abstract class <a href="/docs/reference/android/com/google/firebase/appcheck/FirebaseAppCheck.html">FirebaseAppCheck</a> implements <a href="/docs/reference/android/com/google/firebase/appcheck/interop/InteropAppCheckTokenProvider.html">InteropAppCheckTokenProvider</a></pre>
+      <pre>public abstract class <a href="/docs/reference/android/com/google/firebase/appcheck/FirebaseAppCheck.html">FirebaseAppCheck</a> implements <a href="/docs/reference/android/com/google/firebase/appcheck/interop/InternalAppCheckTokenProvider.html">InternalAppCheckTokenProvider</a></pre>
     </p>
     <hr>
     <h2>Summary</h2>
@@ -139,7 +139,7 @@
         </thead>
         <tbody class="list">
           <tr>
-            <td><devsite-expandable><span class="expand-control">From <a href="/docs/reference/android/com/google/firebase/appcheck/interop/InteropAppCheckTokenProvider.html">com.google.firebase.appcheck.interop.InteropAppCheckTokenProvider</a></span>
+            <td><devsite-expandable><span class="expand-control">From <a href="/docs/reference/android/com/google/firebase/appcheck/interop/InternalAppCheckTokenProvider.html">com.google.firebase.appcheck.interop.InternalAppCheckTokenProvider</a></span>
               <div class="devsite-table-wrapper">
                 <table class="responsive">
                   <colgroup>
@@ -150,19 +150,19 @@
                     <tr>
                       <td><code>abstract void</code></td>
                       <td>
-                        <div><code><a href="/docs/reference/android/com/google/firebase/appcheck/interop/InteropAppCheckTokenProvider.html#addAppCheckTokenListener(com.google.firebase.appcheck.interop.AppCheckTokenListener)">addAppCheckTokenListener</a>(<a href="/docs/reference/android/com/google/firebase/appcheck/interop/AppCheckTokenListener.html">AppCheckTokenListener</a>&nbsp;p)</code></div>
+                        <div><code><a href="/docs/reference/android/com/google/firebase/appcheck/interop/InternalAppCheckTokenProvider.html#addAppCheckTokenListener(com.google.firebase.appcheck.interop.AppCheckTokenListener)">addAppCheckTokenListener</a>(<a href="/docs/reference/android/com/google/firebase/appcheck/interop/AppCheckTokenListener.html">AppCheckTokenListener</a>&nbsp;p)</code></div>
                       </td>
                     </tr>
                     <tr>
                       <td><code>abstract <a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a>&lt;<a href="/docs/reference/android/com/google/firebase/appcheck/AppCheckTokenResult.html">AppCheckTokenResult</a>&gt;</code></td>
                       <td>
-                        <div><code><a href="/docs/reference/android/com/google/firebase/appcheck/interop/InteropAppCheckTokenProvider.html#getToken(boolean)">getToken</a>(boolean&nbsp;p)</code></div>
+                        <div><code><a href="/docs/reference/android/com/google/firebase/appcheck/interop/InternalAppCheckTokenProvider.html#getToken(boolean)">getToken</a>(boolean&nbsp;p)</code></div>
                       </td>
                     </tr>
                     <tr>
                       <td><code>abstract void</code></td>
                       <td>
-                        <div><code><a href="/docs/reference/android/com/google/firebase/appcheck/interop/InteropAppCheckTokenProvider.html#removeAppCheckTokenListener(com.google.firebase.appcheck.interop.AppCheckTokenListener)">removeAppCheckTokenListener</a>(<a href="/docs/reference/android/com/google/firebase/appcheck/interop/AppCheckTokenListener.html">AppCheckTokenListener</a>&nbsp;p)</code></div>
+                        <div><code><a href="/docs/reference/android/com/google/firebase/appcheck/interop/InternalAppCheckTokenProvider.html#removeAppCheckTokenListener(com.google.firebase.appcheck.interop.AppCheckTokenListener)">removeAppCheckTokenListener</a>(<a href="/docs/reference/android/com/google/firebase/appcheck/interop/AppCheckTokenListener.html">AppCheckTokenListener</a>&nbsp;p)</code></div>
                       </td>
                     </tr>
                   </tbody>
--- /Users/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/appcheck/FirebaseAppCheck.html	2023-04-17 21:22:40.000000000 +0000
+++ /Users/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/appcheck/FirebaseAppCheck.html	2023-04-17 21:13:28.000000000 +0000
@@ -8,7 +8,7 @@
     <div id="metadata-info-block"></div>
     <h1>FirebaseAppCheck</h1>
     <p>
-      <pre>abstract class <a href="/docs/reference/kotlin/com/google/firebase/appcheck/FirebaseAppCheck.html">FirebaseAppCheck</a> : <a href="/docs/reference/kotlin/com/google/firebase/appcheck/interop/InteropAppCheckTokenProvider.html">InteropAppCheckTokenProvider</a></pre>
+      <pre>abstract class <a href="/docs/reference/kotlin/com/google/firebase/appcheck/FirebaseAppCheck.html">FirebaseAppCheck</a> : <a href="/docs/reference/kotlin/com/google/firebase/appcheck/interop/InternalAppCheckTokenProvider.html">InternalAppCheckTokenProvider</a></pre>
     </p>
     <hr>
     <h2>Summary</h2>
@@ -139,7 +139,7 @@
         </thead>
         <tbody class="list">
           <tr>
-            <td><devsite-expandable><span class="expand-control">From <a href="/docs/reference/kotlin/com/google/firebase/appcheck/interop/InteropAppCheckTokenProvider.html">com.google.firebase.appcheck.interop.InteropAppCheckTokenProvider</a></span>
+            <td><devsite-expandable><span class="expand-control">From <a href="/docs/reference/kotlin/com/google/firebase/appcheck/interop/InternalAppCheckTokenProvider.html">com.google.firebase.appcheck.interop.InternalAppCheckTokenProvider</a></span>
               <div class="devsite-table-wrapper">
                 <table class="responsive">
                   <colgroup>
@@ -150,19 +150,19 @@
                     <tr>
                       <td><code>abstract <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-unit/index.html">Unit</a></code></td>
                       <td>
-                        <div><code><a href="/docs/reference/kotlin/com/google/firebase/appcheck/interop/InteropAppCheckTokenProvider.html#addAppCheckTokenListener(com.google.firebase.appcheck.interop.AppCheckTokenListener)">addAppCheckTokenListener</a>(p:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/appcheck/interop/AppCheckTokenListener.html">AppCheckTokenListener</a>!)</code></div>
+                        <div><code><a href="/docs/reference/kotlin/com/google/firebase/appcheck/interop/InternalAppCheckTokenProvider.html#addAppCheckTokenListener(com.google.firebase.appcheck.interop.AppCheckTokenListener)">addAppCheckTokenListener</a>(p:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/appcheck/interop/AppCheckTokenListener.html">AppCheckTokenListener</a>!)</code></div>
                       </td>
                     </tr>
                     <tr>
                       <td><code>abstract <a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a>&lt;<a href="/docs/reference/kotlin/com/google/firebase/appcheck/AppCheckTokenResult.html">AppCheckTokenResult</a>!&gt;!</code></td>
                       <td>
-                        <div><code><a href="/docs/reference/kotlin/com/google/firebase/appcheck/interop/InteropAppCheckTokenProvider.html#getToken(boolean)">getToken</a>(p:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-boolean/index.html">Boolean</a>)</code></div>
+                        <div><code><a href="/docs/reference/kotlin/com/google/firebase/appcheck/interop/InternalAppCheckTokenProvider.html#getToken(boolean)">getToken</a>(p:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-boolean/index.html">Boolean</a>)</code></div>
                       </td>
                     </tr>
                     <tr>
                       <td><code>abstract <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-unit/index.html">Unit</a></code></td>
                       <td>
-                        <div><code><a href="/docs/reference/kotlin/com/google/firebase/appcheck/interop/InteropAppCheckTokenProvider.html#removeAppCheckTokenListener(com.google.firebase.appcheck.interop.AppCheckTokenListener)">removeAppCheckTokenListener</a>(p:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/appcheck/interop/AppCheckTokenListener.html">AppCheckTokenListener</a>!)</code></div>
+                        <div><code><a href="/docs/reference/kotlin/com/google/firebase/appcheck/interop/InternalAppCheckTokenProvider.html#removeAppCheckTokenListener(com.google.firebase.appcheck.interop.AppCheckTokenListener)">removeAppCheckTokenListener</a>(p:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/appcheck/interop/AppCheckTokenListener.html">AppCheckTokenListener</a>!)</code></div>
                       </td>
                     </tr>
                   </tbody>

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 17, 2023

Coverage Report 1

Affected Products

  • firebase-common

    Overall coverage changed from ? (5aa056e) to 53.60% (ccbbb3f) by ?.

    49 individual files with coverage change

    FilenameBase (5aa056e)Merge (ccbbb3f)Diff
    AutoValue_HeartBeatResult.java?33.33%?
    AutoValue_LibraryVersion.java?58.33%?
    AutoValue_SdkHeartBeatResult.java?0.00%?
    AutoValue_StartupTime.java?20.00%?
    ComponentDiscoveryService.java?0.00%?
    ComponentMonitor.java?100.00%?
    CustomThreadFactory.java?41.18%?
    DataCollectionConfigStorage.java?88.89%?
    DataCollectionDefaultChange.java?100.00%?
    DefaultHeartBeatController.java?95.59%?
    DefaultUserAgentPublisher.java?95.45%?
    DelegatingScheduledExecutorService.java?22.64%?
    DelegatingScheduledFuture.java?69.23%?
    EmulatedServiceSettings.java?0.00%?
    ExecutorsRegistrar.java?100.00%?
    FirebaseApp.java?56.36%?
    FirebaseAppLifecycleListener.java?0.00%?
    FirebaseCommonRegistrar.java?97.87%?
    FirebaseError.java?0.00%?
    FirebaseExecutors.java?0.00%?
    FirebaseInitProvider.java?69.57%?
    FirebaseNetworkException.java?0.00%?
    FirebaseOptions.java?31.94%?
    FirebaseTooManyRequestsException.java?0.00%?
    FirebaseTrace.java?100.00%?
    GlobalLibraryVersionRegistrar.java?75.00%?
    HeartBeatConsumer.java?0.00%?
    HeartBeatConsumerComponent.java?0.00%?
    HeartBeatController.java?0.00%?
    HeartBeatInfo.java?100.00%?
    HeartBeatInfoStorage.java?92.37%?
    HeartBeatResult.java?100.00%?
    KotlinDetector.java?33.33%?
    LibraryVersion.java?100.00%?
    LibraryVersionComponent.java?100.00%?
    LimitedConcurrencyExecutor.java?0.00%?
    LimitedConcurrencyExecutorService.java?0.00%?
    PausableExecutor.java?0.00%?
    PausableExecutorImpl.java?0.00%?
    PausableExecutorService.java?0.00%?
    PausableExecutorServiceImpl.java?0.00%?
    PausableScheduledExecutorService.java?0.00%?
    PausableScheduledExecutorServiceImpl.java?0.00%?
    PublicApi.java?0.00%?
    SdkHeartBeatResult.java?0.00%?
    SequentialExecutor.java?0.00%?
    StartupTime.java?100.00%?
    UiExecutor.java?60.00%?
    UserAgentPublisher.java?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/AxehVeEQYr.html

@github-actions
Copy link
Contributor

Unit Test Results

  34 files    34 suites   1m 22s ⏱️
  57 tests   57 ✔️ 0 💤 0
114 runs  114 ✔️ 0 💤 0

Results for commit 371ae42.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • base

    TypeBase (5aa056e)Merge (ccbbb3f)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)
  • firebase-common

    TypeBase (5aa056e)Merge (ccbbb3f)Diff
    aar?75.3 kB? (?)
    apk (aggressive)?112 kB? (?)
    apk (release)?1.26 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/XabUmsRIPr.html

@rlazo rlazo merged commit c719f85 into master Apr 17, 2023
@rlazo rlazo deleted the rl.guava.dep branch April 17, 2023 21:31
@firebase firebase locked and limited conversation to collaborators May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants