Skip to content

Update changelog entries #4908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2023
Merged

Update changelog entries #4908

merged 1 commit into from
Apr 19, 2023

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Apr 18, 2023

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2023 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

rlazo
rlazo commented Apr 18, 2023
View reviewed changes
Copy link
Collaborator Author

@rlazo rlazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual fixes

@rlazo rlazo marked this pull request as ready for review April 18, 2023 14:20
@rlazo rlazo requested a review from VinayGuthal April 18, 2023 14:21
@rlazo rlazo enabled auto-merge (squash) April 18, 2023 14:21
@github-actions
Copy link
Contributor

Unit Test Results

   248 files  +   214     248 suites  +214   5m 25s ⏱️ + 4m 13s
1 715 tests +1 658  1 697 ✔️ +1 640  18 💤 +18  0 ❌ ±0 
3 430 runs  +3 316  3 394 ✔️ +3 280  36 💤 +36  0 ❌ ±0 

Results for commit 70ce2c1. ± Comparison against base commit c719f85.

This pull request removes 57 and adds 1715 tests. Note that renamed tests count towards both. 
com.google.firebase.DataCollectionPostNDefaultEnabledTest ‑ isDataCollectionDefaultEnabled_shouldDefaultToTrue
com.google.firebase.DataCollectionPostNDefaultEnabledTest ‑ isDataCollectionDefaultEnabled_whenPrefsFalse_shouldReturnFalse
com.google.firebase.DataCollectionPostNDefaultEnabledTest ‑ isDataCollectionDefaultEnabled_whenPrefsTrue_shouldReturnTrue
com.google.firebase.DataCollectionPostNDefaultEnabledTest ‑ setDataCollectionDefaultEnabledFalse_shouldUpdateSharedPrefs
com.google.firebase.DataCollectionPostNDefaultEnabledTest ‑ setDataCollectionDefaultEnabled_shouldNotAffectOtherFirebaseAppInstances
com.google.firebase.DataCollectionPreNDefaultEnabledTest ‑ isDataCollectionDefaultEnabled_shouldDefaultToTrue
com.google.firebase.DataCollectionPreNDefaultEnabledTest ‑ isDataCollectionDefaultEnabled_whenPrefsFalse_shouldReturnFalse
com.google.firebase.DataCollectionPreNDefaultEnabledTest ‑ isDataCollectionDefaultEnabled_whenPrefsTrue_shouldReturnTrue
com.google.firebase.DataCollectionPreNDefaultEnabledTest ‑ setDataCollectionDefaultEnabledFalse_shouldUpdateSharedPrefs
com.google.firebase.DataCollectionPreNDefaultEnabledTest ‑ setDataCollectionDefaultEnabled_shouldNotAffectOtherFirebaseAppInstances
…

com.google.firebase.TimestampTest ‑ testCompare
com.google.firebase.TimestampTest ‑ testFromDate
com.google.firebase.TimestampTest ‑ testRejectBadDates
com.google.firebase.TimestampTest ‑ testTimestampParcelable
com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateAppTask_emptyLocationHeader_setsDownloadFailure
com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateAppTask_isNotRedirectResponse_setsDownloadFailure
com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateAppTask_missingLocationHeader_setsDownloadFailure
com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateAppTask_onAppResume_setsUpdateCancelled
com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateAppTask_whenAabReleaseAvailable_redirectsToPlay
com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateAppTask_whenOpenConnectionFails_setsNetworkFailure
…

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.16% (c719f85) to 50.15% (71be780) by -0.01%.

    FilenameBase (c719f85)Merge (71be780)Diff
    DoubleNode.java100.00%88.24%-11.76%
    ViewProcessor.java91.79%92.10%+0.30%

  • firebase-firestore

    Overall coverage changed from 44.12% (c719f85) to 44.10% (71be780) by -0.02%.

    FilenameBase (c719f85)Merge (71be780)Diff
    LocalStore.java100.00%99.39%-0.61%
    LruGarbageCollector.java97.20%93.46%-3.74%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/KNzBm492pz.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (c719f85) and merge commit (71be780).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/B3JAMNarn4.html

@rlazo rlazo merged commit 31176ce into master Apr 19, 2023
@rlazo rlazo deleted the rl.change.m130 branch April 19, 2023 14:40
@firebase firebase locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@VinayGuthal VinayGuthal VinayGuthal approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rlazo @google-oss-bot @VinayGuthal