Use empty string when handling null mcc_mnc #4916

rlazo · 2023-04-19T20:23:45Z

No description provided.

github-actions · 2023-04-19T20:23:58Z

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

google-oss-bot · 2023-04-19T20:30:18Z

Coverage Report ¹

Affected Products

`transport-backend-cct`

Overall coverage changed from ? (35e5bd8) to 78.35% (043eec6) by ?.

20 individual files with coverage change

Filename	Base (`35e5bd8`)	Merge (`043eec6`)	Diff
AndroidClientInfo.java	?	100.00%	?
AutoBatchedLogRequestEncoder.java	?	100.00%	?
AutoValue_AndroidClientInfo.java	?	54.64%	?
AutoValue_BatchedLogRequest.java	?	29.41%	?
AutoValue_ClientInfo.java	?	48.15%	?
AutoValue_LogEvent.java	?	60.00%	?
AutoValue_LogRequest.java	?	59.15%	?
AutoValue_LogResponse.java	?	26.67%	?
AutoValue_NetworkConnectionInfo.java	?	48.15%	?
BatchedLogRequest.java	?	100.00%	?
CctBackendFactory.java	?	100.00%	?
CCTDestination.java	?	87.50%	?
CctTransportBackend.java	?	92.92%	?
ClientInfo.java	?	100.00%	?
LogEvent.java	?	100.00%	?
LogRequest.java	?	100.00%	?
LogResponse.java	?	100.00%	?
NetworkConnectionInfo.java	?	100.00%	?
QosTier.java	?	69.23%	?
StringMerger.java	?	80.00%	?

Test Logs

Merge (043eec6): https://github.com/firebase/firebase-android-sdk/actions/runs/4747598006

https://storage.googleapis.com/firebase-sdk-metric-reports/fxvO4odx1S.html

github-actions · 2023-04-19T20:31:21Z

Unit Test Results

12 files -   776 12 suites - 776 28s ⏱️ - 34m 51s
48 tests - 4 817 48 ✔️ - 4 796 0 💤 - 21 0 ❌ ±0
96 runs - 9 543 96 ✔️ - 9 501 0 💤 - 42 0 ❌ ±0

Results for commit d8b3976. ± Comparison against base commit 35e5bd8.

google-oss-bot · 2023-04-19T20:38:30Z

Size Report ¹

Affected Products

transport-backend-cct
Type Base (35e5bd8) Merge (043eec6) Diff
aar 53.6 kB 53.6 kB +95 B (+0.2%)
apk (aggressive) 57.6 kB 57.6 kB +16 B (+0.0%)
apk (release) 105 kB 105 kB +60 B (+0.1%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/bA9kyvPvu8.html

google-oss-bot · 2023-04-19T20:56:44Z

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

This report is for comparing the base commit (35e5bd8) and the CI merge commit (043eec6)
Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
- 35e5bd8: https://storage.googleapis.com/firebase-sdk-metric-reports/B5kcQuKQtn/index.html
- 043eec6: https://storage.googleapis.com/firebase-sdk-metric-reports/756Zq3WB6X/index.html

Startup Times

`fire-transport`

Device Statistics Distributions

oriole-32

Percentile	`35e5bd8`	`043eec6`	Diff	Significant (?)
p10	469 ±389 μs	1.06 ±0.8 ms	+594 μs (+126.6%)	NO
p25	494 ±409 μs	1.10 ±0.8 ms	+604 μs (+122.1%)	NO
p50	523 ±431 μs	1.15 ±0.9 ms	+631 μs (+120.7%)	NO
p75	587 ±488 μs	1.30 ±1 ms	+715 μs (+121.7%)	NO
p90	734 ±636 μs	1.63 ±1 ms	+898 μs (+122.3%)	NO

20 test runs in comparison

Commit	Test Runs
`35e5bd8`	2023-04-19_20:11:34.139215_fYcY 2023-04-19_20:11:34.141773_aHjC 2023-04-19_20:11:34.141785_Utcr 2023-04-19_20:11:34.141791_vQTX 2023-04-19_20:11:34.141796_uciT 2023-04-19_20:11:34.141913_FsKL 2023-04-19_20:11:34.141929_Oqch 2023-04-19_20:11:34.141935_IlTw 2023-04-19_20:11:34.141941_QsQc 2023-04-19_20:11:34.141947_KNuj
`043eec6`	2023-04-19_20:44:08.697499_yGII 2023-04-19_20:44:08.708659_zhQi 2023-04-19_20:44:08.708676_vRPk 2023-04-19_20:44:08.708683_kaJH 2023-04-19_20:44:08.708854_sDAk 2023-04-19_20:44:08.708862_VJZi 2023-04-19_20:44:08.708868_xtkO 2023-04-19_20:44:08.708874_mkWi 2023-04-19_20:44:08.708879_FXSC 2023-04-19_20:44:08.708885_JtXM

redfin-30

Percentile	`35e5bd8`	`043eec6`	Diff	Significant (?)
p10	4.12 ±2 ms	2.74 ±2 ms	-1.38 ms (-33.5%)	NO
p25	4.48 ±2 ms	3.07 ±3 ms	-1.41 ms (-31.6%)	NO
p50	5.15 ±3 ms	3.57 ±3 ms	-1.58 ms (-30.7%)	NO
p75	6.22 ±3 ms	4.36 ±4 ms	-1.86 ms (-29.9%)	NO
p90	7.96 ±4 ms	5.41 ±5 ms	-2.54 ms (-32.0%)	NO

20 test runs in comparison

Commit	Test Runs
`35e5bd8`	2023-04-19_20:11:34.139215_fYcY 2023-04-19_20:11:34.141773_aHjC 2023-04-19_20:11:34.141785_Utcr 2023-04-19_20:11:34.141791_vQTX 2023-04-19_20:11:34.141796_uciT 2023-04-19_20:11:34.141913_FsKL 2023-04-19_20:11:34.141929_Oqch 2023-04-19_20:11:34.141935_IlTw 2023-04-19_20:11:34.141941_QsQc 2023-04-19_20:11:34.141947_KNuj
`043eec6`	2023-04-19_20:44:08.697499_yGII 2023-04-19_20:44:08.708659_zhQi 2023-04-19_20:44:08.708676_vRPk 2023-04-19_20:44:08.708683_kaJH 2023-04-19_20:44:08.708854_sDAk 2023-04-19_20:44:08.708862_VJZi 2023-04-19_20:44:08.708868_xtkO 2023-04-19_20:44:08.708874_mkWi 2023-04-19_20:44:08.708879_FXSC 2023-04-19_20:44:08.708885_JtXM

`timeToInitialDisplay`

Device Statistics Distributions

oriole-32

Percentile	`35e5bd8`	`043eec6`	Diff	Significant (?)
p10	194 ±5 ms	198 ±5 ms	+3.63 ms (+1.9%)	NO
p25	201 ±5 ms	204 ±5 ms	+3.81 ms (+1.9%)	NO
p50	209 ±6 ms	213 ±6 ms	+4.29 ms (+2.1%)	NO
p75	217 ±6 ms	224 ±7 ms	+6.46 ms (+3.0%)	NO
p90	225 ±7 ms	237 ±8 ms	+11.2 ms (+5.0%)	NO

20 test runs in comparison

Commit	Test Runs
`35e5bd8`	2023-04-19_20:11:34.139215_fYcY 2023-04-19_20:11:34.141773_aHjC 2023-04-19_20:11:34.141785_Utcr 2023-04-19_20:11:34.141791_vQTX 2023-04-19_20:11:34.141796_uciT 2023-04-19_20:11:34.141913_FsKL 2023-04-19_20:11:34.141929_Oqch 2023-04-19_20:11:34.141935_IlTw 2023-04-19_20:11:34.141941_QsQc 2023-04-19_20:11:34.141947_KNuj
`043eec6`	2023-04-19_20:44:08.697499_yGII 2023-04-19_20:44:08.708659_zhQi 2023-04-19_20:44:08.708676_vRPk 2023-04-19_20:44:08.708683_kaJH 2023-04-19_20:44:08.708854_sDAk 2023-04-19_20:44:08.708862_VJZi 2023-04-19_20:44:08.708868_xtkO 2023-04-19_20:44:08.708874_mkWi 2023-04-19_20:44:08.708879_FXSC 2023-04-19_20:44:08.708885_JtXM

redfin-30

Percentile	`35e5bd8`	`043eec6`	Diff	Significant (?)
p10	227 ±5 ms	255 ±5 ms	+27.5 ms (+12.1%)	YES
p25	234 ±4 ms	260 ±5 ms	+26.1 ms (+11.2%)	YES
p50	241 ±4 ms	268 ±5 ms	+26.6 ms (+11.0%)	YES
p75	249 ±5 ms	277 ±5 ms	+28.2 ms (+11.3%)	YES
p90	258 ±7 ms	290 ±7 ms	+32.2 ms (+12.5%)	MAYBE

20 test runs in comparison

Commit	Test Runs
`35e5bd8`	2023-04-19_20:11:34.139215_fYcY 2023-04-19_20:11:34.141773_aHjC 2023-04-19_20:11:34.141785_Utcr 2023-04-19_20:11:34.141791_vQTX 2023-04-19_20:11:34.141796_uciT 2023-04-19_20:11:34.141913_FsKL 2023-04-19_20:11:34.141929_Oqch 2023-04-19_20:11:34.141935_IlTw 2023-04-19_20:11:34.141941_QsQc 2023-04-19_20:11:34.141947_KNuj
`043eec6`	2023-04-19_20:44:08.697499_yGII 2023-04-19_20:44:08.708659_zhQi 2023-04-19_20:44:08.708676_vRPk 2023-04-19_20:44:08.708683_kaJH 2023-04-19_20:44:08.708854_sDAk 2023-04-19_20:44:08.708862_VJZi 2023-04-19_20:44:08.708868_xtkO 2023-04-19_20:44:08.708874_mkWi 2023-04-19_20:44:08.708879_FXSC 2023-04-19_20:44:08.708885_JtXM

https://storage.googleapis.com/firebase-sdk-metric-reports/xXy4X7A1kg/index.html

Use empty string when handling null mcc_mnc

89c47e3

rlazo requested review from davidmotson and emilypgoogle April 19, 2023 20:23

google-oss-bot added the do-not-merge/work-in-progress label Apr 19, 2023

rlazo marked this pull request as ready for review April 19, 2023 20:23

google-oss-bot removed the do-not-merge/work-in-progress label Apr 19, 2023

Merge branch 'master' into rl.mcc12

d8b3976

google-oss-bot added the size/S label Apr 19, 2023

rlazo enabled auto-merge (squash) April 19, 2023 20:24

emilypgoogle approved these changes Apr 19, 2023

View reviewed changes

rlazo merged commit 658fc46 into master Apr 19, 2023

rlazo deleted the rl.mcc12 branch April 19, 2023 20:35

firebase locked and limited conversation to collaborators Jun 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use empty string when handling null mcc_mnc #4916

Use empty string when handling null mcc_mnc #4916

Uh oh!

rlazo commented Apr 19, 2023

Uh oh!

github-actions bot commented Apr 19, 2023 •

edited

Loading

Uh oh!

google-oss-bot commented Apr 19, 2023

`transport-backend-cct`

Uh oh!

github-actions bot commented Apr 19, 2023

Uh oh!

google-oss-bot commented Apr 19, 2023

`transport-backend-cct`

Uh oh!

google-oss-bot commented Apr 19, 2023

`fire-transport`

`timeToInitialDisplay`

Uh oh!

Uh oh!

Use empty string when handling null mcc_mnc #4916

Use empty string when handling null mcc_mnc #4916

Uh oh!

Conversation

rlazo commented Apr 19, 2023

Uh oh!

github-actions bot commented Apr 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 PRs merging into main branch

Uh oh!

google-oss-bot commented Apr 19, 2023

Coverage Report 1

Affected Products

transport-backend-cct

Test Logs

Uh oh!

github-actions bot commented Apr 19, 2023

Unit Test Results

Uh oh!

google-oss-bot commented Apr 19, 2023

Size Report 1

Affected Products

transport-backend-cct

Test Logs

Uh oh!

google-oss-bot commented Apr 19, 2023

Startup Time Report 1

Notes

Startup Times

fire-transport

timeToInitialDisplay

Uh oh!

Uh oh!

github-actions bot commented Apr 19, 2023 •

edited

Loading

Coverage Report ¹

`transport-backend-cct`

Size Report ¹

`transport-backend-cct`

Startup Time Report ¹

`fire-transport`

`timeToInitialDisplay`