Skip to content

Introduce remote config cache for storing configs fetched remotely. #4917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 20, 2023
Merged

Introduce remote config cache for storing configs fetched remotely. #4917

merged 4 commits into from
Apr 20, 2023

Conversation

visumickey
Copy link
Contributor

@visumickey visumickey commented Apr 20, 2023 •
edited
Loading

Pending: Implement remote config fetching capability and updating the caches with the fetched value.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 20, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from ? (33f6660) to 72.14% (39f16c6) by ?.

    16 individual files with coverage change

    FilenameBase (33f6660)Merge (39f16c6)Diff
    ApplicationInfo.kt?100.00%?
    EventGDTLogger.kt?75.00%?
    FirebaseSessions.kt?0.00%?
    FirebaseSessionsEarly.kt?0.00%?
    FirebaseSessionsRegistrar.kt?0.00%?
    LocalOverrideSettings.kt?88.46%?
    RemoteSettings.kt?78.57%?
    SessionCoordinator.kt?76.47%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?100.00%?
    SessionGenerator.kt?20.00%?
    SessionInitiator.kt?66.67%?
    SessionsSettings.kt?83.33%?
    SettingsCache.kt?94.12%?
    SettingsProvider.kt?0.00%?
    Time.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/smg4IXlzZ2.html

@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2023 •
edited
Loading

Unit Test Results

20 files  20 suites   23s ⏱️
29 tests 29 ✔️ 0 💤 0 ❌
58 runs  58 ✔️ 0 💤 0 ❌

Results for commit 43b0342.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 20, 2023 •
edited
Loading

Size Report 1

Affected Products

  • base

    TypeBase (33f6660)Merge (39f16c6)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)

  • firebase-datatransport

    TypeBase (33f6660)Merge (39f16c6)Diff
    aar?4.94 kB? (?)
    apk (aggressive)?161 kB? (?)
    apk (release)?1.35 MB? (?)

  • firebase-sessions

    TypeBase (33f6660)Merge (39f16c6)Diff
    aar?76.1 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/MpmYIjRzz6.html

mrober
mrober reviewed Apr 20, 2023
View reviewed changes
@visumickey
Copy link
Contributor Author

/retest

@visumickey visumickey force-pushed the firebase-sessions-remote-settings branch from 67e4f36 to 43b0342 Compare April 20, 2023 21:03
@visumickey visumickey merged commit 5402c30 into firebase-sessions Apr 20, 2023
@visumickey visumickey deleted the firebase-sessions-remote-settings branch April 20, 2023 21:28
@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (39f16c6) and the base commit (33f6660) are not available.

No macrobenchmark data found for the base commit (33f6660). Analysis for the CI merge commit (39f16c6) can be found at:

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/SnxeYZTp90/index.html

@firebase firebase locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrober mrober mrober approved these changes

@samedson samedson Awaiting requested review from samedson

@davidmotson davidmotson Awaiting requested review from davidmotson

Assignees
No one assigned
Labels
no-changelog size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@visumickey @google-oss-bot @mrober