Skip to content

Address few nits in transport-runtime #4925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2023
Merged

Address few nits in transport-runtime #4925

merged 3 commits into from
Apr 24, 2023

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Apr 21, 2023

No description provided.

@rlazo rlazo requested review from daymxn and emilypgoogle April 21, 2023 23:54
@rlazo rlazo enabled auto-merge (squash) April 21, 2023 23:54
@github-actions
Copy link
Contributor

github-actions bot commented Apr 21, 2023

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 22, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2023

Unit Test Results

  28 files   -    711    28 suites   - 711   32s ⏱️ - 35m 7s
111 tests  - 4 754  111 ✔️  - 4 731  0 💤  - 21  0  - 2 
222 runs   - 8 446  222 ✔️  - 8 402  0 💤  - 42  0  - 2 

Results for commit 6e41ad4. ± Comparison against base commit 7039437.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 22, 2023

Size Report 1

Affected Products

  • transport-runtime

    TypeBase (7039437)Merge (a5f3032)Diff
    aar180 kB180 kB+32 B (+0.0%)
    apk (aggressive)44.6 kB44.6 kB+48 B (+0.1%)
    apk (release)84.0 kB84.0 kB+20 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/RZCHJNLQKR.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 22, 2023

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-transport

    DeviceStatisticsDistributions
    oriole-32
    Percentile7039437a5f3032DiffSignificant (?)
    p10986 ±691 μs1.07 ±0.7 ms+88.1 μs (+8.9%)NO
    p251.06 ±0.7 ms1.10 ±0.7 ms+42.3 μs (+4.0%)NO
    p501.13 ±0.8 ms1.15 ±0.8 ms+23.1 μs (+2.0%)NO
    p751.30 ±0.9 ms1.26 ±0.8 ms-42.5 μs (-3.3%)NO
    p901.70 ±1 ms1.58 ±1 ms-117 μs (-6.9%)NO

    20 test runs in comparison
    CommitTest Runs
    7039437
    • 2023-04-22_00:37:43.642008_GUaz
    • 2023-04-22_00:37:43.652746_LdjL
    • 2023-04-22_00:37:43.652766_GmKp
    • 2023-04-22_00:37:43.652799_NfeN
    • 2023-04-22_00:37:43.652806_TujJ
    • 2023-04-22_00:37:43.652813_zeyh
    • 2023-04-22_00:37:43.652820_UEDR
    • 2023-04-22_00:37:43.652828_VZog
    • 2023-04-22_00:37:43.652835_oNxF
    • 2023-04-22_00:37:43.652851_RcDC
    a5f3032
    • 2023-04-24_18:54:43.043653_fKfc
    • 2023-04-24_18:54:43.048163_rJqp
    • 2023-04-24_18:54:43.048177_MFGw
    • 2023-04-24_18:54:43.048185_xOWE
    • 2023-04-24_18:54:43.048192_vNqo
    • 2023-04-24_18:54:43.048198_PhUA
    • 2023-04-24_18:54:43.048205_HNOX
    • 2023-04-24_18:54:43.048215_EWEi
    • 2023-04-24_18:54:43.048221_vvSJ
    • 2023-04-24_18:54:43.048227_mbrU
    redfin-30
    Percentile7039437a5f3032DiffSignificant (?)
    p103.43 ±3 ms2.51 ±2 ms-921 μs (-26.8%)NO
    p253.72 ±3 ms2.75 ±3 ms-965 μs (-26.0%)NO
    p504.18 ±3 ms3.09 ±3 ms-1.10 ms (-26.2%)NO
    p754.98 ±4 ms3.76 ±3 ms-1.22 ms (-24.6%)NO
    p906.29 ±4 ms4.96 ±4 ms-1.33 ms (-21.1%)NO

    20 test runs in comparison
    CommitTest Runs
    7039437
    • 2023-04-22_00:37:43.642008_GUaz
    • 2023-04-22_00:37:43.652746_LdjL
    • 2023-04-22_00:37:43.652766_GmKp
    • 2023-04-22_00:37:43.652799_NfeN
    • 2023-04-22_00:37:43.652806_TujJ
    • 2023-04-22_00:37:43.652813_zeyh
    • 2023-04-22_00:37:43.652820_UEDR
    • 2023-04-22_00:37:43.652828_VZog
    • 2023-04-22_00:37:43.652835_oNxF
    • 2023-04-22_00:37:43.652851_RcDC
    a5f3032
    • 2023-04-24_18:54:43.043653_fKfc
    • 2023-04-24_18:54:43.048163_rJqp
    • 2023-04-24_18:54:43.048177_MFGw
    • 2023-04-24_18:54:43.048185_xOWE
    • 2023-04-24_18:54:43.048192_vNqo
    • 2023-04-24_18:54:43.048198_PhUA
    • 2023-04-24_18:54:43.048205_HNOX
    • 2023-04-24_18:54:43.048215_EWEi
    • 2023-04-24_18:54:43.048221_vvSJ
    • 2023-04-24_18:54:43.048227_mbrU
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile7039437a5f3032DiffSignificant (?)
    p10193 ±5 ms194 ±2 ms+517 μs (+0.3%)NO
    p25200 ±6 ms199 ±1 ms-645 μs (-0.3%)NO
    p50207 ±6 ms207 ±2 ms+213 μs (+0.1%)NO
    p75215 ±7 ms216 ±2 ms+819 μs (+0.4%)NO
    p90225 ±8 ms228 ±4 ms+3.35 ms (+1.5%)NO

    20 test runs in comparison
    CommitTest Runs
    7039437
    • 2023-04-22_00:37:43.642008_GUaz
    • 2023-04-22_00:37:43.652746_LdjL
    • 2023-04-22_00:37:43.652766_GmKp
    • 2023-04-22_00:37:43.652799_NfeN
    • 2023-04-22_00:37:43.652806_TujJ
    • 2023-04-22_00:37:43.652813_zeyh
    • 2023-04-22_00:37:43.652820_UEDR
    • 2023-04-22_00:37:43.652828_VZog
    • 2023-04-22_00:37:43.652835_oNxF
    • 2023-04-22_00:37:43.652851_RcDC
    a5f3032
    • 2023-04-24_18:54:43.043653_fKfc
    • 2023-04-24_18:54:43.048163_rJqp
    • 2023-04-24_18:54:43.048177_MFGw
    • 2023-04-24_18:54:43.048185_xOWE
    • 2023-04-24_18:54:43.048192_vNqo
    • 2023-04-24_18:54:43.048198_PhUA
    • 2023-04-24_18:54:43.048205_HNOX
    • 2023-04-24_18:54:43.048215_EWEi
    • 2023-04-24_18:54:43.048221_vvSJ
    • 2023-04-24_18:54:43.048227_mbrU
    redfin-30
    Percentile7039437a5f3032DiffSignificant (?)
    p10232 ±5 ms254 ±3 ms+22.7 ms (+9.8%)MAYBE
    p25237 ±5 ms260 ±3 ms+22.8 ms (+9.6%)MAYBE
    p50244 ±6 ms268 ±3 ms+23.2 ms (+9.5%)MAYBE
    p75252 ±5 ms275 ±4 ms+23.4 ms (+9.3%)MAYBE
    p90261 ±6 ms288 ±6 ms+27.0 ms (+10.4%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    7039437
    • 2023-04-22_00:37:43.642008_GUaz
    • 2023-04-22_00:37:43.652746_LdjL
    • 2023-04-22_00:37:43.652766_GmKp
    • 2023-04-22_00:37:43.652799_NfeN
    • 2023-04-22_00:37:43.652806_TujJ
    • 2023-04-22_00:37:43.652813_zeyh
    • 2023-04-22_00:37:43.652820_UEDR
    • 2023-04-22_00:37:43.652828_VZog
    • 2023-04-22_00:37:43.652835_oNxF
    • 2023-04-22_00:37:43.652851_RcDC
    a5f3032
    • 2023-04-24_18:54:43.043653_fKfc
    • 2023-04-24_18:54:43.048163_rJqp
    • 2023-04-24_18:54:43.048177_MFGw
    • 2023-04-24_18:54:43.048185_xOWE
    • 2023-04-24_18:54:43.048192_vNqo
    • 2023-04-24_18:54:43.048198_PhUA
    • 2023-04-24_18:54:43.048205_HNOX
    • 2023-04-24_18:54:43.048215_EWEi
    • 2023-04-24_18:54:43.048221_vvSJ
    • 2023-04-24_18:54:43.048227_mbrU

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/oTs8ci6Upn/index.html

@rlazo rlazo merged commit 7509feb into master Apr 24, 2023
@rlazo rlazo deleted the rl.transport branch April 24, 2023 18:46
@firebase firebase locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants