Skip to content

Lowercase "server(s)" in Remote Config docs. #4970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2023
Merged

Lowercase "server(s)" in Remote Config docs. #4970

merged 1 commit into from
May 2, 2023

Conversation

danasilver
Copy link
Contributor

@danasilver danasilver commented May 2, 2023 •
edited
Loading

Internal: b/280307873

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023 •
edited
Loading

Javadoc Changes: 
--- /Users/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/remoteconfig/FirebaseRemoteConfig.html	2023-05-02 16:52:41.000000000 +0000
+++ /Users/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/remoteconfig/FirebaseRemoteConfig.html	2023-05-02 16:46:02.000000000 +0000
@@ -12,7 +12,7 @@
     </p>
     <hr>
     <p>Entry point for the Firebase Remote Config API. </p>
-    <p>Callers should first get the singleton object using <code><a href="/docs/reference/android/com/google/firebase/remoteconfig/FirebaseRemoteConfig.html#getInstance()">getInstance</a></code>, and then call operations on that singleton object. The singleton contains the complete set of Remote Config parameter values available to your app. The singleton also stores values fetched from the Remote Config Server until they are made available for use with a call to <code><a href="/docs/reference/android/com/google/firebase/remoteconfig/FirebaseRemoteConfig.html#activate()">activate</a></code>.</p>
+    <p>Callers should first get the singleton object using <code><a href="/docs/reference/android/com/google/firebase/remoteconfig/FirebaseRemoteConfig.html#getInstance()">getInstance</a></code>, and then call operations on that singleton object. The singleton contains the complete set of Remote Config parameter values available to your app. The singleton also stores values fetched from the Remote Config server until they are made available for use with a call to <code><a href="/docs/reference/android/com/google/firebase/remoteconfig/FirebaseRemoteConfig.html#activate()">activate</a></code>.</p>
     <h2>Summary</h2>
     <div class="devsite-table-wrapper">
       <table class="responsive">
@@ -65,28 +65,28 @@
             <td><code>static&nbsp;final int</code></td>
             <td>
               <div><code><a href="/docs/reference/android/com/google/firebase/remoteconfig/FirebaseRemoteConfig.html#LAST_FETCH_STATUS_FAILURE()">LAST_FETCH_STATUS_FAILURE</a> = 1</code></div>
-              <p>Indicates that the most recent attempt to fetch parameter values from the Firebase Remote Config Server has failed.</p>
+              <p>Indicates that the most recent attempt to fetch parameter values from the Firebase Remote Config server has failed.</p>
             </td>
           </tr>
           <tr>
             <td><code>static&nbsp;final int</code></td>
             <td>
               <div><code><a href="/docs/reference/android/com/google/firebase/remoteconfig/FirebaseRemoteConfig.html#LAST_FETCH_STATUS_NO_FETCH_YET()">LAST_FETCH_STATUS_NO_FETCH_YET</a> = 0</code></div>
-              <p>Indicates that the FirebaseRemoteConfig singleton object has not yet attempted to fetch parameter values from the Firebase Remote Config Server.</p>
+              <p>Indicates that the FirebaseRemoteConfig singleton object has not yet attempted to fetch parameter values from the Firebase Remote Config server.</p>
             </td>
           </tr>
           <tr>
             <td><code>static&nbsp;final int</code></td>
             <td>
               <div><code><a href="/docs/reference/android/com/google/firebase/remoteconfig/FirebaseRemoteConfig.html#LAST_FETCH_STATUS_SUCCESS()">LAST_FETCH_STATUS_SUCCESS</a> = -1</code></div>
-              <p>Indicates that the most recent fetch of parameter values from the Firebase Remote Config Server was completed successfully.</p>
+              <p>Indicates that the most recent fetch of parameter values from the Firebase Remote Config server was completed successfully.</p>
             </td>
           </tr>
           <tr>
             <td><code>static&nbsp;final int</code></td>
             <td>
               <div><code><a href="/docs/reference/android/com/google/firebase/remoteconfig/FirebaseRemoteConfig.html#LAST_FETCH_STATUS_THROTTLED()">LAST_FETCH_STATUS_THROTTLED</a> = 2</code></div>
-              <p>Indicates that the most recent attempt to fetch parameter values from the Firebase Remote Config Server was throttled.</p>
+              <p>Indicates that the most recent attempt to fetch parameter values from the Firebase Remote Config server was throttled.</p>
             </td>
           </tr>
           <tr>
@@ -100,7 +100,7 @@
             <td><code>static&nbsp;final int</code></td>
             <td>
               <div><code><a href="/docs/reference/android/com/google/firebase/remoteconfig/FirebaseRemoteConfig.html#VALUE_SOURCE_REMOTE()">VALUE_SOURCE_REMOTE</a> = 2</code></div>
-              <p>Indicates that the value returned was retrieved from the Firebase Remote Config Server.</p>
+              <p>Indicates that the value returned was retrieved from the Firebase Remote Config server.</p>
             </td>
           </tr>
           <tr>
@@ -298,22 +298,22 @@
       <div class="api-item"><a name="getLAST_FETCH_STATUS_FAILURE()"></a><a name="setLAST_FETCH_STATUS_FAILURE()"></a><a name="getLAST_FETCH_STATUS_FAILURE--"></a><a name="setLAST_FETCH_STATUS_FAILURE--"></a>
         <h3 class="api-name" id="LAST_FETCH_STATUS_FAILURE()">LAST_FETCH_STATUS_FAILURE</h3>
         <pre class="api-signature no-pretty-print">public&nbsp;static&nbsp;final&nbsp;int&nbsp;<a href="/docs/reference/android/com/google/firebase/remoteconfig/FirebaseRemoteConfig.html#LAST_FETCH_STATUS_FAILURE()">LAST_FETCH_STATUS_FAILURE</a> = 1</pre>
-        <p>Indicates that the most recent attempt to fetch parameter values from the Firebase Remote Config Server has failed.</p>
+        <p>Indicates that the most recent attempt to fetch parameter values from the Firebase Remote Config server has failed.</p>
       </div>
       <div class="api-item"><a name="getLAST_FETCH_STATUS_NO_FETCH_YET()"></a><a name="setLAST_FETCH_STATUS_NO_FETCH_YET()"></a><a name="getLAST_FETCH_STATUS_NO_FETCH_YET--"></a><a name="setLAST_FETCH_STATUS_NO_FETCH_YET--"></a>
         <h3 class="api-name" id="LAST_FETCH_STATUS_NO_FETCH_YET()">LAST_FETCH_STATUS_NO_FETCH_YET</h3>
         <pre class="api-signature no-pretty-print">public&nbsp;static&nbsp;final&nbsp;int&nbsp;<a href="/docs/reference/android/com/google/firebase/remoteconfig/FirebaseRemoteConfig.html#LAST_FETCH_STATUS_NO_FETCH_YET()">LAST_FETCH_STATUS_NO_FETCH_YET</a> = 0</pre>
-        <p>Indicates that the FirebaseRemoteConfig singleton object has not yet attempted to fetch parameter values from the Firebase Remote Config Server.</p>
+        <p>Indicates that the FirebaseRemoteConfig singleton object has not yet attempted to fetch parameter values from the Firebase Remote Config server.</p>
       </div>
       <div class="api-item"><a name="getLAST_FETCH_STATUS_SUCCESS()"></a><a name="setLAST_FETCH_STATUS_SUCCESS()"></a><a name="getLAST_FETCH_STATUS_SUCCESS--"></a><a name="setLAST_FETCH_STATUS_SUCCESS--"></a>
         <h3 class="api-name" id="LAST_FETCH_STATUS_SUCCESS()">LAST_FETCH_STATUS_SUCCESS</h3>
         <pre class="api-signature no-pretty-print">public&nbsp;static&nbsp;final&nbsp;int&nbsp;<a href="/docs/reference/android/com/google/firebase/remoteconfig/FirebaseRemoteConfig.html#LAST_FETCH_STATUS_SUCCESS()">LAST_FETCH_STATUS_SUCCESS</a> = -1</pre>
-        <p>Indicates that the most recent fetch of parameter values from the Firebase Remote Config Server was completed successfully.</p>
+        <p>Indicates that the most recent fetch of parameter values from the Firebase Remote Config server was completed successfully.</p>
       </div>
       <div class="api-item"><a name="getLAST_FETCH_STATUS_THROTTLED()"></a><a name="setLAST_FETCH_STATUS_THROTTLED()"></a><a name="getLAST_FETCH_STATUS_THROTTLED--"></a><a name="setLAST_FETCH_STATUS_THROTTLED--"></a>
         <h3 class="api-name" id="LAST_FETCH_STATUS_THROTTLED()">LAST_FETCH_STATUS_THROTTLED</h3>
         <pre class="api-signature no-pretty-print">public&nbsp;static&nbsp;final&nbsp;int&nbsp;<a href="/docs/reference/android/com/google/firebase/remoteconfig/FirebaseRemoteConfig.html#LAST_FETCH_STATUS_THROTTLED()">LAST_FETCH_STATUS_THROTTLED</a> = 2</pre>
-        <p>Indicates that the most recent attempt to fetch parameter values from the Firebase Remote Config Server was throttled.</p>
+        <p>Indicates that the most recent attempt to fetch parameter values from the Firebase Remote Config server was throttled.</p>
       </div>
       <div class="api-item"><a name="getVALUE_SOURCE_DEFAULT()"></a><a name="setVALUE_SOURCE_DEFAULT()"></a><a name="getVALUE_SOURCE_DEFAULT--"></a><a name="setVALUE_SOURCE_DEFAULT--"></a>
         <h3 class="api-name" id="VALUE_SOURCE_DEFAULT()">VALUE_SOURCE_DEFAULT</h3>
@@ -323,7 +323,7 @@
       <div class="api-item"><a name="getVALUE_SOURCE_REMOTE()"></a><a name="setVALUE_SOURCE_REMOTE()"></a><a name="getVALUE_SOURCE_REMOTE--"></a><a name="setVALUE_SOURCE_REMOTE--"></a>
         <h3 class="api-name" id="VALUE_SOURCE_REMOTE()">VALUE_SOURCE_REMOTE</h3>
         <pre class="api-signature no-pretty-print">public&nbsp;static&nbsp;final&nbsp;int&nbsp;<a href="/docs/reference/android/com/google/firebase/remoteconfig/FirebaseRemoteConfig.html#VALUE_SOURCE_REMOTE()">VALUE_SOURCE_REMOTE</a> = 2</pre>
-        <p>Indicates that the value returned was retrieved from the Firebase Remote Config Server.</p>
+        <p>Indicates that the value returned was retrieved from the Firebase Remote Config server.</p>
       </div>
       <div class="api-item"><a name="getVALUE_SOURCE_STATIC()"></a><a name="setVALUE_SOURCE_STATIC()"></a><a name="getVALUE_SOURCE_STATIC--"></a><a name="setVALUE_SOURCE_STATIC--"></a>
         <h3 class="api-name" id="VALUE_SOURCE_STATIC()">VALUE_SOURCE_STATIC</h3>
--- /Users/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/remoteconfig/FirebaseRemoteConfig.html	2023-05-02 16:52:41.000000000 +0000
+++ /Users/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/remoteconfig/FirebaseRemoteConfig.html	2023-05-02 16:46:02.000000000 +0000
@@ -12,7 +12,7 @@
     </p>
     <hr>
     <p>Entry point for the Firebase Remote Config API. </p>
-    <p>Callers should first get the singleton object using <code><a href="/docs/reference/kotlin/com/google/firebase/remoteconfig/FirebaseRemoteConfig.html#getInstance()">getInstance</a></code>, and then call operations on that singleton object. The singleton contains the complete set of Remote Config parameter values available to your app. The singleton also stores values fetched from the Remote Config Server until they are made available for use with a call to <code><a href="/docs/reference/kotlin/com/google/firebase/remoteconfig/FirebaseRemoteConfig.html#activate()">activate</a></code>.</p>
+    <p>Callers should first get the singleton object using <code><a href="/docs/reference/kotlin/com/google/firebase/remoteconfig/FirebaseRemoteConfig.html#getInstance()">getInstance</a></code>, and then call operations on that singleton object. The singleton contains the complete set of Remote Config parameter values available to your app. The singleton also stores values fetched from the Remote Config server until they are made available for use with a call to <code><a href="/docs/reference/kotlin/com/google/firebase/remoteconfig/FirebaseRemoteConfig.html#activate()">activate</a></code>.</p>
     <h2>Summary</h2>
     <div class="devsite-table-wrapper">
       <table class="responsive">
@@ -65,28 +65,28 @@
             <td><code>const <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-int/index.html">Int</a></code></td>
             <td>
               <div><code><a href="/docs/reference/kotlin/com/google/firebase/remoteconfig/FirebaseRemoteConfig.html#LAST_FETCH_STATUS_FAILURE()">LAST_FETCH_STATUS_FAILURE</a> = 1</code></div>
-              <p>Indicates that the most recent attempt to fetch parameter values from the Firebase Remote Config Server has failed.</p>
+              <p>Indicates that the most recent attempt to fetch parameter values from the Firebase Remote Config server has failed.</p>
             </td>
           </tr>
           <tr>
             <td><code>const <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-int/index.html">Int</a></code></td>
             <td>
               <div><code><a href="/docs/reference/kotlin/com/google/firebase/remoteconfig/FirebaseRemoteConfig.html#LAST_FETCH_STATUS_NO_FETCH_YET()">LAST_FETCH_STATUS_NO_FETCH_YET</a> = 0</code></div>
-              <p>Indicates that the FirebaseRemoteConfig singleton object has not yet attempted to fetch parameter values from the Firebase Remote Config Server.</p>
+              <p>Indicates that the FirebaseRemoteConfig singleton object has not yet attempted to fetch parameter values from the Firebase Remote Config server.</p>
             </td>
           </tr>
           <tr>
             <td><code>const <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-int/index.html">Int</a></code></td>
             <td>
               <div><code><a href="/docs/reference/kotlin/com/google/firebase/remoteconfig/FirebaseRemoteConfig.html#LAST_FETCH_STATUS_SUCCESS()">LAST_FETCH_STATUS_SUCCESS</a> = -1</code></div>
-              <p>Indicates that the most recent fetch of parameter values from the Firebase Remote Config Server was completed successfully.</p>
+              <p>Indicates that the most recent fetch of parameter values from the Firebase Remote Config server was completed successfully.</p>
             </td>
           </tr>
           <tr>
             <td><code>const <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-int/index.html">Int</a></code></td>
             <td>
               <div><code><a href="/docs/reference/kotlin/com/google/firebase/remoteconfig/FirebaseRemoteConfig.html#LAST_FETCH_STATUS_THROTTLED()">LAST_FETCH_STATUS_THROTTLED</a> = 2</code></div>
-              <p>Indicates that the most recent attempt to fetch parameter values from the Firebase Remote Config Server was throttled.</p>
+              <p>Indicates that the most recent attempt to fetch parameter values from the Firebase Remote Config server was throttled.</p>
             </td>
           </tr>
           <tr>
@@ -100,7 +100,7 @@
             <td><code>const <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-int/index.html">Int</a></code></td>
             <td>
               <div><code><a href="/docs/reference/kotlin/com/google/firebase/remoteconfig/FirebaseRemoteConfig.html#VALUE_SOURCE_REMOTE()">VALUE_SOURCE_REMOTE</a> = 2</code></div>
-              <p>Indicates that the value returned was retrieved from the Firebase Remote Config Server.</p>
+              <p>Indicates that the value returned was retrieved from the Firebase Remote Config server.</p>
             </td>
           </tr>
           <tr>
@@ -298,22 +298,22 @@
       <div class="api-item"><a name="getLAST_FETCH_STATUS_FAILURE()"></a><a name="setLAST_FETCH_STATUS_FAILURE()"></a><a name="getLAST_FETCH_STATUS_FAILURE--"></a><a name="setLAST_FETCH_STATUS_FAILURE--"></a>
         <h3 class="api-name" id="LAST_FETCH_STATUS_FAILURE()">LAST_FETCH_STATUS_FAILURE</h3>
         <pre class="api-signature no-pretty-print">const&nbsp;val&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/remoteconfig/FirebaseRemoteConfig.html#LAST_FETCH_STATUS_FAILURE()">LAST_FETCH_STATUS_FAILURE</a> = 1:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-int/index.html">Int</a></pre>
-        <p>Indicates that the most recent attempt to fetch parameter values from the Firebase Remote Config Server has failed.</p>
+        <p>Indicates that the most recent attempt to fetch parameter values from the Firebase Remote Config server has failed.</p>
       </div>
       <div class="api-item"><a name="getLAST_FETCH_STATUS_NO_FETCH_YET()"></a><a name="setLAST_FETCH_STATUS_NO_FETCH_YET()"></a><a name="getLAST_FETCH_STATUS_NO_FETCH_YET--"></a><a name="setLAST_FETCH_STATUS_NO_FETCH_YET--"></a>
         <h3 class="api-name" id="LAST_FETCH_STATUS_NO_FETCH_YET()">LAST_FETCH_STATUS_NO_FETCH_YET</h3>
         <pre class="api-signature no-pretty-print">const&nbsp;val&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/remoteconfig/FirebaseRemoteConfig.html#LAST_FETCH_STATUS_NO_FETCH_YET()">LAST_FETCH_STATUS_NO_FETCH_YET</a> = 0:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-int/index.html">Int</a></pre>
-        <p>Indicates that the FirebaseRemoteConfig singleton object has not yet attempted to fetch parameter values from the Firebase Remote Config Server.</p>
+        <p>Indicates that the FirebaseRemoteConfig singleton object has not yet attempted to fetch parameter values from the Firebase Remote Config server.</p>
       </div>
       <div class="api-item"><a name="getLAST_FETCH_STATUS_SUCCESS()"></a><a name="setLAST_FETCH_STATUS_SUCCESS()"></a><a name="getLAST_FETCH_STATUS_SUCCESS--"></a><a name="setLAST_FETCH_STATUS_SUCCESS--"></a>
         <h3 class="api-name" id="LAST_FETCH_STATUS_SUCCESS()">LAST_FETCH_STATUS_SUCCESS</h3>
         <pre class="api-signature no-pretty-print">const&nbsp;val&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/remoteconfig/FirebaseRemoteConfig.html#LAST_FETCH_STATUS_SUCCESS()">LAST_FETCH_STATUS_SUCCESS</a> = -1:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-int/index.html">Int</a></pre>
-        <p>Indicates that the most recent fetch of parameter values from the Firebase Remote Config Server was completed successfully.</p>
+        <p>Indicates that the most recent fetch of parameter values from the Firebase Remote Config server was completed successfully.</p>
       </div>
       <div class="api-item"><a name="getLAST_FETCH_STATUS_THROTTLED()"></a><a name="setLAST_FETCH_STATUS_THROTTLED()"></a><a name="getLAST_FETCH_STATUS_THROTTLED--"></a><a name="setLAST_FETCH_STATUS_THROTTLED--"></a>
         <h3 class="api-name" id="LAST_FETCH_STATUS_THROTTLED()">LAST_FETCH_STATUS_THROTTLED</h3>
         <pre class="api-signature no-pretty-print">const&nbsp;val&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/remoteconfig/FirebaseRemoteConfig.html#LAST_FETCH_STATUS_THROTTLED()">LAST_FETCH_STATUS_THROTTLED</a> = 2:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-int/index.html">Int</a></pre>
-        <p>Indicates that the most recent attempt to fetch parameter values from the Firebase Remote Config Server was throttled.</p>
+        <p>Indicates that the most recent attempt to fetch parameter values from the Firebase Remote Config server was throttled.</p>
       </div>
       <div class="api-item"><a name="getVALUE_SOURCE_DEFAULT()"></a><a name="setVALUE_SOURCE_DEFAULT()"></a><a name="getVALUE_SOURCE_DEFAULT--"></a><a name="setVALUE_SOURCE_DEFAULT--"></a>
         <h3 class="api-name" id="VALUE_SOURCE_DEFAULT()">VALUE_SOURCE_DEFAULT</h3>
@@ -323,7 +323,7 @@
       <div class="api-item"><a name="getVALUE_SOURCE_REMOTE()"></a><a name="setVALUE_SOURCE_REMOTE()"></a><a name="getVALUE_SOURCE_REMOTE--"></a><a name="setVALUE_SOURCE_REMOTE--"></a>
         <h3 class="api-name" id="VALUE_SOURCE_REMOTE()">VALUE_SOURCE_REMOTE</h3>
         <pre class="api-signature no-pretty-print">const&nbsp;val&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/remoteconfig/FirebaseRemoteConfig.html#VALUE_SOURCE_REMOTE()">VALUE_SOURCE_REMOTE</a> = 2:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-int/index.html">Int</a></pre>
-        <p>Indicates that the value returned was retrieved from the Firebase Remote Config Server.</p>
+        <p>Indicates that the value returned was retrieved from the Firebase Remote Config server.</p>
       </div>
       <div class="api-item"><a name="getVALUE_SOURCE_STATIC()"></a><a name="setVALUE_SOURCE_STATIC()"></a><a name="getVALUE_SOURCE_STATIC--"></a><a name="setVALUE_SOURCE_STATIC--"></a>
         <h3 class="api-name" id="VALUE_SOURCE_STATIC()">VALUE_SOURCE_STATIC</h3>

@danasilver danasilver marked this pull request as ready for review May 2, 2023 16:41
@danasilver danasilver requested a review from karenyz May 2, 2023 16:41
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

No changes between base commit (8f1a33f) and merge commit (bd5d88c).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/EmbbwiRWcv.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (8f1a33f) and merge commit (bd5d88c).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/VD2xseDnAH.html

@danasilver danasilver enabled auto-merge (squash) May 2, 2023 17:16
@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-rc

    DeviceStatisticsDistributions
    oriole-32
    Percentile8f1a33fbd5d88cDiffSignificant (?)
    p1090.0 ±34 μs167 ±211 μs+76.6 μs (+85.1%)NO
    p2595.1 ±35 μs177 ±220 μs+81.5 μs (+85.8%)NO
    p50109 ±45 μs197 ±241 μs+87.8 μs (+80.4%)NO
    p75156 ±91 μs236 ±274 μs+80.0 μs (+51.4%)NO
    p90186 ±103 μs282 ±303 μs+95.8 μs (+51.5%)NO

    20 test runs in comparison
    CommitTest Runs
    8f1a33f
    • 2023-05-02_15:56:29.273156_KYgC
    • 2023-05-02_15:56:29.276734_etow
    • 2023-05-02_15:56:29.276747_BgEp
    • 2023-05-02_15:56:29.276753_yomJ
    • 2023-05-02_15:56:29.277044_YcnA
    • 2023-05-02_15:56:29.277052_XoNR
    • 2023-05-02_15:56:29.277058_jILS
    • 2023-05-02_15:56:29.277064_LgaB
    • 2023-05-02_15:56:29.277069_qHEF
    • 2023-05-02_15:56:29.277075_HnIk
    bd5d88c
    • 2023-05-02_16:56:30.800314_IWrt
    • 2023-05-02_16:56:30.802068_mtwI
    • 2023-05-02_16:56:30.802206_hoiU
    • 2023-05-02_16:56:30.802213_ksLF
    • 2023-05-02_16:56:30.802219_wjYx
    • 2023-05-02_16:56:30.802224_HSga
    • 2023-05-02_16:56:30.802230_RGuc
    • 2023-05-02_16:56:30.802235_rvuw
    • 2023-05-02_16:56:30.802240_QVck
    • 2023-05-02_16:56:30.802245_LaCf
    redfin-30
    Percentile8f1a33fbd5d88cDiffSignificant (?)
    p10287 ±452 μs388 ±487 μs+101 μs (+35.1%)NO
    p25320 ±528 μs442 ±557 μs+122 μs (+38.2%)NO
    p50360 ±615 μs565 ±702 μs+205 μs (+56.9%)NO
    p75428 ±755 μs751 ±910 μs+323 μs (+75.4%)NO
    p90551 ±989 μs979 ±1152 μs+428 μs (+77.8%)NO

    20 test runs in comparison
    CommitTest Runs
    8f1a33f
    • 2023-05-02_15:56:29.273156_KYgC
    • 2023-05-02_15:56:29.276734_etow
    • 2023-05-02_15:56:29.276747_BgEp
    • 2023-05-02_15:56:29.276753_yomJ
    • 2023-05-02_15:56:29.277044_YcnA
    • 2023-05-02_15:56:29.277052_XoNR
    • 2023-05-02_15:56:29.277058_jILS
    • 2023-05-02_15:56:29.277064_LgaB
    • 2023-05-02_15:56:29.277069_qHEF
    • 2023-05-02_15:56:29.277075_HnIk
    bd5d88c
    • 2023-05-02_16:56:30.800314_IWrt
    • 2023-05-02_16:56:30.802068_mtwI
    • 2023-05-02_16:56:30.802206_hoiU
    • 2023-05-02_16:56:30.802213_ksLF
    • 2023-05-02_16:56:30.802219_wjYx
    • 2023-05-02_16:56:30.802224_HSga
    • 2023-05-02_16:56:30.802230_RGuc
    • 2023-05-02_16:56:30.802235_rvuw
    • 2023-05-02_16:56:30.802240_QVck
    • 2023-05-02_16:56:30.802245_LaCf

  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile8f1a33fbd5d88cDiffSignificant (?)
    p10194 ±6 ms198 ±6 ms+3.91 ms (+2.0%)NO
    p25200 ±6 ms204 ±7 ms+3.32 ms (+1.7%)NO
    p50207 ±6 ms211 ±6 ms+4.56 ms (+2.2%)NO
    p75215 ±7 ms221 ±7 ms+5.91 ms (+2.7%)NO
    p90224 ±9 ms230 ±8 ms+6.42 ms (+2.9%)NO

    20 test runs in comparison
    CommitTest Runs
    8f1a33f
    • 2023-05-02_15:56:29.273156_KYgC
    • 2023-05-02_15:56:29.276734_etow
    • 2023-05-02_15:56:29.276747_BgEp
    • 2023-05-02_15:56:29.276753_yomJ
    • 2023-05-02_15:56:29.277044_YcnA
    • 2023-05-02_15:56:29.277052_XoNR
    • 2023-05-02_15:56:29.277058_jILS
    • 2023-05-02_15:56:29.277064_LgaB
    • 2023-05-02_15:56:29.277069_qHEF
    • 2023-05-02_15:56:29.277075_HnIk
    bd5d88c
    • 2023-05-02_16:56:30.800314_IWrt
    • 2023-05-02_16:56:30.802068_mtwI
    • 2023-05-02_16:56:30.802206_hoiU
    • 2023-05-02_16:56:30.802213_ksLF
    • 2023-05-02_16:56:30.802219_wjYx
    • 2023-05-02_16:56:30.802224_HSga
    • 2023-05-02_16:56:30.802230_RGuc
    • 2023-05-02_16:56:30.802235_rvuw
    • 2023-05-02_16:56:30.802240_QVck
    • 2023-05-02_16:56:30.802245_LaCf
    redfin-30
    Percentile8f1a33fbd5d88cDiffSignificant (?)
    p10231 ±4 ms254 ±6 ms+22.9 ms (+9.9%)MAYBE
    p25237 ±4 ms261 ±5 ms+23.9 ms (+10.1%)YES
    p50244 ±4 ms268 ±4 ms+24.4 ms (+10.0%)YES
    p75253 ±5 ms278 ±5 ms+25.3 ms (+10.0%)YES
    p90262 ±7 ms293 ±6 ms+30.6 ms (+11.7%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    8f1a33f
    • 2023-05-02_15:56:29.273156_KYgC
    • 2023-05-02_15:56:29.276734_etow
    • 2023-05-02_15:56:29.276747_BgEp
    • 2023-05-02_15:56:29.276753_yomJ
    • 2023-05-02_15:56:29.277044_YcnA
    • 2023-05-02_15:56:29.277052_XoNR
    • 2023-05-02_15:56:29.277058_jILS
    • 2023-05-02_15:56:29.277064_LgaB
    • 2023-05-02_15:56:29.277069_qHEF
    • 2023-05-02_15:56:29.277075_HnIk
    bd5d88c
    • 2023-05-02_16:56:30.800314_IWrt
    • 2023-05-02_16:56:30.802068_mtwI
    • 2023-05-02_16:56:30.802206_hoiU
    • 2023-05-02_16:56:30.802213_ksLF
    • 2023-05-02_16:56:30.802219_wjYx
    • 2023-05-02_16:56:30.802224_HSga
    • 2023-05-02_16:56:30.802230_RGuc
    • 2023-05-02_16:56:30.802235_rvuw
    • 2023-05-02_16:56:30.802240_QVck
    • 2023-05-02_16:56:30.802245_LaCf

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/kQ6ZNz7Y6J/index.html

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

Unit Test Results

  16 files   -    488    16 suites   - 488   52s ⏱️ - 19m 10s
276 tests  - 3 091  275 ✔️  - 3 072  0 💤  - 19  1 ❌ ±0 
282 runs   - 6 452  281 ✔️  - 6 414  0 💤  - 38  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 5a1d775. ± Comparison against base commit 8f1a33f.

@danasilver danasilver merged commit bad35ef into master May 2, 2023
@danasilver danasilver deleted the ds-rc-docs-m131-fix branch May 2, 2023 23:43
@firebase firebase locked and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@karenyz karenyz karenyz approved these changes

Assignees
No one assigned
Labels
main-merge-ack no-changelog size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danasilver @google-oss-bot @karenyz