Skip to content

Update versions #4972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2023
Merged

Update versions #4972

merged 2 commits into from
May 3, 2023

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented May 2, 2023

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@rlazo rlazo requested a review from VinayGuthal May 2, 2023 21:35
@rlazo rlazo marked this pull request as ready for review May 2, 2023 21:35
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

Unit Test Results

   504 files  +   476     504 suites  +476   19m 0s ⏱️ + 17m 37s
3 367 tests +3 091  3 348 ✔️ +3 072  19 💤 +19  0 ±0 
6 734 runs  +6 182  6 696 ✔️ +6 144  38 💤 +38  0 ±0 

Results for commit 7878a70. ± Comparison against base commit bad35ef.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 2, 2023

Size Report 1

Affected Products

  • base

    TypeBase (bad35ef)Merge (78e223c)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)
  • firebase-appcheck

    TypeBase (bad35ef)Merge (78e223c)Diff
    aar?36.7 kB? (?)
    apk (aggressive)?362 kB? (?)
    apk (release)?1.56 MB? (?)
  • firebase-appcheck-debug

    TypeBase (bad35ef)Merge (78e223c)Diff
    aar?11.1 kB? (?)
    apk (aggressive)?363 kB? (?)
    apk (release)?1.56 MB? (?)
  • firebase-appcheck-debug-testing

    TypeBase (bad35ef)Merge (78e223c)Diff
    aar?7.27 kB? (?)
    apk (aggressive)?365 kB? (?)
    apk (release)?1.60 MB? (?)
  • firebase-appcheck-interop

    TypeBase (bad35ef)Merge (78e223c)Diff
    aar?5.00 kB? (?)
    apk (aggressive)?312 kB? (?)
    apk (release)?931 kB? (?)
  • firebase-appcheck-playintegrity

    TypeBase (bad35ef)Merge (78e223c)Diff
    aar?11.0 kB? (?)
    apk (aggressive)?365 kB? (?)
    apk (release)?1.57 MB? (?)
  • firebase-config

    TypeBase (bad35ef)Merge (78e223c)Diff
    aar?88.9 kB? (?)
    apk (aggressive)?151 kB? (?)
    apk (release)?1.32 MB? (?)
  • firebase-crashlytics

    TypeBase (bad35ef)Merge (78e223c)Diff
    aar?351 kB? (?)
    apk (aggressive)?247 kB? (?)
    apk (release)?1.48 MB? (?)
  • firebase-crashlytics-ndk

    TypeBase (bad35ef)Merge (78e223c)Diff
    aar?1.66 MB? (?)
    apk (aggressive / arm64-v8a)?1.41 MB? (?)
    apk (aggressive / armeabi-v7a)?890 kB? (?)
    apk (aggressive / x86)?1.40 MB? (?)
    apk (aggressive / x86_64)?1.46 MB? (?)
    apk (release / arm64-v8a)?2.64 MB? (?)
    apk (release / armeabi-v7a)?2.12 MB? (?)
    apk (release / x86)?2.62 MB? (?)
    apk (release / x86_64)?2.68 MB? (?)
  • firebase-database

    TypeBase (bad35ef)Merge (78e223c)Diff
    aar?488 kB? (?)
    apk (aggressive)?359 kB? (?)
    apk (release)?1.72 MB? (?)
  • firebase-datatransport

    TypeBase (bad35ef)Merge (78e223c)Diff
    aar?4.94 kB? (?)
    apk (aggressive)?161 kB? (?)
    apk (release)?1.35 MB? (?)
  • firebase-firestore

    TypeBase (bad35ef)Merge (78e223c)Diff
    aar?1.34 MB? (?)
    apk (aggressive)?518 kB? (?)
    apk (release)?3.94 MB? (?)
  • firebase-functions

    TypeBase (bad35ef)Merge (78e223c)Diff
    aar?45.3 kB? (?)
    apk (aggressive)?400 kB? (?)
    apk (release)?1.81 MB? (?)
  • firebase-inappmessaging

    TypeBase (bad35ef)Merge (78e223c)Diff
    aar?452 kB? (?)
    apk (aggressive)?700 kB? (?)
    apk (release)?3.95 MB? (?)
  • firebase-inappmessaging-display

    TypeBase (bad35ef)Merge (78e223c)Diff
    aar?180 kB? (?)
    apk (aggressive)?1.53 MB? (?)
    apk (release)?5.21 MB? (?)
  • firebase-installations

    TypeBase (bad35ef)Merge (78e223c)Diff
    aar?55.2 kB? (?)
    apk (aggressive)?114 kB? (?)
    apk (release)?1.28 MB? (?)
  • firebase-perf

    TypeBase (bad35ef)Merge (78e223c)Diff
    aar?315 kB? (?)
    apk (aggressive)?957 kB? (?)
    apk (release)?2.95 MB? (?)
  • firebase-storage

    TypeBase (bad35ef)Merge (78e223c)Diff
    aar?115 kB? (?)
    apk (aggressive)?361 kB? (?)
    apk (release)?1.59 MB? (?)
  • protolite-well-known-types

    TypeBase (bad35ef)Merge (78e223c)Diff
    aar?999 kB? (?)
    apk (aggressive)?134 kB? (?)
    apk (release)?666 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/4tIhmfTJKU.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 2, 2023

Coverage Report 1

This report is too large (133,391 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/LPZ5bnUOVX.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 2, 2023

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (78e223c) and the base commit (bad35ef) are not available.

No macrobenchmark data found for the base commit (bad35ef). Analysis for the CI merge commit (78e223c) can be found at:

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/UdmMConZxj/index.html

@rlazo rlazo enabled auto-merge (squash) May 2, 2023 23:34
@rlazo rlazo requested a review from emilypgoogle May 2, 2023 23:34
@rlazo rlazo requested a review from daymxn May 3, 2023 17:38
Copy link
Member

@daymxn daymxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checked with the release branch and all looks good!

@rlazo rlazo merged commit b1f2130 into master May 3, 2023
@rlazo rlazo deleted the rl131ver branch May 3, 2023 17:44
@firebase firebase locked and limited conversation to collaborators Jun 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants